search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.86k stars 2.33k forks source link

Duplicate entries in the Spell check context menu #18960

Open nastavoi opened 3 years ago

nastavoi commented 3 years ago

Description

I've noticed two bugs with Languages and Spell check settings in the latest Brave Nightly and Brave Beta installed on Windows 11 x64 with Polish (Poland, pl_PL) locale:

  1. There are duplicate entries in the Spell check context menu
  2. There is no comment This language is used to display the Brave UI (Ten język jest używany do wyświetlania Brave UI in Polish) under Polish in Languages settings by default, but the comment appears if I change Brave language from Polish to English US and then from English US to Polish. This action also rearrange languages in Spell check context menu, but doesn't delete duplicates.

Steps to Reproduce

1st issue (screenshot 1, 2):

  1. Install Brave Beta or Brave Nightly on Windows 11 x64 with Polish (Poland, pl_PL) locale so that the browser will have Polish (polski) language enabled by default.
  2. Right-click on any text field
  3. Go to Sprawdzanie pisowni (Spell check) and notice that there are two polski (Polish) entries whereas there is only one entry in the Languages settings.

2nd issue (screenshot 3, 4):

  1. Go to Languages settings and notice that Polish is on the top of the list of preferred languages (above English US) and there is no comment stating it's used to display the Brave UI.
  2. Change the browser locale to English US by clicking three dots next to it and then Display Brave in this language - screenshot 3.
  3. Change the browser locale to Polish again - screenshot 4.
  4. Notice that there is a comment under Polish stating This language is used to display the Brave UI.

Actual result:

SS 1 ss1

SS 2 ss2

SS 3 ss3

SS 4 ss4

Expected result:

There shouldn't be any duplicates in the Spell check context menu. As for the missing comment - current browser behaviour seems inconsistent to me but I'm not sure if it's a bug or not.

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

Brave | 1.32.76 Chromium: 95.0.4638.54 (Oficjalna wersja) beta (64-bitowa) -- | -- Wersja | d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871} System operacyjny | Windows 11 Version 21H2 (Build 22000.282) Brave | 1.33.29 Chromium: 95.0.4638.54 (Oficjalna wersja) nightly (64-bitowa) -- | -- Wersja | d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871} System operacyjny | Windows 11 Version 21H2 (Build 22000.282)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

nastavoi commented 3 years ago

Still there in the latest beta and nightly.

nastavoi commented 2 years ago

Just wanted to let you know that it is still there.

nastavoi commented 2 years ago

Still there.