search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.8k stars 2.33k forks source link

Support `brave://...` links in promo cards in Brave Rewards settings page #19009

Open Miyayes opened 3 years ago

Miyayes commented 3 years ago

Description

Promo cards on Brave Rewards settings page brave://rewards currently don't support brave:// links.

Solution

Support brave:// links.

Miyayes commented 3 years ago

Generally speaking, you cannot go from brave:// url to brave:// url, so you would need a workaround. May go against Chromium architecture/patterns which were put in place for security reasons.

Miyayes commented 3 years ago

@jumde points out that: If we transition promo cards to polymer, we should be able to invoke brave://links similar to - https://github.com/brave/brave-core/blob/master/browser/resources/settings/brave_default_extensions_page/brave_default_extensions_page.js#L101

Miyayes commented 2 years ago

@minkyeongshin For new Rewards design in brave://wallet, keep these promotional units in mind. You may want to implement something like them over there too.