Brave shield hide the share button of filebrowser

UbioZur commented 3 years ago

Description

On the desktop, Brave shield hide the share option of filebrowser (self hosted file browser and sharing) On the Android version there is no problem.

File browser issues:

UBlock origin doesn't hide it anymore, just brave shield.

Button html code <button aria-label="Share" title="Share" class="action"><i class="material-icons">share</i><span>Share</span></button>

Steps to Reproduce

spin an instance of filebrowser (I don'e think there is a demo sadly)
no share button
Desactivate the shield
There is the share button

Actual result:

https://user-images.githubusercontent.com/4463497/51022533-99dc9480-15d8-11e9-8c43-c7dafb54318d.png

Expected result:

Share button visible

Reproduces how often:

100% of the time

Brave version (brave://version info)

Brave	1.22.71 Chromium: 89.0.4389.114 (Official Build) (64-bit)
Revision	1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS	Linux
JavaScript	V8 8.9.255.24
User Agent	Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.114 Safari/537.36

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? Yes
Does the issue resolve itself when disabling Brave Rewards? No
Is the issue reproducible on the latest version of Chrome? No Idea I don't have chrome installed

Miscellaneous Information:

Brave shield does not show ANY blocked items, it says 0, yet it is blocking some items! The html is there, but nothing is displayed. Yet when the shield is off, the html is displaying the share button properly!

I can set the shield at off (Obviously), but it should either show that it is blocking an item, or not block it at all!

rebron commented 3 years ago

cc: @ryanbr

ryanbr commented 3 years ago

Okay removed filter, only applicable with Enabling Fanboy Social/Annoyances. It wouldn't be blocked by Brave default @UbioZur ?

UbioZur commented 2 years ago

I do have enabled

Fanboy Annoyances List
Fanboy Social List
uBlock Annoyances List (used with Fanboy Annoyances List)

I don't remember if I enabled them when I first installed brave or not, It's been a while and I had to google to find this setting. But I do think I have enabled them as some of them are specific to where I would travel the most.

I somehow can't replicate it anymore, the button is working with the shield on now, so I guess the filters don't require a brave update (Which makes sense)

As for either or not it should or not be disable by default, it hard, because it is a shared button (usually used for social media), but it is one of the feature of filebrowser to get a link to share a file or folder (as any cloud drives would have).

brave / brave-browser