brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.76k stars 2.32k forks source link

Deprecate `BraveAds.EpsilonGreedyBanditStudy` griffin study #19176

Closed tmancey closed 1 year ago

tmancey commented 2 years ago
        {
            "name": "BraveAds.EpsilonGreedyBanditStudy",
            "experiments": [
                {
                    "name": "Treatment",
                    "probability_weight": 10,
                    "feature_association": {
                        "enable_feature": ["EpsilonGreedyBandit"],
                        "disable_feature": ["TextClassification"]
                    },
                    "parameters": [
                      {
                        "name": "epsilon_value",
                        "value": "0.33"
                      }
                    ]
                },
                {
                    "name": "Control",
                    "probability_weight": 10
                },
                {
                    "name": "Default",
                    "probability_weight": 80
                }
            ],
            "filter": {
                "channel": ["RELEASE","BETA", "NIGHTLY"],
                "platform": ["WINDOWS", "MAC", "LINUX", "ANDROID"],
                "country": ["GB"]
            }
        },
tmancey commented 2 years ago

Before deprecating studies where the feature is enabled by default we should ensure that all users, especially Android users, have proper feature values in the code across all platforms. If the feature is disabled by default then we should test that the default values are working as expected

tmancey commented 1 year ago

Agreed with @ptjames that this study can be removed, thanks