brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.62k stars 2.29k forks source link

wallet: using `window.ethereum` opens the old wallet extension #19531

Closed hazae41 closed 2 years ago

hazae41 commented 2 years ago

Description

When connecting to a dApp that uses window.ethereum, Brave opens a pop-up related to the old wallet extension, instead of the new Brave Wallet.

Steps to Reproduce

  1. Setup the old wallet extension
  2. Update Brave
  3. Setup the new Brave Wallet
  4. Connect to a dApp

Actual result:

Brave opens a pop-up related to the old wallet extension

Expected result:

Brave opens a pop-up related to the new Brave Wallet

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.32.106 Chromium: 96.0.4664.45

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

I guess it happens because I had setup the old wallet extension.

bbondy commented 2 years ago

Please check your brave://settings/wallet default wallet. If it's already set to Brave Wallet then maybe you have added another wallet manually in the past? Check your brave://extensions if so

bbondy commented 2 years ago

This is all explained here https://github.com/brave/brave-browser/wiki/Wallet-support-FAQ#my-metamask-or-other-extension-is-not-working-with-dapps Closing this since it's not a task.