search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.01k stars 2.22k forks source link

Change naturally "Disconnected" state to say "Logged out" (verified Rewards wallet) #19674

Closed Miyayes closed 2 years ago

Miyayes commented 2 years ago

Description

Change the naturally Disconnected state to say "Logged out", which better reflects the meaning.

Naturally Disconnected state = when the access token expires, for example.

image

Also makes better sense with this error notification:

image

emerick commented 2 years ago

@Miyayes mentioned picking this one up, so reassigning to me. :-)

GeetaSarvadnya commented 2 years ago

Verification PASSED on

Brave | 1.35.77 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
-- | --
Revision | adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS | Windows 10 Version 21H2 (Build 19044.1415)
Uphold_Logged out-state verification - Clean profile, enable rewards via BR panel and connect to a verified Uphold wallet. - Disconnect the wallet via https://sandbox.uphold.com/dashboard->Settngs->Applications->Brave->Remove - Confirmed that `Your wallet is logged out` popup message is shown as expected https://github.com/brave/brave-browser/issues/19674#issue-1060793500 Example | Example ------|---- ![image](https://user-images.githubusercontent.com/38657976/148758464-e76b4225-7863-4fe0-a513-5a77f2b00f6b.png) | ![image](https://user-images.githubusercontent.com/38657976/148918444-d9d8fc11-8f08-4e02-98bf-6adc3ad4ccc2.png) - Confirmed click on `x` closes the popup message - Confirmed `Logged out` wallet state message is shown in the BR panel
bitFlyer_Logged out-state verification - Clean profile, enable rewards via BR panel and connect to a verified bitFlyer wallet. - Disconnect the wallet - Confirmed that `Your wallet is logged out` popup message is shown as expected https://github.com/brave/brave-browser/issues/19674#issue-1060793500 Example | Example ------|---- ![image](https://user-images.githubusercontent.com/38657976/148918158-46af301a-69b5-42d0-b50f-3cc23d1fb0d3.png) | ![image](https://user-images.githubusercontent.com/38657976/148918282-75cc5e6f-4154-4351-96a6-0fa708bbf12b.png) - Confirmed click on `x` closes the popup message - Confirmed `Logged out` wallet state message is shown in the BR panel
GeetaSarvadnya commented 2 years ago

When uphold wallet is disconnected naturally, The logged out overlay shows the option as Log out from uphold should it be Log out from Brave Rewards? Looks like as per the issue https://github.com/brave/brave-browser/issues/19626 the option Log out from uphold is expected. Just want the confirmation. cc: @Miyayes @emerick

RC 1.34.x 1.35.x
image image
emerick commented 2 years ago

@GeetaSarvadnya That's intentional, per https://github.com/brave/brave-browser/issues/19626.