search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.56k stars 2.28k forks source link

Add setting to specify price source for tokens in custom web3 network #19838

Open eMaringolo opened 2 years ago

eMaringolo commented 2 years ago

If you define your own network to the newest Web3 wallet it is very likely that the symbols that you use are not in CoinGecko or there are name collisions with these symbols.

It would be good to be able to specify an URL or pattern to get the price feed (in an API that's compatible with that of CoinGecko), so you can specify the price lookup URL.

This is particularly relevant for me using networks such as RSK in platforms like Sovryn or Money on Chain.

The other option would be to hide the price valuation as a whole, but having the wrong prices is misleading.

bitcoinuser commented 2 years ago

Hi, I use Brave wallet with Sovryn too. Do you reproduce this problem? https://community.brave.com/t/bug-when-locking-brave-wallet/305804/2

Thanks.