brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.01k stars 2.22k forks source link

Link on brave://connection-help points to Chrome support page #19851

Open alucarded opened 2 years ago

alucarded commented 2 years ago

Description

Link to Chrome support page.

Steps to Reproduce

  1. Go to brave://connection-help/
  2. Toggle last "SHOW MORE"
  3. Click "Brave help center"

Actual result:

Chrome support page is loaded.

Expected result:

Brave support page is loaded.

Reproduces how often:

Always

Brave version (brave://version info)

1.32.113 Chromium: 96.0.4664.45 (Official Build) (64-bit)

Version/Channel Information:

Current stable release

Other Additional Information:

N/A

Miscellaneous Information:

N/A

alucarded commented 2 years ago

See kHelpCenterConnectionHelpUrl in src\chrome\browser\ssl\connection_help_tab_helper.cc

rebron commented 2 years ago

@alucarded I'm not seeing a link on that page. Can you pull a screenshot when you get a chance?

Screen Shot 2021-12-01 at 12 02 57 PM
alucarded commented 2 years ago

brave_google_link

Also full brave://version contents:

Brave   1.32.113 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision    76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS  Windows 10 Version 21H1 (Build 19043.1348)
JavaScript  V8 9.6.180.12
User Agent  Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.45 Safari/537.36
Command Line    "C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe" --disable-client-side-phishing-detection --disable-domain-reliability --enable-dom-distiller --no-pings --component-updater=url-source=https://go-updater.brave.com/extensions --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --enable-features=LegacyTLSEnforced,WebUIDarkMode,PasswordImport,ReducedReferrerGranularity,PrefetchPrivacyChanges,AutoupgradeMixedContent,WinrtGeolocationImplementation,SafetyTip --disable-features=AppDiscoveryRemoteUrlSearch,AutofillEnableAccountWalletStorage,TextFragmentAnchor,LiveCaption,Prerender2,Fledge,ReadLater,IdleDetection,FlocIdComputedEventLogging,HandwritingRecognitionWebPlatformApiFinch,ConversionMeasurement,InterestGroupStorage,SignedExchangeSubresourcePrefetch,NavigatorPluginsFixed,Parakeet,TabGroupsFeedback,WebSQLInThirdPartyContextEnabled,AutofillServerCommunication,FederatedLearningOfCohorts,ReportAllJavaScriptFrameworks,InterestCohortFeaturePolicy,CopyLinkToText,TrustTokens,DirectSockets,InterestCohortAPIOriginTrial,FirstPartySets,AdInterestGroupAPI,ComputePressure,NotificationTriggers,WebOTP,NetworkTimeServiceQuerying,SubresourceWebBundles,SpeculationRulesPrefetchProxy --flag-switches-begin --flag-switches-end
Executable Path C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe
Profile Path    C:\Users\user\AppData\Local\BraveSoftware\Brave-Browser\User Data\Default
Variations  AdRewardsStudy:NextPaymentDay
ConversionsStudy:NewDefaultPattern
Default1pBlockingStudy:Disabled
EphemeralStorageStudy:Enabled
NativeCosmeticFilteringStudy:Enabled
PartitionConnectionsByNetworkIsolationKeyStudy:Enabled
PermissionLifetimeReleaseStudy:Enabled
RequestAdsEnabledApiStudy:Enabled
SpeedreaderReleaseStudy:Enabled

I can create a PR. I guess this should be the link: https://support.brave.com/hc/en-us/articles/360059254971-What-do-the-connection-error-codes-mean- (see: "Software on your computer is stopping Brave from safely connecting to the web")