search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.52k stars 2.27k forks source link

Ship Shields blocklists with browser #2016

Open tildelowengrimm opened 5 years ago

tildelowengrimm commented 5 years ago

As noted in brave/internal#450, it's possible to bypass Shields protections on first run if you're quick. Because Shields lists aren't shipped with the binary, there's effectively a race condition about whether you get the Shields list or the the your first site visit faster. This isn't a great look.

Instead, we should bake an initial set of Shields lists into the binaries on all platforms. Once installed, lists can be upgraded as usual, but that doesn't leave that possible lag period.

iOS: brave/brave-ios#384 Android: brave/browser-android-tabs#816

srirambv commented 5 years ago

Would be better to make shields settings as component updater similar to ABP list that get downloaded and updated automatically with new changeset. The same should be done for site shields exceptions(Allow all cookies/allow all fingerprinting) which should solve most of the webcompat issues

tildelowengrimm commented 5 years ago

Using the component updater is a fine way to maintain shields updates, but it doesn't solve the race condition that it's possible to start browsing unprotected before the lists are downloaded.

ryanbr commented 3 years ago

@srirambv safe to close?