brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.84k stars 2.33k forks source link

Cannot detect mobile data on degoogled android #20229

Closed m77e4t closed 2 years ago

m77e4t commented 2 years ago

Description

On a degoogled android custom ROM without microg and without google play services it has a minor bug. The bug is that when using mobile data 3g/4g from SIM card, it cannot detect internet service even when internet/data is On. There is no problem when using Wi-fi, it can detect internet then, but not when using mobile data.

Steps to reproduce

  1. Degoogled android with mobile data on
  2. Wifi or other network connection off

Actual result

https://user-images.githubusercontent.com/96620334/147476376-e643c28d-5a14-409d-882b-54e931251dfa.mp4

Expected result

In top-middle it says 'no internet connection'

Issue reproduces how often

Always

Version/Channel Information:

All versions - Can you reproduce this issue with the current Play Store version? Yes - Can you reproduce this issue with the current Play Store Beta version? Probably yes - Can you reproduce this issue with the current Play Store Nightly version? Probably yes ## Device details - Install type (ARM, x86): - Device type (Phone, Tablet, Tablet): Phone - Android version: Android 11, Custom ROM with no gapps, no microg and no google services framework (gsf) ## Brave version Brave 1.33.106, Chromium 96.0.4664.110 (latest) ### Additional information Degoogled custom android ROM with no gapps, no microg will be needed.
m77e4t commented 2 years ago

CC:- @anthonypkeane @jamesmudgett (if you are not the android devs, do cc/ping the ones)

Is the issue solvable, or it cannot be solved? I think the problem has arised due to Brave android too much dependency on Safetynet. The bug is quite irritating while watching movies/videos in full screen mode, as the error bar is visible. I have to use Wi-Fi to watch videos.

timchilds commented 2 years ago

@deeppandya to verify on android emulator.

m77e4t commented 2 years ago

My problem has been automatically solved either from my 'de-googled' OS code change or from brave browser code change.

Most likely it was due a to a recent OS upgrade I did. This upgrade was a major one, migrating from android 11 to android 12, which might have solved this issue on it's own.