brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.57k stars 2.28k forks source link

Tab search dropdown partially appears on the left in Full Screen mode #20395

Open Quixot1k opened 2 years ago

Quixot1k commented 2 years ago

Description

Search Bar at a really wrong place that you can barely see the whole of it while canceling 'Always Show Toolbar in Full Screen'

Steps to Reproduce

  1. Uncheck Always Show Toolbar in Full Screen to hide toolbar in Full Screen mode.
  2. Enter Full Screen Mode
  3. Shift + Command + A (Open Search Tab) and notice that Tab Search menu is on the left side of screen and should be on the right side.

edited by @rebron

Actual result:

Search Tab

Expected result:

It should be on the right side of the page like when 'Always Show Toolbar in Full Screen' is on Search Tab II

Reproduces how often:

100%

Brave version (brave://version info)

Brave | 1.34.80 Chromium: 97.0.4692.71 (Official Build) (arm64) Revision | adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247} OS | macOS Version 12.1 (Build 21C52)

Other Recommendation(s):

Since you can open Search Tabs by Shift+Command+A, you should also make it possible to close it by this shortcut which I think is better than hitting 'ESC'.

Brave-Matt commented 1 year ago

+1 from Community: https://community.brave.com/t/search-in-tabs-cmd-shift-a-is-still-shown-to-the-left-of-the-browser-and-mostly-outside-of-the-screen/431048

ElijahLynn commented 7 months ago

New merged topic is here https://community.brave.com/t/search-in-tabs-cmd-shift-a-is-shown-to-the-left-of-the-browse-and-mostly-outside-of-the-screen/410349

ElijahLynn commented 7 months ago

I have this issue too, but per a suggestion from the community thread above, it does work correctly in the guest profile. Worth noting that in my problem profile, if I turn on vertical tabs then it works fine, when I turn vertical tabs off again, it is broken again and appears off screen to the left like the OP.


Brave | 1.62.156 Chromium: 121.0.6167.139 (Official Build) (arm64)
-- | --
Revision | 800674fc2c6162087525ed9b5bfc07230296b27d
OS | macOS Version 14.1.2 (Build 23B92)
JavaScript | V8 12.1.285.28
User Agent | Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36
-- | --
Command Line | /Applications/Brave Browser.app/Contents/MacOS/Brave Browser --disable-domain-reliability --enable-distillability-service --enable-dom-distiller --lso-url=https://no-thanks.invalid --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --variations-insecure-server-url=https://variations.brave.com/seed --variations-server-url=https://variations.brave.com/seed --restart --flag-switches-begin --flag-switches-end --component-updater=url-source=https://go-updater.brave.com/extensions,url-source=https://go-updater.brave.com/extensions
Executable Path | /Applications/Brave Browser.app/Contents/MacOS/Brave Browser
Profile Path | /Users/user/Library/Application Support/BraveSoftware/Brave-Browser/Default
Linker | lld
Active Variations | AllowCertainClientHintsStudy:EnabledBraveAIChatEnabledStudy:EnabledBraveAdblockMobileNotificationsListDefault:EnabledBraveAds.AdServingStudy:DefaultAdNotificationsPerHour=10\|MaximumAdNotificationsPerDay=100\|MaximumInlineContentAdsPerHour=6\|MaximumInlineContentAdsPerDay=20\|AdServingVersion=2BraveAutoTranslateStudy:AutoTranslateDisabledBraveCleanupSessionCookiesOnSessionRestore:DisabledBraveDebounceStudy:EnabledBraveFeedUpdateStudy:EnabledBraveForgetFirstPartyStorage:EnabledBraveGoogleSignInPermissionStudy:EnabledBraveHorizontalTabsUpdateEnabledStudy:EnabledBraveHttpsByDefaultRolloutStudy:EnabledBraveP3AConstellationEnabled:EnabledBraveP3ATypicalJSONDeprecationEnabled:EnabledBraveRewardsWebUiPanelStudy:EnabledBraveScreenFingerprintingBlockerStudy:EnabledBraveSearchAdStudy:EnabledClampPlatformVersionClientHint:DisabledCloseWatcher:Disabled_EmergencyKillSwitchCookieListDefaultStudy:EnabledCrossPlatformVPNStudy:EnabledDefault1pBlockingStudy:DisabledDisableReduceLanguage:EnabledEphemeralStorageStudy:EnabledFirstPartyEphemeralDomainBlockStudy:EnabledForceDisableBlinkFeatures:EnabledMacCoreLocationBackendStudy:EnabledPartitionBlinkMemoryCacheStudy:EnabledPartitionConnectionsByNetworkIsolationKeyStudy:EnabledPermissionLifetimeReleaseStudy:EnabledSpeedreader TTS:EnabledUserActivityStudy:TriggersWhatsNewStudy:Enabled
ElijahLynn commented 7 months ago

After tinkering with other settings: I just fixed it by toggling the "show tab search button" (brave://settings/appearance). It works now with that feature either off OR on. Previously it was initially off.

🚀 🔥 🎸 🚀 🔥 🎸🚀 🔥 🎸🚀 🔥 🎸🚀 🔥 🎸

ElijahLynn commented 7 months ago

Although, I just had it happen again after I opened a new window. And the toggle "show tab search button" trick worked again, but it appears to happen again for each new window. So not actually resolved, but it is a workaround.

Edit: still broken after a brave://restart but the toggling workaround still works

skupjoe commented 4 months ago

(I'm not having this specific issue, but) Is there a way to change the position of the tab search to either left or right? Maybe a beta feature?

Or is it only currently possible to have the Tab Search button appear on the right side?

Chrome has it on the left side and I sorta prefer that.

ElijahLynn commented 4 months ago

(I'm not having this specific issue, but) Is there a way to change the position of the tab search to either left or right? Maybe a beta feature?

I recommend opening a new support request for your question.