search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.86k stars 2.33k forks source link

Enable Chromecast support #209

Closed bsclifton closed 5 years ago

bsclifton commented 6 years ago

Need to enable Chromecast?

See https://github.com/brave/brave-browser/issues/209#issuecomment-459846613 and https://github.com/brave/brave-browser/issues/209#issuecomment-468966429

Description

It should be easy to toggle support for Chromecast. Given the steps above (enabling in brave://flags, etc) it isn't trivial to enable.

Original issue description

Carried over from browser-laptop

Starting with Chrome 51, casting support should be built in. We need to:

weems commented 6 years ago

I would like this feature as well, and am willing to help if/when needed

Cheers

CaseyLabs commented 5 years ago

Just checking in on the status of Chromecast in Brave. It looks like it's partially supported as an option, but trying to use it results in "No cast destinations found".

Chromecast support is basically the one road block preventing me from switching from Chrome to Brave full-time.

Brave-Matt commented 5 years ago

Several +1's from Community: https://community.brave.com/t/cast-not-finding-any-devices/31757/4 https://community.brave.com/t/chrome-extension-err-failed/3198/2 https://community.brave.com/t/chromecast-support/38148

Brave-Matt commented 5 years ago

+1 from Reddit: https://www.reddit.com/r/brave_browser/comments/a41h2n/when_are_we_getting_chromecast_support/

mailtoharshit commented 5 years ago

+1 for this, I can help

eljuno commented 5 years ago

+1 from Community https://community.brave.com/t/casting-does-not-find-any-devices-no-devices-found/39656?u=eljuno

Brave-Matt commented 5 years ago

It seems that there's a flag that can be flipped to enable Chromecast support. #load-media-router-component-extension works. Is there any special reason users shouldn't enable this flag?

liamaharon commented 5 years ago

Hi @Brave-Matt, could you please elaborate on how you enabled Chromecast support? I've tried starting brave with that flag, but still none of my Chromecast destinations appear. Checking in Chrome, they appear with no issues.

How I'm launching brave: brave-browser --load-media-router-component-extension

Would love to get this working, thanks for your help.

Brave-Matt commented 5 years ago

@liamaharon, Bare in mind that this hasn't been fully tested on our end - I cant guarantee complete compatibility. That said, I enabled this via brave://flags, although that command should work. What OS/build?

liamaharon commented 5 years ago

@Brave-Matt no worries, I understand it's still experimental.

I updated Brave to make sure I was on the latest version, and it's exhibiting some different behaviour to before: Regardless of if the load-media-router... flag is enabled or disabled (using the brave://flags GUI now:

Tried casting from Chromium v71.0.3578.80, which worked fine.

OS: Ubuntu 18.04 Brave build: Version 0.58.16 Chromium: 71.0.3578.98 (Official Build) (64-bit)

ngtvpgmnt commented 5 years ago

Any further news on Chromecast support? It's the main feature I'm waiting for before I can fully adopt. Updated to Version 0.58.18 Chromium: 71.0.3578.98 (Official Build) (64-bit) on MacOS. Enabled suggested flags but still the same result as @liamaharon was having above.

olibri-us commented 5 years ago

Hey guys, same here, would love to cast so a big +1 :) Also, enabling the "load-media-router..." option didn't do the trick, using Brave version 0.58.18, works fine on the same Chromium version as @cbretski

Jeff9000 commented 5 years ago

Is Casting an issue or not?

olibri-us commented 5 years ago

Yeah it is, nothing shows up when I click the option in the hamburger menu of my browser, on both mac and linux. At least they could maybe hide the option if it's not supported because it's very confusing :/

mandree95 commented 5 years ago

EDIT: It works for me.

ghost commented 5 years ago

After enabling "#load-media-router-component-extension", I noticed the Chromecast dialog opens on the left side of the browser window, rather than in the middle.

As a result, when the browser window is full-screen, it seems like nothing happens after selecting "Cast..."

cast

olibri-us commented 5 years ago

OMG you are right @glowacky, i can definitely reproduce what you are doing in the GIF. I don't have a chromecast at home but I will try at work to see if I can cast something. Then the problem would only be the location of that dialog.

olibri-us commented 5 years ago

Ok so more info about my problem : image

I do have the window appearing where @glowacky mentionned, but for some reason on Fedora 29 using Plasma Desktop (KDE) It is cropped so I can't reach its content (cf. screen capture)

Still using Brave 0.58.21 Chromium: 71.0.3578.98

ghost commented 5 years ago

I had the exact same issue.

I'm running:

Manually enabling the #load-media-router-component-extension flag in brave://flags worked for me though.

image

Brave-Matt commented 5 years ago

You must enable the #load-media-router-component-extension as well as the #views-cast-media in order to cast.

This will resolve any issue with any unable to interact with or view the dialogue box.

Edit: #views-cast-dialog is the correct second extension. My mistake!

olibri-us commented 5 years ago

Hi, thanks for the feedback ! I tried to do as you suggested : manually enable #load-media-router-component-extension. I could not find #views-cast-media in my version, but I found #views-cast-dialog and enabled it just to try. With or without it, I still have the same bug : cast dialog appears truncated on the left, just like in my last screenshot... It's a pity because that's all I need to remove this Chrome from my computer...

image

liamaharon commented 5 years ago

I'm experiencing the exact same as @jamendub

ghost commented 5 years ago

@jamendub can you cast your screen? It looks the same for me.

olibri-us commented 5 years ago

Well i don't know, as i can't see the content of the window which is supposed to allow me to cast

Brave-Matt commented 5 years ago

For everyone trying to cast after enabling both the #load-media-router-component-extension as well as the #views-cast-dialog:

ghost commented 5 years ago

After enabling both #load-media-router-component-extension and #views-cast-dialog, the dialog still opens on the left side of the window.

I am able to cast to a Chromecast "stick", but I have to manually resize the window in order to view the dialog.

MacOS: Version 10.14.2 Brave Browser: Version 0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)

Jeff9000 commented 5 years ago

The lack of casting and the setting of magic flags is a real turn off and I’m starting to lean towards going back to Chrome if this is not resolved soon.

Is there a Bug ticket on this or not?

Specifically, my problem is “No Devices Found” when I have a Google Chromecast device as well as an Android TV that is a casting device. Of course, Google Chrome finds and presents all devices and then it casts perfectly.

Again, is someone actually working on this BUG or are we just talking about it on a blog?

From: glowacky notifications@github.com Sent: Wednesday, January 30, 2019 4:51 PM To: brave/brave-browser brave-browser@noreply.github.com Cc: Jeff9000 github@jeff9000.com; Comment comment@noreply.github.com Subject: Re: [brave/brave-browser] Chromecast support (#209)

After enabling both #load-media-router-component-extension and #views-cast-dialog, the dialog still opens on the left side of the window.

I am able to cast to a Chromecast "stick", but I have to manually resize the window in order to view the dialog.

MacOS: Version 10.14.2 (18D42) Brave Browser: Version 0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/brave/brave-browser/issues/209#issuecomment-459170854, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AmFMMD11wQXg4K55gNMRaAkTkQyvO-eDks5vIj3egaJpZM4UEK9T.

Brave-Matt commented 5 years ago

For anyone following or curious about Chromecast support in Brave, some notes and things to remember based on my personal experience/testing:

1. In order to enable (or attempt to) Chromecast, you must set both the following flags (brave://flags):

  1. You may want to try rebooting your system after changing the flags. I've had a couple users report that they were unable to cast but later confirmed that it started working after reboot.

  2. For those of you asking if this is a bug or if there's a "fix" for this - the answer is no. This is not actually a "Brave" feature, but is a feature of the chromium engine. Since we haven't implemented, it subsequently has not been tested - meaning that there may be issues with it that aren't addressed because we're not currently "supporting" it (from a dev standpoint) at this time. What you are essentially doing is toggling on two settings (flags) in the engine that (ideally) allow Brave to cast.

  3. Relevant information - If you'd like to help us look into this, if you're unable to cast (or you were successfully able to but still found yourself here), please provide as much info as possible and - more importantly - I'd like to know:

I'm able to view my available devices and cast media from any (applicable) source to my Chromecast enabled device in all Brave builds, using both macOS and Windows 10 Operating Systems: castdialog

Jeff9000 commented 5 years ago

Hi,

Thanks for the help.

Ok, setting #Views-cast-dialog to disabled shows a different cast dialog in the middle of the screen and the spinner spins and then the message “No cast destinations found. Need help?”.

I’m running the latest versions of Brave/Chromium.

In Chrome in the upper right there are the 3 dots. Clicking on that, even with no castable media selected and then clicking ‘Cast’ brings up the same dialog, but it shows all my devices (Chromecast Ultra, an Android TV, and my Google Mini).

However, clicking on the hamburger in the upper right in Brave and then clicking on ‘Cast’ the same blue dialog comes up and tells me “No cast destinations found. Need help?”.

Hearing that the lack of casting is not a bug is very disappointing when it clearly is a bug. I’m a software engineer and by all definitions this is a bug. Or is it going to be a feature that Brave will not support now or in the future?

Basically, I have all this hardware (castable devices) that I cannot use in Brave and it’s not a bug that will be addressed. I’m sorry, but this issue is going to be a showstopper for me soon and I will go back to Chrome.

From: Matthew Evangelista notifications@github.com Sent: Friday, February 1, 2019 11:52 AM To: brave/brave-browser brave-browser@noreply.github.com Cc: Jeff9000 github@jeff9000.com; Comment comment@noreply.github.com Subject: Re: [brave/brave-browser] Chromecast support (#209)

For anyone following or curious about Chromecast support in Brave, some notes and things to remember based on my personal experience/testing:

  1. In order to enable (or attempt to) Chromecast, you must set both the following flags (brave://flags):

    • load-media-router-component-extension - Set to Enabled

    • Views-cast-dialog - Set to Disabled. I apologize for my above comments about enabling this. I believe this may be the case for some users (that they have to enable this) but for others it may have the opposite effect - I just encountered this myself on my machine. I for sure know that leaving this at Default will not allow you to cast.

      [image]https://user-images.githubusercontent.com/3299098/52144824-390f0d80-2614-11e9-89eb-6c2c4699eb8e.png

    1. You may want to try rebooting your system after changing the flags. I've had a couple users report that they were unable to cast but later confirmed that it started working after reboot.
    2. For those of you asking if this is a bug or if there's a "fix" for this - the answer is no. This is not actually a "Brave" feature, but is a feature of the chromium engine. Since we haven't implemented, it subsequently has not been tested - meaning that there may be issues with it that aren't addressed because we're not currently "supporting" it (from a dev standpoint) at this time. What you are essentially doing is toggling on two settings (flags) in the engine that (ideally) allow Brave to cast.
    3. Relevant information - If you'd like to help us look into this, if you're unable to cast (or you were successfully able to but still found yourself here), please provide as much info as possible and - more importantly - I'd like to know:
    • What video source are you attempting to casting from? (YouTube, Hulu, built in menu cast button, etc)
    • What Chromecast device are you attempting to casting to? (Proprietary Chromecast "USB/Stick", Chromecast enabled device like a smart tv, etc)

I'm able to view my available devices and cast media from any (applicable) source to my Chromecast enabled device in all Brave builds, using both macOS and Windows 10 Operating Systems:

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/brave/brave-browser/issues/209#issuecomment-459846613, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AmFMMHLqFQM2p41BIiMk9rp8puk_KRpLks5vJJrFgaJpZM4UEK9T.

Brave-Matt commented 5 years ago

@Jeff9000, I didn't say that we "will never support chromecast in Brave":

[...]meaning that there may be issues with it that aren't addressed because we're not currently "supporting" it (from a dev standpoint) at this time.

The reason it's not a "bug" is because, again, we didn't make this feature - it was already there and disabled by default. There is clearly a compatibility issue for some users with the flags, but again, you'll note at the very top of the brave://flags it states explicitly that these feature are experimental.

Officially supporting (and likely moving the flags to configurable options in settings) is certainly on the table for Brave, but given the scope and number of large scale projects in development right now, I'm unable to give any sort of timeline or confirmation further than what I've already stated. So as it stands you'll have to stick with enabling/disabling the flags as per the steps above.

What happens when you attempt to cast directly from the media source? For example, if you visit Youtube and use the Cast button built into the player, what does the dialog box say?

Jeff9000 commented 5 years ago

What happens when you attempt to cast directly from the media source? For example, if you visit Youtube and use the Cast button built into the player, what does the dialog box say? Ok, simply done you can launch YouTube in Chrome, select a video and start playing it. In the bottom of the viewing area if you click your mouse or hover there you will see various rectangular icons like full screen, shrink screen, etc. And in Chrome you will see an icon that is the Cast icon. Click that and it will bring up the Cast dialog and you can select a device.

Brave, however, does not show the Cast icon at all. So, there is no Cast button to click in Brave while Chrome does have a Cast button.

While you say that you may not be supporting Casting at this time in terms of your Dev, I’m going to go back to Chrome for awhile and see which browser I prefer. I think that in terms of this issue being a bug, at the very least I would create a bug item for it. That does not mean that you have to actually work on that bug. But at least it’s on the radar instead of just being an issue in a blog that will eventually get lost.

From: Matthew Evangelista notifications@github.com Sent: Friday, February 1, 2019 12:32 PM To: brave/brave-browser brave-browser@noreply.github.com Cc: Jeff9000 github@jeff9000.com; Mention mention@noreply.github.com Subject: Re: [brave/brave-browser] Chromecast support (#209)

@Jeff9000https://github.com/Jeff9000, I didn't say that we "will never support chromecast in Brave":

[...]meaning that there may be issues with it that aren't addressed because we're not currently "supporting" it (from a dev standpoint) at this time. The reason it's not a "bug" is because, again, we didn't make this feature - it was already there and disabled by default. There is clearly a compatibility issue for some users with the flags, but again, you'll note at the very top of the brave://flags it states explicitly that these feature are experimental.

Officially supporting (and likely moving the flags to configurable options in settings) is certainly on the table for Brave, but given the scope and number of large scale projects in development right now, I'm unable to give any sort of timeline or confirmation further than what I've already stated. So as it stands you'll have to stick with enabling/disabling the flags as per the steps above.

What happens when you attempt to cast directly from the media source? For example, if you visit Youtube and use the Cast button built into the player, what does the dialog box say?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/brave/brave-browser/issues/209#issuecomment-459858178, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AmFMMGLspu9sAryz5To79xQ4oAlw0MDQks5vJKQqgaJpZM4UEK9T.

liamaharon commented 5 years ago

On Ubuntu, setting #load-media-router-component-extension and #views-cast-dialog to enabled I get the issue where the casting dialog renders off the end of the screen. On Windows, casting is working fine for me with both flags enabled.

Setting #views-cast-dialog to disabled on the Ubuntu machine, I get the 'No casting destinations found' issue other people are describing. I'm using the 2nd gen Google Chromecast device that plugs into an HDMI port in my TV, not a smart TV.

EDIT: With both flags enabled I can see the 'Cast' button on supported apps like YouTube, with the one flag disabled I can only try to screen mirror

Jeff9000 commented 5 years ago

You ask: What happens when you attempt to cast directly from the media source? For example, if you visit Youtube and use the Cast button built into the player, what does the dialog box say? I thought I answered this, but I don’t see it on the Github for this issue.

On YouTube in Chrome when you start a video in the bottom of the displaying video is a Cast icon in the player where you then cast and you can pick your device.

On YouTube in Brave when you start a video in the bottom of the displaying video there is NO Cast icon at all in the player.

At this point, I’m going back to Chrome. Losing the ability to cast to my TV is a showstopper for me.

Thanks.

From: Matthew Evangelista notifications@github.com Sent: Friday, February 1, 2019 12:32 PM To: brave/brave-browser brave-browser@noreply.github.com Cc: Jeff9000 github@jeff9000.com; Mention mention@noreply.github.com Subject: Re: [brave/brave-browser] Chromecast support (#209)

@Jeff9000https://github.com/Jeff9000, I didn't say that we "will never support chromecast in Brave":

[...]meaning that there may be issues with it that aren't addressed because we're not currently "supporting" it (from a dev standpoint) at this time. The reason it's not a "bug" is because, again, we didn't make this feature - it was already there and disabled by default. There is clearly a compatibility issue for some users with the flags, but again, you'll note at the very top of the brave://flags it states explicitly that these feature are experimental.

Officially supporting (and likely moving the flags to configurable options in settings) is certainly on the table for Brave, but given the scope and number of large scale projects in development right now, I'm unable to give any sort of timeline or confirmation further than what I've already stated. So as it stands you'll have to stick with enabling/disabling the flags as per the steps above.

What happens when you attempt to cast directly from the media source? For example, if you visit Youtube and use the Cast button built into the player, what does the dialog box say?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/brave/brave-browser/issues/209#issuecomment-459858178, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AmFMMGLspu9sAryz5To79xQ4oAlw0MDQks5vJKQqgaJpZM4UEK9T.

O1O1O1O commented 5 years ago

Just wanted to add after making both changes indicated by @Brave-Matt casting is working perfectly for me on a Macbook running Brave Version 0.59.35 Chromium: 72.0.3626.81 (Official Build) (64-bit)

I was able to cast music from Google Play Music, video from YouTube to a Chromecast device, also my Chrome tab and entire desktop.

I think my suggestion would be you find a way to disable the "Cast" option from the browser menu and build an extension to turn on the flags to make it work properly. Then it can be a conscious user decision to enable and those who don't want it or need it (all those Apple or Amazon only folks) don't have to worry about it or stumble into features that don't work for them.

dminca commented 5 years ago

For anyone following or curious about Chromecast support in Brave, some notes and things to remember based on my personal experience/testing:

1. In order to enable (or attempt to) Chromecast, you must set both the following flags (brave://flags):

  • #load-media-router-component-extension - Set to Enabled
  • #Views-cast-dialog - Set to Disabled. I apologize for my above comments about enabling this. I believe this may be the case for some users (that they have to enable this) but for others it may have the opposite effect - I just encountered this myself on my machine. I for sure know that leaving this at Default will not allow you to cast. image
  1. You may want to try rebooting your system after changing the flags. I've had a couple users report that they were unable to cast but later confirmed that it started working after reboot.
  2. For those of you asking if this is a bug or if there's a "fix" for this - the answer is no. This is not actually a "Brave" feature, but is a feature of the chromium engine. Since we haven't implemented, it subsequently has not been tested - meaning that there may be issues with it that aren't addressed because we're not currently "supporting" it (from a dev standpoint) at this time. What you are essentially doing is toggling on two settings (flags) in the engine that (ideally) allow Brave to cast.
  3. Relevant information - If you'd like to help us look into this, if you're unable to cast (or you were successfully able to but still found yourself here), please provide as much info as possible and - more importantly - I'd like to know:
  • What video source are you attempting to casting from? (YouTube, Hulu, built in menu cast button, etc)
  • What Chromecast device are you attempting to casting to? (Proprietary Chromecast "USB/Stick", Chromecast enabled device like a smart tv, etc)

I'm able to view my available devices and cast media from any (applicable) source to my Chromecast enabled device in all Brave builds, using both macOS and Windows 10 Operating Systems: castdialog

After applying everything as you said, I'm now able to Cast, but before I wasn't able to see the cast window (it was hidden in the top left corner).

image

After those were configured, I tried casting and there you go: screenshot from 2019-02-16 17-52-26

These are my specs:

One note, I didn't have to reboot the PC, just reopened the browser and it worked.

MikeDeRebel commented 5 years ago

Yup, just made an account here to confirm that everything works with the 2 settings implied above:

1. In order to enable (or attempt to) Chromecast, you must set both the following flags (brave://flags):

and here are my specs:

OS: Windows 10 (Surface) Browser: Version 0.59.35 Chromium: 72.0.3626.81 (Official Build) (64-bit)

joejoejo commented 5 years ago

I am running the latest beta version 0.61.45 and I don't have an option to keep the cast button in the toolbar. and also It does not even show the cast button when I click cast from the hamburger menu it just shows the casting dialog in the top left hand corner. Is there way to fix this?

TheRoarkster commented 5 years ago

I wanted to post what I did to get cast working in Brave (Version 0.62.14 Chromium: 73.0.3683.39 (Official Build) dev (64-bit)) running on Fedora 29. (kernel 4.20.13). This may help you @jamendub, as I had the exact same issue as you with the Cast dialog hiding behind the upper left side/corner of Brave.

First, let me just share an image of the working combo of brave://flags:

brave_flags

I found this combination by trying all 16 possible combinations (luckily, it worked at my 6th try). Basically, I just created a matrix with the flags down the left side (rows) and E (for enabled) or D (for disabled) in the center. At the bottom, I reported the results.

The flags, in order, were:

With all of those flags enabled, the Cast dialog box was visible as a white line in the upper left quadrant of Brave (see @jamendub's post above). There was no Chromecast icon to the right of the address bar.

With any sequence in which C was enabled, or C was disabled and W was enabled, I got the dialog box in the correct location and the Cast icon next to the address bar, but it reported the dreaded "No Cast Destinations Found" when clicked.

The only combination that worked for me -- meaning the dialog box was in the correct place, the Cast icon was next to the address bar, and the cast search found my destinations and played -- was W (disabled), L (enabled), C (disabled), and V (disabled).

I hope this helps someone. It definitely works in Fedora 29. And it is AWESOME to have cast on Brave.

joejoejo commented 5 years ago

I am running Windows 10 and everything described above does not work to get the casting icon to appear in the toolbar or get the casting dialog to leave the top left hand corner of the screen

liamaharon commented 5 years ago

Confirming TheRoarkster's solution is working for me on Ubuntu 18.04. Thank you!

Brave-Matt commented 5 years ago

+1 from reddit: https://www.reddit.com/r/brave_browser/comments/b0o6uw/any_plans_to_realise_the_casting_funcion_on_brave/

toChMonaThESta commented 5 years ago

So I think I've tried everything listed here and it is still not working for me. I set both flags and I get nothing. Capture Capture PNG1

Any ideas?

Capture PNG2 Capture PNG3

MaxiM-PL commented 5 years ago

+1 on behalf of all nVidia Shield TV users ;) I can't for the life of me enable it in 0.61.52

simonhong commented 5 years ago

Chrome cast dialog bug is fixed by https://github.com/brave/brave-core/pull/1836. It will be available from 0.64

jumde commented 5 years ago

PR reverted because of network-audit failures:

12:53:51  NETWORK AUDIT FAIL: https://clients2.google.com/service/update2/crx?os=linux&arch=x64&os_arch=x86_64&nacl_arch=x86-64&prod=chromiumcrx&prodchannel=unknown&prodversion=73.0.64.26&lang=en-US&acceptformat=crx2,crx3&x=id%3Dpkedcjkdefgpdelpbcmbmeomcjbeemfm%26v%3D0.0.0.0%26installedby%3Dother%26uc%26ping%3Dr%253D-1%2526e%253D1
12:53:51  NETWORK AUDIT FAIL: https://clients2.google.com/service/update2/crx?os=linux&arch=x64&os_arch=x86_64&nacl_arch=x86-64&prod=chromiumcrx&prodchannel=unknown&prodversion=73.0.64.26&lang=en-US&acceptformat=crx2,crx3&x=id%3Dpkedcjkdefgpdelpbcmbmeomcjbeemfm%26v%3D0.0.0.0%26installedby%3Dother%26uc%26ping%3Dr%253D-1%2526e%253D1
12:53:51  NETWORK AUDIT FAIL: https://extensionupdater.brave.com/service/update2/crx?os=linux&arch=x64&os_arch=x86_64&nacl_arch=x86-64&prod=chromiumcrx&prodchannel=unknown&prodversion=73.0.64.26&lang=en-US&acceptformat=crx2,crx3&x=id%3Dpkedcjkdefgpdelpbcmbmeomcjbeemfm%26v%3D0.0.0.0%26installedby%3Dother%26uc%26ping%3Dr%253D-1%2526e%253D1
12:53:51  NETWORK AUDIT FAIL: http://redirector.gvt1.com/edgedl/chromewebstore/L2Nocm9tZV9leHRlbnNpb24vYmxvYnMvMjJlQUFXRC12Ny1ldUFnMXF3SDlXZDlFZw/7319.128.0.1_pkedcjkdefgpdelpbcmbmeomcjbeemfm.crx
12:53:51  NETWORK AUDIT FAIL: http://redirector.gvt1.com/edgedl/chromewebstore/L2Nocm9tZV9leHRlbnNpb24vYmxvYnMvMjJlQUFXRC12Ny1ldUFnMXF3SDlXZDlFZw/7319.128.0.1_pkedcjkdefgpdelpbcmbmeomcjbeemfm.crx
12:53:51  NETWORK AUDIT FAIL: http://r6---sn-nx5e6ne6.gvt1.com/edgedl/chromewebstore/L2Nocm9tZV9leHRlbnNpb24vYmxvYnMvMjJlQUFXRC12Ny1ldUFnMXF3SDlXZDlFZw/7319.128.0.1_pkedcjkdefgpdelpbcmbmeomcjbeemfm.crx?cms_redirect=yes&mip=34.219.185.75&mm=28&mn=sn-nx5e6ne6&ms=nvh&mt=1553863827&mv=m&pl=12&shardbypass=yes
TheRoarkster commented 5 years ago

Well....I just updated to Brave Version 0.64.30 Chromium: 73.0.3683.75 (Official Build) dev (64-bit), and it broke my cast ability -- both with the flags set as previously posted and with no flags set.

The one step forward, though, was that there is now a cast button in Brave, with a nice integration, if you have no flags set. The two steps back is that I can no longer cast ("No Devices Found") with or without the flag settings.

TheRoarkster commented 5 years ago

Another few rounds of testing, and now the settings below work for the latest Brave Version 0.64.37 Chromium: 74.0.3729.40 (Official Build) dev (64-bit).

ON FEDORA WebRTC new encode cpu load estimator ENABLED Load Media Router Component Extension ENABLED Connect to Cast devices on all IP addresses ENABLED Views Cast dialog DEFAULT [OR, if want the non-integrated cast button: ENABLED]

ON UBUNTU WebRTC new encode cpu load estimator DISABLED Load Media Router Component Extension ENABLED Connect to Cast devices on all IP addresses DISABLED Views Cast dialog DEFAULT

It sort of makes sense because this version has a native Cast button and the Views Cast dialog flag enables an add-on Cast button.

** NOTE *** The above settings result in a "native" Cast button that is placed to the right of a divider and integrates with the Brave theme. HOWEVER, it does not have volume controls (or play/pause/forward), which makes it kind of hard to change the volume. SO, I ENABLED Views Cast Dialog, which disables the integrated button and enables the one where you can adjust volume.

bsclifton commented 5 years ago

Will need to look at re-implementing

Originally implemented with https://github.com/brave/brave-core/pull/2105 and then reverted with https://github.com/brave/brave-core/pull/2119

yp6128 commented 5 years ago

I wanted to post what I did to get cast working in Brave (Version 0.62.14 Chromium: 73.0.3683.39 (Official Build) dev (64-bit)) running on Fedora 29. (kernel 4.20.13). This may help you @jamendub, as I had the exact same issue as you with the Cast dialog hiding behind the upper left side/corner of Brave.

First, let me just share an image of the working combo of brave://flags:

brave_flags

I found this combination by trying all 16 possible combinations (luckily, it worked at my 6th try). Basically, I just created a matrix with the flags down the left side (rows) and E (for enabled) or D (for disabled) in the center. At the bottom, I reported the results.

The flags, in order, were:

* **W** WebRTC new encode cpu load estimator

* **L** Load Media Router Component Extension

* **C** Connect to Cast devices on all IP addresses

* **V** Views Cast dialog

With all of those flags enabled, the Cast dialog box was visible as a white line in the upper left quadrant of Brave (see @jamendub's post above). There was no Chromecast icon to the right of the address bar.

With any sequence in which C was enabled, or C was disabled and W was enabled, I got the dialog box in the correct location and the Cast icon next to the address bar, but it reported the dreaded "No Cast Destinations Found" when clicked.

The only combination that worked for me -- meaning the dialog box was in the correct place, the Cast icon was next to the address bar, and the cast search found my destinations and played -- was W (disabled), L (enabled), C (disabled), and V (disabled).

I hope this helps someone. It definitely works in Fedora 29. And it is AWESOME to have cast on Brave. Worked for me. Thanks !

bsclifton commented 5 years ago

@yp6128 thanks for sharing! Super glad you got it working 🎉

I'm working through getting this officially supported (out of the box, no changes needed). Pull requests are up and we're taking steps to make sure the calls that are made (since there are calls to Google servers) are proxied in a way our security team approves of 😄 Shout out to @simonhong for getting the main functionality squared away and @jumde for helping me on the security side

For folks that want to follow along, please check out: