optional updates - Githubissues

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.75k stars 2.32k forks source link

optional updates #211

Closed tommycarstensen closed 6 years ago

tommycarstensen commented 6 years ago

I was just forced to install the latest update and was unable to continue my browsing session before doing so. Could you please make the upgrades optional unless they are security updates? Thanks!

srirambv commented 6 years ago

You can follow the steps mentioned here. This is applicable for browser-laptop and not on brave-browser.

cbehan commented 5 years ago

All of the discussions about auto-updating don't even define what that is.

I have brave installed to a directory that is only writeable by root.
Setuid bit on the brave executable is off.
I run brave as an unprivileged user which is how a browser should always be run.

Now you can't honestly tell me that Brave has a team working round the clock to find kernel exploits that allow updates to still be installed in the above setup. Updates must already be enabled only for specific use cases. Can you be please be transparent about what those are for the benefit of people like me who are considering switching to Brave? Thanks.

bsclifton commented 5 years ago

@cbehan the original post was by a user of the old Electron based browser (accidentally posted here instead of the browser-laptop repo). An un-supported work-around was linked to

On the live product:

For Linux, auto-updates aren't happening. You'll have to do this yourself via apt/rpm/dnf/etc
For other platforms, updates will happen. It may be possible to disable updates, but that is not something we support

All of this said, what exactly are you asking, @cbehan? (having trouble understanding what is the question or ask)

cbehan commented 5 years ago

I'm asking what the conditions are for Brave to download an update. You have answered much of the question by saying that on Linux it never will (regardless of how many privileges the user has).

But are there other checks besides the OS and CPU? Right now, I'm imagining a Windows or Mac user who compiles his or her own executable. Is Brave smart enough to detect that the compilation flags were not the official ones and that therefore this custom build should not be replaced by the Windows or Mac updates online?

I'm sure there is a better place for discussing this. But the concern is fundamental enough that it should probably be on one of the wiki pages.

bsclifton commented 5 years ago

@cbehan

compiled builds won't check for updates
Updates on Windows or macOS require an official executable (release/beta/dev/nightly channel) and they know an update is present because a request is sent to Brave. Upon receiving the response, Brave will start to update itself... but requires the user to exit/relaunch (green icon shown in hamburger button, restart button also shown in chrome://settings/help) to finalize the process

A lower level description of the process (which could use updating) is on our wiki at: https://github.com/brave/brave-browser/wiki/How-update-works