brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.52k stars 2.27k forks source link

Brave on desktop does not receive multiple tabs sent from another device. #21211

Open kayzzen01 opened 2 years ago

kayzzen01 commented 2 years ago

Description

Brave on desktop does not receive multiple tabs sent from another device.

Steps to Reproduce

  1. Open 2 or more websites
  2. Send to Brave on desktop (Windows/Linux) at least two sites

Actual result:

Open only the notification of the first open sent.

Expected result:

Open all sent tabs in sequence.

Reproduces how often:

Always.

Brave version (brave://version info)

Windows

Brave | 1.35.103 Chromium: 98.0.4758.102 (Official Build) (64-bit) -- | -- Revision | 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151} OS | Windows 10 Version 21H2 (Build 19044.1526) JavaScript | V8 9.8.177.11 User Agent | Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/98.0.4758.102 Safari/537.36

Arch Linux

Brave | 1.35.100 Chromium: 98.0.4758.87 (Official Build) (64-bit) -- | -- Revision | e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002} OS | Linux JavaScript | V8 9.8.177.9 User Agent | Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/98.0.4758.87 Safari/537.36

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

Sending tabs to Brave on Android all notifications are received, and it is possible to open all sent tabs. This seems to be a problem in Brave for desktop.

adrianinsaval commented 2 years ago

This is a regression, it used to work well but it seems the notification system was changed, it's very annoying

adrianinsaval commented 2 years ago

any news? this limits functionality a lot and I don't want to change browsers again. Can't the old style notifications be re-enabled at least for people who have ads disabled?

kayzzen01 commented 2 years ago

Apparently no news. It should be easy to go back to the old notification system. In my preference, Brave could even open the tab directly like Firefox. I use this functionality a lot, now the way is to send them one by one, even so sometimes it doesn't work right.

adrianinsaval commented 2 years ago

This is ridiculous, it's been months and this basic functionality is still broken, brave is becoming less usable instead of improving. I understand you need custom notifications for the adds but using this for the rest is a terrible idea, at the very least they should be queued and shown one after the other instead just vanishing.

I can see that the data is not lost when I go to brave://sync-internals/ -> Sync Node Browser -> Send Tab To Self but the user does not receive notifications

adrianinsaval commented 2 years ago

@rebron can this get higher priority or something? please it's basic broken functionality that every other browser out there does without issues.

AlexeyBarabash commented 1 year ago

I can reproduce it.

lordfeck commented 1 year ago

+1 on this. It is basic sync functionality; please get it fixed soon. I've come to rely upon the ability to send tabs between devices and I'm certainly not the only one. It is frustrating to lose data.

This bug really should be higher than a P4 IMO.

JonasDoesThings commented 10 months ago

This behavior is horrible annoying. Would be great to have fixed

lordfeck commented 10 months ago

@JonasDoesThings they don't appear to care that much, would be great to hear something official that they're working on this or have bumped it above a paltry P4

ShinobiWPS commented 9 months ago

I add my self in your boat,really considering changin browser,i use this feature almost daily

adrianinsaval commented 8 months ago

I moved to firefox over this, it's absurd

ShinobiWPS commented 8 months ago

am i the only getting broken website sometimes? (with Firefox)

adrianinsaval commented 8 months ago

we're going off topic but I got more broken websites with brave than current firefox honestly. It wasn't many anyways and in most cases it's due to adblocking which can be disabled for that one site if it's worth it. That's not to say that firefox isn't buggy though, I've had some weird UI bugs. But on the other hand firefox has many nicer features, first off sync is so much better, I can actually send tabs reliably and access open tabs across devices. Restoring closed windows is an actual possibility instead of having to restore each tab individually. Containers are cool. The home actually has an usable amount of shortcuts instead instead of being absurdly reduced to accommodate for adds. I think Brave had better performance though but it might just be my imagination.

SpamsAlex commented 4 months ago

Hi, still not solved? I just switched from Firefox and it's very useful And could it be done without any notification, but open automatically?

ShinobiWPS commented 4 months ago

it won't likely ever. Is part of the Chromium design, which brave is based on. (i personally "solved" it via Pushbullet

kayzzen01 commented 4 months ago

it won't likely ever. Is part of the Chromium design, which brave is based on. (i personally "solved" it via Pushbullet

@ShinobiWPS, This functionality has worked in the past, so for the reason you explained, the Brave team will not rollback this behavior?

Could you explain what you mean by Pushbullet?

ShinobiWPS commented 4 months ago

it won't likely ever. Is part of the Chromium design, which brave is based on. (i personally "solved" it via Pushbullet

@ShinobiWPS, This functionality has worked in the past, so for the reason you explained, the Brave team will not rollback this behavior?

Could you explain what you mean by Pushbullet?

I know about the past, but they are not planning to bring it back, especially because it was a custom solution, not part of Chromium.

I circumvented the problem by using an extension called Pushbullet

lordfeck commented 3 months ago

FWIW, I mostly use Brave on iOS due to its built in advert blocking. I would've switched to it on desktop were it not for this glaringly ugly problem; thus I still use FF on my desktop.

My workaround is to install Firefox for iOS (it doesn't have an advert blocker :|) but browse with Brave. If I want to send a tab to my desktop Firefox, I just use the system sharing panel within Brave and share it with Firefox, which allows me to select my desktop FF instance as a recipient for the tab.

Yep, ironically enough Firefox happily accepts multiple tabs sent from another browser. Something Brave can't do when sent tabs from itself.

thiswillbeyourgithub commented 3 weeks ago

it won't likely ever. Is part of the Chromium design, which brave is based on. (i personally "solved" it via Pushbullet

@ShinobiWPS, This functionality has worked in the past, so for the reason you explained, the Brave team will not rollback this behavior? Could you explain what you mean by Pushbullet?

I know about the past, but they are not planning to bring it back, especially because it was a custom solution, not part of Chromium.

I circumvented the problem by using an extension called Pushbullet

I am very privacy conscious so creating a pushbullet account is a nogo.

As a daily user of sync on firefox that was so far happy with my revent brave migration I am extremely disappointed to hear that this bug dates back years at this point. It's especially frustrating when I see that the links appear in chrome://sync-internals but are never actually opened / i'm never offered the notification to open it up.

@ShinobiWPS what makes you think they won't bring it back? Had there been communication on the subject? I don't get why this issue would me marked as priority 4 and be not planned.

ShinobiWPS commented 3 weeks ago

@thiswillbeyourgithub I don't have any proof. My reasoning was: