Adjust wording on Monthly Statement when using custodial wallet

LaurenWags commented 2 years ago

Description

When using a custodial wallet (Uphold, Gemini), and auto contribute is performed, on the Monthly Statement the word "wallet" is used. Per https://github.com/brave/brave-browser/issues/19768 we're moving away from use of the word "wallet" so this seems like a candidate for adjustment.

Steps to Reproduce

Install 1.37.x staging env with short retry interval (ex. --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9 --brave-ads-staging --rewards=staging=true,reconcile-interval=5,retry-interval=60 --brave-ads-debug
Enable Rewards, link KYC'd Uphold or Gemini account
Add sites to AC list, wait for AC to complete
Look at Monthly Statement

Actual result:

Uphold example below, but I believe Gemini behaves similarly. N/A for bitFlyer.

Expected result:

Probably just say Uphold or Gemini in parenthesis, no "wallet"

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.37.82 Chromium: 99.0.4844.51 (Official Build) beta (x86_64)
Revision	d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS	macOS Version 12.2.1 (Build 21D62)

Version/Channel Information:

Can you reproduce this issue with the current release? n/a (but yes)
Can you reproduce this issue with the beta channel? yes
Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @Miyayes @zenparsing

Miyayes commented 2 years ago

@zenparsing We can just remove "wallet" in this case and just show {custodian}.

kjozwiak commented 2 years ago

Requires 1.37.91 or higher for QA verification's via 1.37.x.

GeetaSarvadnya commented 2 years ago

Verification PASSED on

Brave | 1.37.91 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
-- | --
Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS | Windows 10 Version 21H2 (Build 19044.1586)

Verified the STR mentioned in the description and ensured custodian name is displayed as Auto-Contribute (Uphold) in the monthly statement

brave / brave-browser