Closed Tonev closed 2 years ago
@nullhook
Does https://github.com/brave/brave-core/pull/12523 resolve this issue?
Particularly the following:
Added tooltip on the new shields icon
Yes, resolves this also: https://github.com/brave/brave-browser/issues/17369
Okay, thank you! You can add this issue as a keyword in your pull request so merging will automatically close it, too, if you like :+1:
Verified Passed
using
Brave | 1.38.74 Chromium: 100.0.4896.60 (Official Build) beta (64-bit) |
---|---|
Revision | 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875} |
OS | Windows 11 Version 21H2 (Build 22000.556) |
brave://flags/#brave-shields-v2
brave://flags/#brave-shields-v1
Relaunch
Brave shields Want access to this site
as expectedBrave Shields
brave://flags/#brave-shields-v1
forv1 Shields
v2 Shields
icon displayedv2 Shields
icon and text displayed as Brave Shields 19 Trackers, ads and more blocked
ex1 | ex2 | ex3 |
---|---|---|
Description
Hovering on the Shields icon doesn't show any text.
Steps to Reproduce
Brave Nightly
.brave://flags/#brave-shields-v2
->
Relaunch
.brave.com
.Actual result:
Expected result:
There should be a text on hover.
Reproduces how often:
100%
Brave version (brave://version info)
Brave | 1.38.32 Chromium: 99.0.4844.51 (Official Build) nightly (64-bit) -- | -- Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875} OS | Windows 7 Service Pack 1 (Build 7601)