brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.86k stars 2.33k forks source link

`Shields v2`: No text/tooltip on hovering on the Shields icon #21581

Closed Tonev closed 2 years ago

Tonev commented 2 years ago

Description

Hovering on the Shields icon doesn't show any text.

Steps to Reproduce

  1. Install Brave Nightly.
  2. Enable brave://flags/#brave-shields-v2 -> Relaunch.
  3. Open a random website, for example brave.com.
  4. Hover on the Shields icon.

Actual result:

brave_8Ai4iFBSNX

Expected result:

There should be a text on hover.

Reproduces how often:

100%

Brave version (brave://version info)

Brave | 1.38.32 Chromium: 99.0.4844.51 (Official Build) nightly (64-bit) -- | -- Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875} OS | Windows 7 Service Pack 1 (Build 7601)
Tonev commented 2 years ago

@nullhook

Does https://github.com/brave/brave-core/pull/12523 resolve this issue?

Particularly the following:

Added tooltip on the new shields icon

nullhook commented 2 years ago

Yes, resolves this also: https://github.com/brave/brave-browser/issues/17369

Tonev commented 2 years ago

Okay, thank you! You can add this issue as a keyword in your pull request so merging will automatically close it, too, if you like :+1:

MadhaviSeelam commented 2 years ago

Verified Passed using

Brave 1.38.74 Chromium: 100.0.4896.60 (Official Build) beta (64-bit)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS Windows 11 Version 21H2 (Build 22000.556)
ex1 ex2 ex3
enabled both v1 and V2 shields v1v2 shields v1v2-2