search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.75k stars 2.32k forks source link

Windows 10 - opening any of the google pages ignores darkmode settings #21769

Open pjozefiak opened 2 years ago

pjozefiak commented 2 years ago

Description

I've noticed that on Windows 10 if I try to open any of the google pages in a new tab, the page will start in light mode, even while I have dark mode enabled in system, browser and google itself. After refreshing page properly goes into the dark mode. Also when the "light" homepage is opened this way, the mode toggle button in the bottom right does not work properly - it opens google account settings instead of switching between dark and light modes.

Steps to Reproduce

  1. Open https://google.com or search something via address bar search while being logged to google account with dark mode enabled in it's settings
  2. If the page open in light mode, refresh the page to get proper dark mode

Actual result:

New google pages open in light mode, after refreshing it switches to dark mode, if you open another one in the new tab - it will start light as well. Same goes if try to search something from the homepage / address bar - the search result will start in light mode.

Expected result:

Google page starts in dark mode and keeps it

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.36.116 Chromium: 99.0.4844.74 (Oficjalna wersja) (64-bitowa) fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060} Windows 10 Version 21H2 (Build 19044.1586)

Version/Channel Information:

Reinstalled the current version from Brave website, issue persist

Other Additional Information:

Issue appears on 2 other Windows 10 machines. It does not appear to be related to specific google account (tested 4 different, all got the bug on Windows 10), nor other browsers (tested Edge, Chrome, Firefox and Safari - no problem) or other OS (tested on latest Brave for Ubuntu and MacOS - no problem)

Tried to troubleshoot it by clearing cache and cookies, reinstalling whole browser from scratch, disabling / removing all extensions - the issue persists.

It does not appear if using incognito mode

rebron commented 2 years ago

cc: @ryanbr

rebron commented 2 years ago

I'm not seeing this on Windows 11 or on macOS 10.14.6. All dark mode via OS setting, browser, and Google look like it's working properly.

ryanbr commented 1 year ago

Windows 10/11 does have a system wide dark via Settings/Personalisation/Colors Changing this may help @pjozefiak Still an issue?

Brave-Matt commented 3 months ago

Seeing more reports of similar behavior here: https://community.brave.com/t/google-switches-back-and-forth-between-dark-light-mode-when-dark-mode-enabled/555397

chylex commented 3 weeks ago

I'm having the same issue, except with Firefox instead of Brave. Couldn't find any other place mentioning this.