brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.75k stars 2.32k forks source link

Continue executing all cosmetic scriptlets even if one fails #21932

Closed antonok-edm closed 2 years ago

antonok-edm commented 2 years ago

https://github.com/brave/adblock-lists/pull/811 was intended to fix the anti-Brave page on https://www.uploadbank.com/yt9ri1rtc0fg, but the scriptlets are not injecting correctly. Each scriptlet needs to be wrapped in a try/catch block to prevent this from happening, like uBlock Origin does.

stephendonner commented 2 years ago

Verified PASSED using

Brave 1.38.75 Chromium: 100.0.4896.60 (Official Build) beta (x86_64)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS macOS Version 11.6.5 (Build 20G527)

Steps:

  1. installed 1.38.75
  2. launched Brave
  3. loaded https://www.uploadbank.com/yt9ri1rtc0fg
  4. clicked through acknowledgement checkboxes and a CAPTCHA
  5. clicked on Download

Confirmed I was served the correct file without any warnings/roadblocks/interstitials

example example example example example
Screen Shot 2022-03-31 at 12 03 58 PM Screen Shot 2022-03-31 at 12 04 13 PM Screen Shot 2022-03-31 at 12 04 16 PM Screen Shot 2022-03-31 at 12 04 20 PM Screen Shot 2022-03-31 at 12 04 24 PM
MadhaviSeelam commented 2 years ago

Verified Passed using

Brave 1.38.80 Chromium: 100.0.4896.79 (Official Build) beta (64-bit)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS Windows 11 Version 21H2 (Build 22000.593)

Steps:

  • Installed 1.38.80
  • launched Brave
  • loaded https://www.uploadbank.com/yt9ri1rtc0fg
  • clicked through acknowledgement checkboxes and a CAPTCHA
  • clicked on Download
ex1 ex2 ex3 ex4 ex5
screenshot1 screenshot2 screenshot3 screenshot4 screenshot5
btlechowski commented 2 years ago

Verification passed on

Brave 1.38.83 Chromium: 100.0.4896.79 (Official Build) beta (64-bit)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS Ubuntu 18.04 LTS
image image image image image
Uni-verse commented 2 years ago

Verification completed using 1.38.103, Chromium 100.0.4896.127 on Samsung Galaxy S21 running Android 12

Test URL: https://www.uploadbank.com/yt9ri1rtc0fg

1 2 3 4 5
Screen Shot 2022-04-20 at 4 50 27 PM Screen Shot 2022-04-20 at 4 51 10 PM Screen Shot 2022-04-20 at 4 51 28 PM Screen Shot 2022-04-20 at 4 52 28 PM Screen Shot 2022-04-20 at 4 49 13 PM
Uni-verse commented 2 years ago

Verification completed using 1.38.103, Chromium 100.0.4896.127 on Samsung Galaxy Tab S7 running Android 12

Test URL: https://www.uploadbank.com/yt9ri1rtc0fg

1 2 3 4
Screen Shot 2022-04-20 at 4 58 17 PM Screen Shot 2022-04-20 at 4 58 35 PM Screen Shot 2022-04-20 at 4 58 49 PM Screen Shot 2022-04-20 at 5 01 43 PM