At least one BG image is not using the defined mobile coordinates for X-Y placement

[bradleyrichter]

iOS is using x=0. Android appears to be ignoring the X coordinate or is incorrectly using x=1280.

Each BG image should have a unique X coordinate defined. (needs reference PR link)

[bradleyrichter]

@petemill By any chance do you know how to locate the PR where these latest BG images were defined with X coordinates?

[petemill]

Background images do not contain focal point definitions. Only sponsored images do.

{
   "schemaVersion":1,
   "images":[
      {
         "name":"ntp-2021-1",
         "source":"alain-frechette_jellyfish-min.webp",
         "author":"Alain Franchette",
         "link":"https://www.pexels.com/photo/three-jellyfishes-2730355/",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      },
      {
         "name":"ntp-2021-2",
         "source":"boris-baldinger_valley-min.webp",
         "author":"Boris Baldinger",
         "link":"https://unsplash.com/photos/6Ogl3xacOlM/",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      },
      {
         "name":"ntp-2021-3",
         "source":"coline-beulin_architecture-min.webp",
         "author":"Coline Beulin",
         "link":"https://unsplash.com/photos/oLWGI-Q76Yc/",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      },
      {
         "name":"ntp-2021-4",
         "source":"corwin-prescott_beach-min.webp",
         "author":"Corwin Prescott",
         "link":"https://community.brave.com/",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      },
      {
         "name":"ntp-2021-5",
         "source":"corwin-prescott_canyon-min.webp",
         "author":"Corwin Prescott",
         "link":"https://community.brave.com/",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      },
      {
         "name":"ntp-2021-6",
         "source":"corwin-prescott_crestone-min.webp",
         "author":"Corwin Prescott",
         "link":"https://community.brave.com/",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      },
      {
         "name":"ntp-2021-7",
         "source":"curt-stump_plant-min.webp",
         "author":"Curt Stump",
         "link":"https://curtstump.com/photography/",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      },
      {
         "name":"ntp-2021-8",
         "source":"david-malenfant_boulders.webp",
         "author":"David Malenfant",
         "link":"https://community.brave.com/",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      },
      {
         "name":"ntp-2021-9",
         "source":"dylan-malval_sea-min.webp",
         "author":"Dylan Malval",
         "link":"https://www.instagram.com/vass_captures/",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      },
      {
         "name":"ntp-2021-10",
         "source":"geran-de-klerk_trees-min.webp",
         "author":"Geran de Klerk",
         "link":"https://unsplash.com/photos/WJkc3xZjSXw/",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      },
      {
         "name":"ntp-2021-11",
         "source":"john-larson_rockwaves-min.webp",
         "author":"John Larson",
         "link":"https://500px.com/p/John_M_Larson?view=photos/",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      },
      {
         "name":"ntp-2021-12",
         "source":"priyanuch-konkaew_street-min.webp",
         "author":"Priyanuch Konkaew",
         "link":"https://unsplash.com/photos/JaR_cKU3J_Y/",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      },
      {
         "name":"ntp-2021-13",
         "source":"spencer-moore_desert-min.webp",
         "author":"Spencer M. Moore",
         "link":"https://www.smoorevisuals.com/landscapes",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      },
      {
         "name":"ntp-2021-14",
         "source":"spencer-moore_fern-min.webp",
         "author":"Spencer M. Moore",
         "link":"https://www.smoorevisuals.com/landscapes",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      },
      {
         "name":"ntp-2021-15",
         "source":"spencer-moore_ocean-min.webp",
         "author":"Spencer M. Moore",
         "link":"https://www.smoorevisuals.com/landscapes",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      }
   ]
}

[alexsafe]

@bradleyrichter @petemill there seems to be x, y coordinates for iOS

https://github.com/brave/brave-ios/blob/development/Client/Frontend/Browser/New%20Tab%20Page/Backgrounds/Assets/ntp-data.json . Should we introduce that too?

[kjozwiak]

This was within the 1.40.x milestone labelled as in progress. However, looks like no progress has been made since ~2022. Moving this back into the new board under needs triage.

[deeppandya]

@bradleyrichter can you please verify this issue if it's still relevant ?

[bsclifton]

Closing as stale - plus we recently updated the logic on Android 😄 We should be in a good place now. Let's open an issue for any specific issues noticed