brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.93k stars 2.35k forks source link

Ellipsize and/or better-wrap long ETLD+1 URLs in the panel #22363

Open stephendonner opened 2 years ago

stephendonner commented 2 years ago

Description

Ellipsize and/or better-wrap long ETLD+1 URLs in the panel

Steps to Reproduce

  1. install 1.39.65
  2. launch Brave
  3. load https://innermajesticgrandyawn.neverssl.com/online
  4. click on the Shields icon

Actual result:

Shields are DOWN for innermajesticgrandyawn.neverssl.c om

example example
Screen Shot 2022-04-17 at 12 42 31 AM Screen Shot 2022-04-17 at 12 43 01 AM

Expected result:

Better wrapping/ellipsizing for ETLD+1

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.65 Chromium: 101.0.4951.34 (Official Build) nightly (x86_64)
Revision 8f93af5d759634c5256b65997dedd138ed60992f-refs/branch-heads/4951@{#710}
OS macOS Version 11.6.5 (Build 20G527)

cc @nullhook @rebron @MadhaviSeelam @GeetaSarvadnya

aguscruiz commented 2 years ago

Hey @stephendonner this is working as expected. On the "Shields UP/DOWN for XXX" we show the full URL without ellipsizing.