brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.53k stars 2.27k forks source link

"Your browser is managed by your organisation" banner blocks access to 3 dots menu on brave://downloads #23128

Open frypf opened 2 years ago

frypf commented 2 years ago

Description

I added group policies to allow some protocol handlers and now, as in the title, the banner stating "Your browser is managed by your organisation" stops me being able to click the "More actions"/3 dots menu on the downloads page (ie.blocking any access to "Clear all" & "Open downloads folder").

Steps to Reproduce

  1. Configure a group policy and start Brave
  2. Open brave://downloads and observe "Your browser is managed by your organisation" banner at top of page
  3. Try to click on the "More actions" menu

Actual result:

Menu is un-clickable (although keyboard access is still possible via multiple presses of Tab and then Spacebar).

Expected result:

Clicking the menu should open the menu.

Reproduces how often:

Every time.

Brave version (brave://version info)

1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64) but has been present for some time - I've only just put 2+2 together as to what the specific cause was.

Other Additional Information:

Doesn't happen on Chrome because their UI is different on the downloads page.

Miscellaneous Information:

I opened DevTools and tried either hiding the banner completely or even just changing its width via CSS. Both of which resolved the problem, but obviously this is pretty inconvenient to repeat every time.

rebron commented 2 years ago

@frypf We need more information here. How did you configure the group policy? Did you apply the same group policy on Chrome? It's the same UI just different styling so I'm surprised you wouldn't have this issue in Chrome as well.

frypf commented 2 years ago

I applied the group policy (URLAllowList) via defaults write in Terminal on MacOS, and yes I applied the same to both Brave and Chrome. With regard to Chrome having different styling rather than UI, yes this is what I meant - just a case of imprecise language on my part. Indeed, it seems Brave's styling changes are the actual culprit for this issue as the "More Actions" menu seems to be overlaid by the "Browser is Managed…" banner, which is not the way it's laid out in Chrome.

Chrome behaviour:

https://user-images.githubusercontent.com/65832791/171362699-337e435d-eeed-4b9d-8cd5-d2b6e09996ef.mov

Brave behaviour:

https://user-images.githubusercontent.com/65832791/171362703-258d26ee-7639-489f-9d1e-fb651a07cfe9.mov

And finally again in Brave, but with a different CSS width specified on the <managed-footnote> element via DevTools, the button is clickable again:

https://user-images.githubusercontent.com/65832791/171364039-07e99ed0-42ce-43c6-8c8b-75fdb1b826c3.mov

frypf commented 1 year ago

Any update on this? I see it's been labeled as P5 but the problem still exists over a year after first reporting. What additional info is required?