GeetaSarvadnya
commented
2 years ago Verification PASSED on
Brave | 1.42.68 Chromium: 103.0.5060.114 (Official Build) beta (64-bit)
-- | --
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | Windows 10 Version 21H2 (Build 19044.1826)
- Verified the test plan from the description https://github.com/brave/brave-browser/issues/23285#issue-1262768322
- Logged https://github.com/brave/brave-browser/issues/24120
- Encountered https://github.com/brave/brave-browser/issues/21797
- Encountered https://github.com/brave/brave-browser/issues/24086#issuecomment-1189367310
- Encountered https://github.com/brave/brave-browser/issues/24118
Testplan
Case 1 : Verify Shield v2 UI and controls - PASSED
- Confirmed that `shield v1` is not present even behind the `brave://flags` - Confirmed shield v1 code is removed from 1.42.x - Confirmed that clicking on shield on any site opens up `shield v2` - Confirmed that `controls on the shield v2` are shown correctly when the shield is UP - Confirmed that clicking on the controls `Filter lists` redirected to the custom filter page - Confirmed that clicking on the `Global defaults` in the shield redirects to the global shield settings page - Confirmed that clicking on the ads and trackers count opens up the panel with blocked scripts/content - Confirmed that `controls on the shield v2` are shown correctly when the shield is DOWN - Confirmed that trackers count is NOT shown on the shield v2 when the shield is DOWN - Confirmed that clicking on the `Learn more` and `Report site` are redirected to the intended pages when the shield is DOWN Example | Example | Example | Example | Example | Example -- | -- | -- | -- | -- | --  |  |  |  |  | Case 2 : Verify Cosmetic filtering-PASSED
Case 1: Clean profile - Ensured custom filter is working as expected - Open any site and click on any object/element on the UI and select the `Block element` context menu and ensure that the element gets blocked on the UI - Remove custom filters and reload the page restores the blocked content on the UI/page. Currently, a browser restart is required to restore the blocked content which is known, encountered #21797 - Select `Manage custom filters` on PT/TOR window is causing the brave crash, encountered https://github.com/brave/brave-browser/issues/24086#issuecomment-1189367310 - Confirmed that element/object can be blocked on the Guest window, but removing custom filter doesn't restore the blocked element on the page, required browser restart but the user will lose the browser session and it's of no use restoring the blocked content, added comments in https://github.com/brave/brave-browser/issues/21797#issuecomment-1189948905 Case 2: Upgrade profile - Install `1.41.88` beta build, open a few websites and block the contents on the webpages and ensured elements are blocked - Go to brave://settings/help and auto upgrade the profile to `1.42.65` - Open brave://settings/shields/filters and ensured blocked elements are still present in the custom filters section - Open webpages and ensured elements/objects are still blocked on the UI - Remove the blocked content from brave://settings/shields/filters - Restart the browser and ensued blocked elements are restored on the webpages **_1.41.88_** | **_1.42.65_** -- | --  | Case 3 : WDP-PASSED
- Verified WDP scenarios and ensured WDP works fine
**`Test Case #1`** - `SE other than Brave`
* launched `1.31.85 Chromium: 95.0.4638.50`
* changed the SE default to `Bing` via `brave://settings/search`
* visited `brave://prefs-internals` and ensured that `"brave_search_visit_count": 0`
* opened https://search.brave.com via new tabs 10 times
* refreshed a single tab that has https://search.brave.com opened ~15 times
* ensured that `"brave_search_visit_count": 0` under `brave://prefs-internals`
**`Test Case #2`** - `Brave as default SE (opening new tabs)`
* launched `1.31.85 Chromium: 95.0.4638.50`
* ensured that `Brave` is the SE via `brave://settings/search`
* opened `https://search.brave.com` in `3` new tabs and ensured that the `WDP` modal appeared without any isssues (3)
* dismissed the modal using the `No Thanks` button
* ensured that `"brave_search_visit_count": 3` via `brave://prefs-internals`
* opened `https://search.brave.com` in `7` new tabs and ensured that the `WDP` modal appeared without any isssues (10)
* ensured that clicking on `Learn More` opens https://brave.com/privacy/browser/#web-discovery-project in a new tab
* ensured that `"brave_search_visit_count": 10` via `brave://prefs-internals`
* dismissed the modal using the `No Thanks` button
* opened `https://search.brave.com` in `10` new tabs and ensured that the `WDP` modal appeared without any isssues (20)
* dismissed the modal using the `X` button
* ensured that `"brave_search_visit_count": 20` via `brave://prefs-internals`
* opened another ~30 tabs with https://search.brave.com and ensured the modal isn't being displayed again
**`Test Case #3`** - `Brave as default SE (Refreshing Tab)`
* launched `1.31.85 Chromium: 95.0.4638.50`
* ensured that `Brave` is the SE via `brave://settings/search`
* opened `https://search.brave.com` in a single tab
* refreshed the same tab `2` times and ensured that the `WDP` modal appeared without any issues (3)
* dismissed the modal using the `No Thanks` button
* refreshed the same tab `7` times and ensured that the `WDP` modal appeared without any issues (10)
* dismissed the modal using the `X` button
* refreshed the same tab `10` times and ensured that the `WDP` modal appeared without any issues (20)
**`Test Case #4`** - `Brave as default SE (Duplicating Tabs)`
* launched `1.31.85 Chromium: 95.0.4638.50`
* ensured that `Brave` is the SE via `brave://settings/search`
* opened `https://search.brave.com` in a single tab
* duplicated the tab `2` times and ensured that the `WDP` modal appeared without any issues (3)
* dismissed the modal using the `X` button
* duplicated the tab `7` times and ensured that the `WDP` modal appeared without any issues (10)
* dismissed the modal using the `No Thanks` button
* duplicated the tab `10` times and ensured that the `WDP` modal appeared without any issues (20)
**`Test Case #5`** - `Enabling WDP`
* launched `1.31.85 Chromium: 95.0.4638.50`
* ensured that `Brave` is the SE via `brave://settings/search`
* went through the above cases and ensured that clicking on `Turn on` correctly enabled `WDP` via `brave://settings/search` on `3`, `10` & `20`
* ensured that once `WDP` is enabled, the modal isn't being displayed again (example, accept on `3` and open `10` & `20` and ensure the modal isn't being displayed)
* ensured that `"brave_search_visit_count"` stays at `3` if `WDP` was enabled on the first modal
* ensured that `"brave_search_visit_count"` stays at `10` if `WDP` was enabled on the second modal
* ensured that `"brave_search_visit_count"` stays at `20` if `WDP` was enabled on the third modal
**`Test Case #6`** - `No Thanks`
* launched `1.31.85 Chromium: 95.0.4638.50`
* ensured that `Brave` is the SE via `brave://settings/search`
* went through the above cases and ensured that selecting `Don't ask again` stops displaying the modal on `10` & `20`
* ensured that dismissing the modal via `X` & `No Thanks` works correctly when `Don't ask again` has been selected
* ensured that `"brave_search_visit_count"` stays at `3` if `Don't ask again` was selected and the modal dismissed
* ensured that `"brave_search_visit_count"` stays at `10` if `Don't ask again` was selected and the modal dismissed
LaurenWags
| 
Example | Example | Example | Example | Example | Example
-- | -- | -- | -- | -- | --
| 
| 
| 
| 
| 
| 
| 
| 
| 
btlechowski
palianskas
tristansly
bsclifton
pes10k
FreeBornAngel
Now that Shields v2 UI (a.k.a. WebUI Bubble Panel) has been released for some time, we can remove the older version.
This will reduce resource usage as there are some background event hooks constantly running as part of the previous version of the UI.
Test Plan