brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.58k stars 2.28k forks source link

Copy edit on Brave Wallet / crypto / accounts: web 3 to web3 #23328

Closed lukemulks closed 2 years ago

lukemulks commented 2 years ago

Description

On brave://wallet/crypto/accounts, within the Primary crypto accounts section copy, we have a space between web and 3 in web 3.

sample of section copy in current form:

_These accounts can be used with web 3 DApps, and can be shown in your portfolio. However, note that secondary accounts cannot be restored via recovery phrase from your primary account backup._

Suggest we update from web 3 to web3, removing the extra space between web and 3.

stylized web3 adopted as common shortform nomenclature in blockchain space, across b2c, p2p and b2b.

Steps to Reproduce

  1. navigate to brave://wallet/crypto/accounts
  2. section: Primary crypto accounts
  3. observe: _These accounts can be used with web 3 DApps..._

Actual result:

web 3

Expected result:

web3

Reproduces how often:

100%

Brave version (info found on brave://version)

1.41.33 Chromium: 102.0.5005.78 (Official Build) nightly (64-bit)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

Heya @jamesmudgett @Douglashdaniel @onyb given this is a single-character string update, grouped you all on this one in case it's able to be attached to any uplifts, etc.

note - I have only checked on desktop so far. that said, iirc Android on core, so would suspect that this likely applies there as well; unclear on iOS, and don't have an iOS device nearby that I can check from (so someone on iOS should spot check)

jamesmudgett commented 2 years ago

Yup, should also be capitalized Web3

srirambv commented 2 years ago
Brave 1.41.86 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
Revision 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS :ballot_box_with_check: Linux :ballot_box_with_check: Windows 11 Version 21H2
(Build 22000.708)
:ballot_box_with_check: macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#13754
  • Verified Web 3 is changed to Web3
  • Verified primary and secondary accounts description is shown correctly
Welcome screen
Import from MetaMask
Import from CryptoWallets
Welcome panel
Default Wallet warning banner
Accounts tab (Secondary Accounts description)
Import Account modal