Add ability for user to edit asset settings from asset view - Githubissues

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.57k stars 2.28k forks source link

Add ability for user to edit asset settings from asset view #23353

Open HEagle18 opened 2 years ago

HEagle18 commented 2 years ago

Description

After adding a custom asset, user doesn't have the ability to edit asset settings after.

Steps to Reproduce

add a new asset to solana chain, like Bonfida
then try edit details from asset view

Actual result:

Expected result:

Reproduces how often:

always

Brave version (brave://version info)

all versions

Version/Channel Information:

Can you reproduce this issue with the current release?
Can you reproduce this issue with the beta channel?
Can you reproduce this issue with the nightly channel?

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? N
Does the issue resolve itself when disabling Brave Rewards? N
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

https://community.brave.com/t/wallet-asset-token-management-ordering-view/399725 issue originated from this ticket

muliswilliam commented 1 year ago

@kleantzogu Please provide some design mock ups. They will be very similar to editing NFTs

josheleonard commented 2 months ago

We have this feature for fungible assets, just need to add the same for NFTs in the details screen