search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.95k stars 2.35k forks source link

Speedreader doesn't work with multiple news websites #23418

Open niutech opened 2 years ago

niutech commented 2 years ago

Description

Speedreader doesn't work with multiple news websites, e.g. Yahoo News, Fox News, Financial Times, The Guardian, ZDnet, Cnet, Onet, etc. Please improve the classifier so that more articles could be shown in the reader view by default.

Example random articles' URLs, one for each news outlet: https://www.theguardian.com/world/2022/jun/12/chinas-taiwan-beijings-defence-minister-rails-against-smearing-and-interfering-us https://www.ft.com/content/1e3ba8df-3fce-4bac-9c8f-d544781c0c22 https://www.foxnews.com/us/idaho-police-arrest-dozens-suspicion-conspiracy-riot-gay-pride-event https://news.yahoo.com/zelensky-says-death-sentences-against-090300777.html https://www.reuters.com/world/china/chinese-defence-minister-says-countrys-nuclear-arsenal-for-self-defence-2022-06-12/ https://www.zdnet.com/education/professional-development/career-regrets-heres-what-workers-wish-theyd-done-differently/ https://www.cnet.com/tech/mobile/what-ios-16-and-android-13-tell-us-about-the-future-smartphones/ https://www.theverge.com/2022/6/11/23162531/drop-dcx-black-on-white-keycaps-hands-on https://www.onet.pl/informacje/onetslask/mafia-weglowa-mafia-weglowa-katastrofy-w-kopalniach-samobojstwo-barbary-blidy/tqjyv31,79cfc278 https://wiadomosci.gazeta.pl/wiadomosci/7,114881,28572268,twierdza-siewierodonieck.html https://wiadomosci.wp.pl/paraliz-w-niemczech-wladze-odradzaja-podrozy-nad-baltyk-6778721426287296a https://wydarzenia.interia.pl/raporty/raport-ukraina-rosja/aktualnosci/news-rosja-po-wybuchu-wojny-z-kraju-wyemigrowaly-setki-tysiecy-os,nId,6088118 https://www.rmf24.pl/fakty/swiat/news-chinski-minister-obrony-ostro-o-tajwanie-bedziemy-walczyc-do,nId,6088090#crp_state=1

Steps to Reproduce

  1. Enable Speedreader
  2. Go to any article on multiple news outlets

Actual result:

I see a full article page.

Expected result:

There should be a stripped-down reader view shown instead.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave v1.39.120

Version/Channel Information:

Stable

boocmp commented 2 years ago

We decide to activate speedreader by matching the url with some regular expressions.It looks like urls in the above list cannot be matched this way because they are too different. I guess we have two options here:

  1. We can provide a list of news sites. In this case we can automatically 'speedread' pages on these sites.
  2. We can determine that the page is probably 'speedreadable' by its content (like Chrome), and show the speedreader icon without enabling feature (so user can enable it for the specified domain manually)
niutech commented 2 years ago

Web browser features shouldn't be limited to some arbitrary whitelisted domains. I am all for the 2nd option, but with the method to auto enable Speedreader for all web pages classified as readable with an opt-out per domain. For many users performance, less data usage and content readability is more important than visual appearance and bloat of web pages. Thanks!