brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.74k stars 2.31k forks source link

Wrong monochrome icon used for Themed App Icon #23478

Closed seventhmoon closed 2 years ago

seventhmoon commented 2 years ago

Description

Android 13 supported Themed App Icons which developers could use a monochrome VectorDrawable as the app icon. However, a Chrome / Chromium icon is shown for Brave. I believe Brave didn't update this new asset and so it shows an Chrome / Chromium icon.

Steps to reproduce

  1. Add Brave shortcut to Desktop
  2. Turn on Themed Icons in Settings
  3. Observe the Icon

Actual result

Chrome / Chromium icon is shown

Expected result

Brave icon is shown

Issue reproduces how often

100%

Version/Channel Information:

Device details

Brave version

1.39.120

seventhmoon commented 2 years ago

The Beta com.brave.browser_beta and Nightly com.brave.browser_nightly have fixed the issue already. Any ETA for the public version?

samartnik commented 2 years ago

Was fixed in the context of https://github.com/brave/brave-browser/issues/22861