Closed stephendonner closed 2 years ago
We can probably do this in one shot; this also affects the tooltip for the banner:
1.41.76
--enable-features=BraveSearchOmniboxBanner
command-line switchSearch engine used in the address bar
to Ecosia
brunch
and confirmed Try Brave Search
Dismiss
Tooltip reads Dismiss brave search conversion
.
@rmcfadden3 Dismiss here will function more like a "Don't show this again"
@rebron & @stephendonner — I'm good with the "Don't show this again" text. It makes sense here, and also saves us on localization.
PASSED
usingBrave | 1.42.21 Chromium: 103.0.5060.53 (Official Build) nightly (x86_64) |
---|---|
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853} |
OS | macOS Version 12.5 (Build 21G5046c) |
Followed my original steps to reproduce, above.
Don't show this again
button | banner |
---|---|
![]() |
![]() |
Description
Tooltip text for Brave Search omnibox promo close widget is too geeky
Steps to Reproduce
1.41.76
--enable-features=BraveSearchOmniboxButton
command-line switchSearch engine used in the address bar
toDuckDuckGo
brunch
X
widgetActual result:
Dismiss brave search conversion
Expected result:
Something like
Close Brave Search promotion
(@rmcfadden3 help wordsmithing?)Reproduces how often:
100%
Brave version (brave://version info)
Version/Channel Information:
No
No
Yes
cc @rmcfadden3 @aguscruiz @jenn-rhim