brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.09k stars 2.23k forks source link

Tooltip text for Brave Search omnibox promo close widget is too geeky #23607

Closed stephendonner closed 2 years ago

stephendonner commented 2 years ago

Description

Tooltip text for Brave Search omnibox promo close widget is too geeky

Steps to Reproduce

  1. installed 1.41.76
  2. launched Brave using --enable-features=BraveSearchOmniboxButton command-line switch
  3. set Search engine used in the address bar to DuckDuckGo
  4. typed brunch
  5. hovered over the X widget
  6. read the tooltip text

Actual result:

Dismiss brave search conversion

Screen Shot 2022-06-22 at 9 32 41 AM

Expected result:

Something like Close Brave Search promotion (@rmcfadden3 help wordsmithing?)

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.41.76 Chromium: 103.0.5060.53 (Official Build) beta (x86_64)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS macOS Version 11.6.7 (Build 20G630)

Version/Channel Information:

cc @rmcfadden3 @aguscruiz @jenn-rhim

stephendonner commented 2 years ago

We can probably do this in one shot; this also affects the tooltip for the banner:

  1. installed 1.41.76
  2. launch Brave using --enable-features=BraveSearchOmniboxBanner command-line switch
  3. set Search engine used in the address bar to Ecosia
  4. typed brunch and confirmed Try Brave Search
  5. hovered over Dismiss
  6. checked the tooltip

Tooltip reads Dismiss brave search conversion.

Screen Shot 2022-06-22 at 9 51 57 AM
rebron commented 2 years ago

@rmcfadden3 Dismiss here will function more like a "Don't show this again"

rmcfadden3 commented 2 years ago

@rebron & @stephendonner — I'm good with the "Don't show this again" text. It makes sense here, and also saves us on localization.

stephendonner commented 2 years ago

Verified PASSED using

Brave 1.42.21 Chromium: 103.0.5060.53 (Official Build) nightly (x86_64)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS macOS Version 12.5 (Build 21G5046c)

Followed my original steps to reproduce, above.

Confirmed the tooltip text now reads Don't show this again

button banner
Screen Shot 2022-06-23 at 12 30 57 PM Screen Shot 2022-06-23 at 12 38 33 PM