brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.54k stars 2.27k forks source link

Desktop push notifications do not always function (twitter, reddit, etc) #2362

Open Brave-Matt opened 5 years ago

Brave-Matt commented 5 years ago

Latest status: see https://github.com/brave/brave-browser/issues/2362#issuecomment-571775236

Description

I've seen DT notifications for various sites (gmail, community, twitter, reddit, etc) work without any issues or conflicts with settings. DT notifications for Youtube however do not work. Alert never actually get displayed in b-c (nor does it play the sound).

This was tested using Dev, Beta and Release builds. Windows 7/Windows 10. Shields up/down and changing global shields have no effect.

Steps to Reproduce

  1. Visit YouTube, sign into YT account
  2. Verify that:

    • Notifications from YT are set to "Allowed", either by prompt on visit or manual entry (see #1775 ) in browser
    • Desktop notifications set to "on" in YT (Click the notification icon (bell) --> Gear icon --> Notification Settings --> Desktop Notifications). Note that it will display the Chrome icon instead of the Brave icon.
    • Notifications are enabled in Windows system settings
    1. Try and provoke a notification from you YT account. I tested this by sending both messages, and commenting on a video I put on my channel from a separate account.
  3. Adjust Shields settings (global and/or panel), and repeat

Actual result:

No notification is displayed on desktop. Notifications do appear on YT.

Expected result:

Desktop notification appears as intended, notifications appear on YT as well.

Reproduces how often:

Easily/always

Brave version (brave://version info)

Release: 0.56.15 Beta: 0.57.8 Dev: 0.58.10

Reproducible on current release:

Yes

Website problems only:

Additional Information

User(s) also reporting this on Community: https://community.brave.com/t/version-0-56-7-chromium-70-0-3538-77-official-build-beta-64-bit-youtube-notifications-or-lack-of/36771/26

bsclifton commented 3 years ago

@jeffjensen yes - it will send a payload to the Google endpoint which will notify you. Folks might not understand (from a privacy perspective) this interaction is being handled by a 3rd party which is why it's disabled by default. If you're OK with that then it's safe to turn on

jeffh-cloudflare commented 3 years ago

I am also experiencing an issue where I am unable to configure notifications for Google Drive. I checked under Site Settings -> Notifications and Google Drive was listed (https://drive.google.com:443) but when I tried to go to Google Drive's settings to enable notifications (Google Drive -> Settings -> Notifications -> Get updates about Google Drive items in your browser), I got the following error message from Google Drive: "Couldn't enable notifications"

This is on a MacBook Pro running macOS Catalina 10.15.7 and Brave Version 1.22.71 Chromium: 89.0.4389.114 (Official Build) (x86_64).

Please let me know if you require any additional information.

reinux commented 3 years ago

Kind of OT, but do common app push notifications on Android go through GCM as well?

Areckleh commented 3 years ago

+1 Community: https://community.brave.com/t/google-drive-notifications-still-not-working/240048/7

danteafk commented 3 years ago

why is this not fixed yet in 2 years + ?

LampPrinter commented 3 years ago

Will this ever be fixed? I am on MacOS and the notifications in Brave don't stay in notification centre. They just pop up for few seconds and go away. Anybody knows of a solution. I have already enabled "Use Google services for push messaging".

conaldev commented 2 years ago

I want to have twitter's notifications in brave. plz fix it

astr0gator commented 1 year ago

Guys, any updates on that? Thanks

LYNK-INCUU commented 1 year ago

Guys, any updates on that? Thanks

i mean just use the google service mentioned here but yeah wish i didnt have to tbh

I believe the blocker for this is https://bugs.chromium.org/p/chromium/issues/detail?id=1011244 which is assigned to an owner that is OOO until Jan 13 Will mark issue as waiting-upstream For folks that aren't aware, there is a Use Google Services for Push Messaging option under brave://settings/privacy (set to OFF by default) which, when enabled, may resolve items which are trying to use GCM

Screen Shot 2020-01-07 at 2 13 12 PM

Thanks @bsclifton - setting Use Google Services for Push Messaging to on made the Google Drive notification setting able to turn on. image

Is Use Google Services for Push Messaging off by default due to security/privacy issues and what are the risks with it on?

astr0gator commented 1 year ago

Guys, any updates on that? Thanks

i mean just use the google service mentioned here but yeah wish i didnt have to tbh

I believe the blocker for this is https://bugs.chromium.org/p/chromium/issues/detail?id=1011244 which is assigned to an owner that is OOO until Jan 13 Will mark issue as waiting-upstream For folks that aren't aware, there is a Use Google Services for Push Messaging option under brave://settings/privacy (set to OFF by default) which, when enabled, may resolve items which are trying to use GCM

Screen Shot 2020-01-07 at 2 13 12 PM

Thanks @bsclifton - setting Use Google Services for Push Messaging to on made the Google Drive notification setting able to turn on. image Is Use Google Services for Push Messaging off by default due to security/privacy issues and what are the risks with it on?

Thank you. I saw that fix and tried it, but the bug persists (have notifications on other chromium-based browsers though).

image
astr0gator commented 1 year ago

Post scriptum. I fixed the issue. For some reason I have two Brave browsers in the notifications (even though only one app).

image

Google services option is switched off and it works like a charm now.

pbennett commented 11 months ago

@jeffjensen yes - it will send a payload to the Google endpoint which will notify you. Folks might not understand (from a privacy perspective) this interaction is being handled by a 3rd party which is why it's disabled by default. If you're OK with that then it's safe to turn on

By definition, wouldn't push notifications always come from a third-party? 😏

RealAlphabet commented 1 month ago

Any news on this problem? Is the chrome.gcm API still disabled? Is Web Push working?