Closed petemill closed 2 years ago
PASSED
usingBrave | 1.43.61 Chromium: 104.0.5112.81 (Official Build) dev (x86_64) |
---|---|
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309} |
OS | macOS Version 11.6.8 (Build 20G730) |
1.43.61
--enable-features=BraveSearchOmniboxBanner
command line switch (with clean profile)Startpage
as the default search engineTry Brave Search button
in the promotion banner from omnibox popupSet Brave Search as a default
is visible in the search result page and clickDismiss
button from omnibox banner after typing any terms in the omniboxhttps://search.brave.com/search?q=test&action=makeDefault
Set Brave Search as a default
is not visiblehttps://search.brave.com/search?q=test&action=makeDefault
Set Brave Search as default
is not visiblestep 3 | step 4 | steps 5-6 | step 7 | step 10 | step 11-12 | step 14 | step 15-16 |
---|---|---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Verification PASSED
using
Brave | 1.43.63 Chromium: 104.0.5112.81 (Official Build) beta (64-bit)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Windows 11 Version 21H2 (Build 22000.795)
1.43.63
--enable-features=BraveSearchOmniboxBanner
command line switch (with clean profile)brave://settings/search
and set Qwant
as the default search enginenf
) and button type autocomplete is visible as a last itemTry Brave Search button
in the promotion banner from omnibox popupSet Brave Search as a default
is visible in the search result page brave://settings/search
Dismiss
button from omnibox banner after typing any terms in the omniboxhttps://search.brave.com/search?q=nf&action=makeDefault
Set Brave Search as a default
is not visiblehttps://search.brave.com/search?q=test&ef=makeDefault
Set Brave Search as default
is not visibleStep 3 | Step 4 | Step5-6 | Step 7 | Step10 | Step 12 | Step 14 | Step 15-17 |
---|---|---|---|---|---|---|---|
Verification passed on
Brave | 1.43.81 Chromium: 104.0.5112.102 (Official Build) (64-bit) |
---|---|
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478} |
OS | Ubuntu 18.04 LTS |
Verification PASSED on Samsung S10+
running Android 12
using the following build(s):
Brave | 1.43.87 Chromium: 105.0.5195.68 (Official Build) (32-bit)
--- | ---
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Android 12; Build/SP1A.210812.016
1.43.87 Chromium: 105.0.5195.68
US
, CA
, DE
, FR
, UK
, AT
, ES
or MX
Settings
-> Search engines
(ensure it's the Standard
tab)https://search.brave.com/search?q=motorsport&action=makeDefault
three times
Set Brave Search as default
modal appears within the search every timehttps://search.brave.com/search?q=motorsport&action=makeDefault
for the fourth time
--enable-features=BraveSearchOmniboxBanner
into Command Line String
via QA Preferences
motorsport
within the omnibox and click on Try Brave search
using the Brave search promoSet Brave Search as default
modal appears within the searchSet Brave search as default
via the modal within the Brave search resultsStandard
tab is set to Brave
as the default SE via Settings
-> Search engines
Brave
via Settings
-> Search engines
https://search.brave.com/search?q=motorsport&action=makeDefault
Set Brave Search as default
modal isn't appearing within the search resultsExample |
Example |
Example |
Example |
Example |
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Verification PASSED on Samsung S8 Ultra Tablet
running Android 12
using the following build(s):
Brave | 1.43.86 Chromium: 105.0.5195.68 (Official Build) (32-bit)
--- | ---
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Android 12; Build/SPSA.220305.013
1.43.87 Chromium: 105.0.5195.68
US
, CA
, DE
, FR
, UK
, AT
, ES
or MX
Settings
-> Search engines
(ensure it's the Standard
tab)https://search.brave.com/search?q=motorsport&action=makeDefault
three times
Set Brave Search as default
modal appears within the search every timehttps://search.brave.com/search?q=motorsport&action=makeDefault
for the fourth time
--enable-features=BraveSearchOmniboxBanner
into Command Line String
via QA Preferences
motorsport
within the omnibox and click on Try Brave search
using the Brave search promoSet Brave Search as default
modal appears within the searchSet Brave search as default
via the modal within the Brave search resultsStandard
tab is set to Brave
as the default SE via Settings
-> Search engines
Brave
via Settings
-> Search engines
https://search.brave.com/search?q=motorsport&action=makeDefault
Set Brave Search as default
modal isn't appearing within the search resultsExample |
Example |
Example |
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Steps to Reproduce
Actual result:
The results page will not be able to create the button for the user to make Brave Search their default search provider, since we only currently allow 3 calls to that API in a 24-hour period.
Expected result:
Any search results page opened as a result of the omnibox promotion should not be restricted to the 24-hour limit. The user has decided to engage with the omnibox promotion and we wish to provide the option to set as default.
Reproduces how often:
Miscellaneous Information:
As far as I know it is not easy for the
BraveSearchDefaultHost
to know which WebContents has made the call (to receive some kind of flag set in WebContentsUserData when the load is initiated by the promotion banner. If this is the case then perhaps we can just use query parameter for now:BraveSearchRenderFrameObserver
looks foraction=makeDefault
in Url, then sets a constructor flag forBraveSearchDefaultJSHandler
if found (e.g.can_always_set_default
) and then that binds toBraveSearchDefaultJSHandler::GetCanSetDefaultSearchProvider
passing an extra paramcan_always_set_default
, which also passes that param tobrave_search_default_
(the browser host).