Brave Search pages opened by omnibox banner should always be able to show "set default" UI

[petemill]

Steps to Reproduce

1. Set a default search provider that is not Brave Search
2. Visit search.brave.com and perform a search
3. Repeat searches on search.brave.com more than 3 times
4. Run with the flag to show any omnibox promotion for Brave Search
5. Begin to type a search query in to the omnibox
6. Click the omnibox suggestion to perform the search with Brave Search

Actual result:

The results page will not be able to create the button for the user to make Brave Search their default search provider, since we only currently allow 3 calls to that API in a 24-hour period.

Expected result:

Any search results page opened as a result of the omnibox promotion should not be restricted to the 24-hour limit. The user has decided to engage with the omnibox promotion and we wish to provide the option to set as default.

Reproduces how often:

Miscellaneous Information:

As far as I know it is not easy for the BraveSearchDefaultHost to know which WebContents has made the call (to receive some kind of flag set in WebContentsUserData when the load is initiated by the promotion banner. If this is the case then perhaps we can just use query parameter for now: BraveSearchRenderFrameObserver looks for action=makeDefault in Url, then sets a constructor flag for BraveSearchDefaultJSHandler if found (e.g. can_always_set_default) and then that binds to BraveSearchDefaultJSHandler::GetCanSetDefaultSearchProvider passing an extra param can_always_set_default, which also passes that param to brave_search_default_ (the browser host).

[stephendonner]

Verified PASSED using

Brave	1.43.61 Chromium: 104.0.5112.81 (Official Build) dev (x86_64)
Revision	5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS	macOS Version 11.6.8 (Build 20G730)

Steps:

1. installed 1.43.61
2. launched browser with --enable-features=BraveSearchOmniboxBanner command line switch (with clean profile)
3. set Startpage as the default search engine
4. typed any keyword and check button type autocomplete is visible as a last item
5. Click Try Brave Search button in the promotion banner from omnibox popup
6. Check Set Brave Search as a default is visible in the search result page and click
7. Check Brave search is set as a default
8. Repeat step 2 to 6 above 4 times
9. Repeat step 2
10. Click Dismiss button from omnibox banner after typing any terms in the omnibox
11. Load https://search.brave.com/search?q=test&action=makeDefault
12. checked Set Brave Search as a default is not visible
13. terminated Brave and launched Brave w/o command line switch
14. set any search engine except brave search as a default search provider
15. loaded https://search.brave.com/search?q=test&action=makeDefault
16. confirmed Set Brave Search as default is not visible

step 3	step 4	steps 5-6	step 7	step 10	step 11-12	step 14	step 15-16

[MadhaviSeelam]

Verification PASSED using

Brave | 1.43.63 Chromium: 104.0.5112.81 (Official Build) beta (64-bit)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Windows 11 Version 21H2 (Build 22000.795)

1. installed 1.43.63
2. launched browser with --enable-features=BraveSearchOmniboxBanner command line switch (with clean profile)
3. open brave://settings/search and set Qwant as the default search engine
4. typed a keyword (nf) and button type autocomplete is visible as a last item
5. clicked Try Brave Search button in the promotion banner from omnibox popup
6. confirmed Set Brave Search as a default is visible in the search result page
7. clicked the button and confirmed Brave search is set as a default in brave://settings/search
8. Repeat step 2 to 6 above 4 more times
9. Repeat step 2
10. Click Dismiss button from omnibox banner after typing any terms in the omnibox
11. Load https://search.brave.com/search?q=nf&action=makeDefault
12. checked Set Brave Search as a default is not visible
13. terminated Brave and launched Brave w/o command line switch
14. set any search engine except brave search as a default search provider
15. loaded https://search.brave.com/search?q=test&ef=makeDefault
16. confirmed Set Brave Search as default is not visible
17. click (x) button and reload the page

Step 3	Step 4	Step5-6	Step 7	Step10	Step 12	Step 14	Step 15-17

---

Verification passed on

Brave	1.43.81 Chromium: 104.0.5112.102 (Official Build) (64-bit)
Revision	8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS	Ubuntu 18.04 LTS

    

[kjozwiak]

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.43.87 Chromium: 105.0.5195.68 (Official Build) (32-bit)
--- | ---
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Android 12; Build/SP1A.210812.016

• install/launch 1.43.87 Chromium: 105.0.5195.68
• ensured that the system language is set to either US, CA, DE, FR, UK, AT, ES or MX
• change the default SE to something else other than Brave via Settings -> Search engines (ensure it's the Standard tab)
• load https://search.brave.com/search?q=motorsport&action=makeDefault three times
  • ensure that the Set Brave Search as default modal appears within the search every time
• load https://search.brave.com/search?q=motorsport&action=makeDefault for the fourth time
  • ensure that the modal DOESN'T load due to the 24hrs restriction mentioned above
• added --enable-features=BraveSearchOmniboxBanner into Command Line String via QA Preferences
• re-launched the browser tapped on the URL bar and ensured that the Brave search promo is displayed via the omnibox
• type in motorsport within the omnibox and click on Try Brave search using the Brave search promo
• ensure that the Set Brave Search as default modal appears within the search
• tap on Set Brave search as default via the modal within the Brave search results
• ensure that the Standard tab is set to Brave as the default SE via Settings -> Search engines
• change the default SE to something else other than Brave via Settings -> Search engines
• type in https://search.brave.com/search?q=motorsport&action=makeDefault
• ensure that the Set Brave Search as default modal isn't appearing within the search results

Example	Example	Example	Example	Example	Example	Example	Example	Example	Example

Verification PASSED on Samsung S8 Ultra Tablet running Android 12 using the following build(s):

Brave | 1.43.86 Chromium: 105.0.5195.68 (Official Build) (32-bit)
--- | ---
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Android 12; Build/SPSA.220305.013

• install/launch 1.43.87 Chromium: 105.0.5195.68
• ensured that the system language is set to either US, CA, DE, FR, UK, AT, ES or MX
• change the default SE to something else other than Brave via Settings -> Search engines (ensure it's the Standard tab)
• load https://search.brave.com/search?q=motorsport&action=makeDefault three times
  • ensure that the Set Brave Search as default modal appears within the search every time
• load https://search.brave.com/search?q=motorsport&action=makeDefault for the fourth time
  • ensure that the modal DOESN'T load due to the 24hrs restriction mentioned above
• added --enable-features=BraveSearchOmniboxBanner into Command Line String via QA Preferences
• re-launched the browser tapped on the URL bar and ensured that the Brave search promo is displayed via the omnibox
• type in motorsport within the omnibox and click on Try Brave search using the Brave search promo
• ensure that the Set Brave Search as default modal appears within the search
• tap on Set Brave search as default via the modal within the Brave search results
• ensure that the Standard tab is set to Brave as the default SE via Settings -> Search engines
• change the default SE to something else other than Brave via Settings -> Search engines
• type in https://search.brave.com/search?q=motorsport&action=makeDefault
• ensure that the Set Brave Search as default modal isn't appearing within the search results

Example	Example	Example	Example	Example	Example	Example	Example