brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.8k stars 2.33k forks source link

`verify_url` should be removed. #23682

Closed szilardszaloki closed 2 years ago

szilardszaloki commented 2 years ago

Description

https://github.com/brave/internal/issues/829

LaurenWags commented 2 years ago

Verified with

Brave | 1.42.68 Chromium: 103.0.5060.114 (Official Build) beta (x86_64)
-- | --
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | macOS Version 12.4 (Build 21F79)

Verified test plan from https://github.com/brave/brave-core/pull/13956#issue-1284647604

Logged https://github.com/brave/brave-browser/issues/24112 for Gemini and bitFlyer not showing rewards verification state changes on brave://rewards-internals Event logs tab.

Uphold - PASSED
Scenario 1 - Verify from brave://rewards - PASSED 1. Clean profile, staging env 2. Enable Rewards 3. Navigate to brave://rewards 4. Select "Unverified" 5. Follow prompts and verify with custodian Confirmed able to verify with Uphold from brave://rewards page: Example | Example | Example -- | -- | -- a | b | c
Scenario 2 - Verify from rewards panel - PASSED 1. Clean profile, staging env 2. Enable Rewards 3. Open panel from BAT logo 4. Select "Unverified" 5. Follow prompts and verify with custodian Confirmed able to verify with Uphold from panel: Example | Example | Example -- | -- | -- b | c | d
Scenario 3 - Verify from brave://rewards after getting naturally disconnected - PASSED 1. Follow steps from scenario 1 2. Navigate to Uphold site and revoke integration for Brave Browser 3. Navigate back to brave://rewards and refresh if necessary to see the "Logged out" status 4. Click on "Logged out" and select "Login to your Uphold account" 5. Confirm able to reauthorize Example | Example | Example | Example -- | -- | -- | -- 3 | 4 | 5a | 5b Repeat steps 1-5, but in step 4 click on "Log in to Uphold to see your balance" blue box Example | Example | Example | Example -- | -- | -- | -- 2a | 3 | 5a | 5b
Scenario 4 - Verify from rewards panel after getting naturally disconnected - PASSED 1. Follow steps from scenario 2 2. Navigate to Uphold site and revoke integration for Brave Browser 3. Open the panel to see the "Logged out" status 4. Click on "Logged out" and select "Login to your Uphold account" 5. Confirm able to reauthorize Example | Example | Example | Example -- | -- | -- | -- a | b | c | d Repeat steps 1-5, but in step 4 click on "Log in to Uphold to see your balance" blue box from panel Example | Example | Example | Example -- | -- | -- | -- a | b | c | d Repeat steps 1-5, but in step 4 click on "Reconnect" button from notification in panel Example | Example | Example | Example -- | -- | -- | -- a | b | c | d
Gemini - PASSED
Scenario 1 - Verify from brave://rewards - PASSED 1. Clean profile, staging env 2. Enable Rewards 3. Navigate to brave://rewards 4. Select "Unverified" 5. Follow prompts and verify with custodian Confirmed able to verify with Gemini from brave://rewards page: Example | Example | Example -- | -- | -- a | b | c
Scenario 2 - Verify from rewards panel - PASSED 1. Clean profile, staging env 2. Enable Rewards 3. Open panel from BAT logo 4. Select "Unverified" 5. Follow prompts and verify with custodian Confirmed able to verify with Gemini from panel: Example | Example -- | -- a | b
Scenario 3 - Verify from brave://rewards after getting naturally disconnected - PASSED 1. Follow steps from scenario 1 2. Navigate to Gemini site and revoke integration for Brave Browser 3. Navigate back to brave://rewards and refresh if necessary to see the "Logged out" status (due to timing with Gemini, may have to wait up to 10 min) 4. Click on "Logged out" and select "Login to your Gemini account" 5. Confirm able to reauthorize Example | Example | Example | Example -- | -- | -- | -- a | b | c | d Repeat steps 1-5, but in step 4 click on "Log in to Gemini to see your balance" blue box Example | Example | Example -- | -- | -- a | b | c
Scenario 4 - Verify from rewards panel after getting naturally disconnected - PASSED 1. Follow steps from scenario 2 2. Navigate to Gemini site and revoke integration for Brave Browser 3. Open the panel to see the "Logged out" status (may have to wait up to 10 min to see this due to timing with Gemini) 4. Click on "Logged out" and select "Login to your Gemini account" 5. Confirm able to reauthorize Example | Example | Example | Example -- | -- | -- | -- a | b | c | d Repeat steps 1-5, but in step 4 click on "Log in to Gemini to see your balance" blue box from panel Example | Example | Example | Example -- | -- | -- | -- a | b | c | d Repeat steps 1-5, but in step 4 click on "Reconnect" button from notification in panel Example | Example | Example -- | -- | -- a | b | c
bitFlyer - PASSED Pre-req: Have region set to Japan
Scenario 1 - Verify from brave://rewards - PASSED 1. Clean profile, staging env 2. Enable Rewards 3. Navigate to brave://rewards 4. Select "Unverified" 5. Follow prompts and verify with custodian Confirmed able to verify with bitFlyer from brave://rewards page: Example | Example | Example -- | -- | -- a | b | c Repeat steps 1-5 but select "Verify Brave Rewards" from brave://rewards onboarding: Example | Example | Example -- | -- | -- a | b | c
Scenario 2 - Verify from rewards panel - PASSED 1. Clean profile, staging env 2. Enable Rewards 3. Open panel from BAT logo 4. Select "Unverified" 5. Follow prompts and verify with custodian Confirmed able to verify with bitFlyer from panel: Example | Example -- | -- a | b Repeat steps 1-5 but select "Verify Brave Rewards" from panel onboarding: Example | Example -- | -- a | b
Scenario 3 - Verify from brave://rewards after getting naturally disconnected - PASSED 1. Follow steps from scenario 1 2. Wait at least 7 minutes, then attempt to tip a bitFlyer verified creator 3. Confirm you see "Logged out" status 4. Click on "Logged out" and select "Login to your bitFlyer account" 5. Confirm able to reauthorize Example | Example | Example | Example -- | -- | -- | -- a | b | c | d Repeat steps 1-5, but in step 4 click on "Log in to bitFlyer to see your balance" blue box Example | Example | Example -- | -- | -- a | b | c
Scenario 4 - Verify from rewards panel after getting naturally disconnected - PASSED 1. Follow steps from scenario 2 2. Wait at least 7 minutes, then attempt to tip a bitFlyer verified creator 3. Confirm you see "Logged out" status 4. Click on "Logged out" and select "Login to your bitFlyer account" 5. Confirm able to reauthorize Example | Example | Example | Example -- | -- | -- | -- a | b | c | d Repeat steps 1-5, but in step 4 click on "Log in to bitFlyer to see your balance" blue box from panel Example | Example | Example | Example -- | -- | -- | -- a | b | c | d Repeat steps 1-5, but in step 4 click on "Reconnect" button from notification in panel Example | Example | Example -- | -- | -- a | b | c
Uni-verse commented 2 years ago

Verification PASSED on Samsung Galaxy S21 using

Brave   1.42.65 Chromium: 103.0.5060.114 (Official Build) beta (64-bit) 
Revision    a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS  Android 12; Build/SP1A.210812.016
Uphold - PASSED
Scenario 1 - Verify from brave://rewards - PASSED 1. Clean profile, staging env 2. Enable Rewards 3. Navigate to brave://rewards 4. Select "Unverified" 5. Follow prompts and verify with custodian Confirmed able to verify with Uphold from brave://rewards page: 1 | 2 | 3 -|-|- ![screenshot-1658869971881](https://user-images.githubusercontent.com/17885425/181115298-54e6997b-05b6-4686-944e-9b1603d75b6b.png) | ![screenshot-1658869795030](https://user-images.githubusercontent.com/17885425/181115955-2f38c76a-ecb3-47cb-9a64-f88ac8562e72.png) | ![screenshot-1658869857486](https://user-images.githubusercontent.com/17885425/181115992-20dababd-2144-435a-bff4-29b1e90fbd08.png)
Scenario 2 - Verify from rewards panel - PASSED 1. Clean profile, staging env 2. Enable Rewards 3. Open panel from BAT logo 4. Select "Unverified" 5. Follow prompts and verify with custodian Confirmed able to verify with Uphold from panel: 1 | 2 | 3 -|-|- ![screenshot-1658869932060](https://user-images.githubusercontent.com/17885425/181116208-2589fe92-b9cf-4a91-ba26-e53dbabcc753.png) | ![screenshot-1658869795030](https://user-images.githubusercontent.com/17885425/181116258-2c966b07-4449-4cf0-8830-72ead7c5a08c.png) | ![screenshot-1658869857486](https://user-images.githubusercontent.com/17885425/181116262-0aaa1c4a-0116-4c98-a8b1-dee6e79308d8.png)
Scenario 3 - Verify from brave://rewards after getting naturally disconnected - PASSED 1. Follow steps from scenario 1 2. Navigate to Uphold site and revoke integration for Brave Browser 3. Navigate back to brave://rewards and refresh if necessary to see the "Logged out" status 4. Click on "Logged out" and select "Login to your Uphold account" 5. Confirm able to reauthorize Repeat steps 1-5, but in step 4 click on "Log in to Uphold to see your balance" blue box 1 | 2 -|- ![screenshot-1658870050353](https://user-images.githubusercontent.com/17885425/181116419-bfe6bd67-153f-493d-96b7-efd224039047.png) | ![screenshot-1658870235439](https://user-images.githubusercontent.com/17885425/181116483-b3c3d401-2fe1-483f-91db-242cb9352ebb.png)
Scenario 4 - Verify from rewards panel after getting naturally disconnected - FAILED 1. Follow steps from scenario 2 2. Navigate to Uphold site and revoke integration for Brave Browser 3. Open the panel to see the "Logged out" status 4. Click on "Logged out" and select "Login to your Uphold account" 5. Confirm able to reauthorize Repeat steps 1-5, but in step 4 click on "Log in to Uphold to see your balance" blue box from panel - FAILED Repeat steps 1-5, but in step 4 click on "Reconnect" button from notification in panel - FAILED 1 | 2 -|- ![screenshot-1658870085931](https://user-images.githubusercontent.com/17885425/181116844-8128e301-a50d-4653-84c2-5bade33b8e7d.png) | ![screenshot-1658870235439](https://user-images.githubusercontent.com/17885425/181116912-46df59d9-c8fa-4865-b500-d35d768d830f.png)
Gemini - PASSED
Scenario 1 - Verify from brave://rewards - PASSED 1. Clean profile, staging env 2. Enable Rewards 3. Navigate to brave://rewards 4. Select "Unverified" 5. Follow prompts and verify with custodian Confirmed able to verify with Gemini from brave://rewards page: 1 | 2 -|- ![screenshot-1658872996761](https://user-images.githubusercontent.com/17885425/181122117-8a96ad0d-c8b0-4b99-b0a3-d6076a0eea4d.png) | ![screenshot-1658873165017](https://user-images.githubusercontent.com/17885425/181122375-a554cda0-0e1c-4790-a2f1-d20bbd1b07cc.png)
Scenario 2 - Verify from rewards panel - PASSED 1. Clean profile, staging env 2. Enable Rewards 3. Open panel from BAT logo 4. Select "Unverified" 5. Follow prompts and verify with custodian Confirmed able to verify with Gemini from panel: 1 | 2 -|- ![screenshot-1658872978206](https://user-images.githubusercontent.com/17885425/181122432-dd22ed8f-607b-4e3b-baf2-ad375f8dff94.png) | ![screenshot-1658873165017](https://user-images.githubusercontent.com/17885425/181122451-334b8065-9737-408d-8db4-b3ad794cc524.png)
Scenario 3 - Verify from brave://rewards after getting naturally disconnected - PASSED 1. Follow steps from scenario 1 2. Navigate to Gemini site and revoke integration for Brave Browser 3. Navigate back to brave://rewards and refresh if necessary to see the "Logged out" status (due to timing with Gemini, may have to wait up to 10 min) 4. Click on "Logged out" and select "Login to your Gemini account" 5. Confirm able to reauthorize Repeat steps 1-5, but in step 4 click on "Log in to Gemini to see your balance" blue box 1 | 2 | 3 -|-|- ![screenshot-1658873450882](https://user-images.githubusercontent.com/17885425/181122615-b62ce562-7a4e-4987-b415-eb6dadef017c.png) | ![screenshot-1658873463766](https://user-images.githubusercontent.com/17885425/181122636-3d7b24da-81a6-49f9-9711-a2372324d345.png) | ![screenshot-1658873759096](https://user-images.githubusercontent.com/17885425/181122983-54335fb1-37a6-4a51-9764-dea505ef0ce6.png)
Scenario 4 - Verify from rewards panel after getting naturally disconnected - FAILED 1. Follow steps from scenario 2 2. Navigate to Gemini site and revoke integration for Brave Browser 3. Open the panel to see the "Logged out" status (may have to wait up to 10 min to see this due to timing with Gemini) 4. Click on "Logged out" and select "Login to your Gemini account" 5. Confirm able to reauthorize Repeat steps 1-5, but in step 4 click on "Log in to Gemini to see your balance" blue box from panel - FAILED Repeat steps 1-5, but in step 4 click on "Reconnect" button from notification in panel - FAILED 1 | 2 -|- ![screenshot-1658873475588](https://user-images.githubusercontent.com/17885425/181122730-9d507962-16b7-4961-8ce2-f12452244a88.png) | ![screenshot-1658873463766](https://user-images.githubusercontent.com/17885425/181122756-cb0efd48-41e6-4836-9084-4617ec9d04a4.png)
bitFlyer - PASSED Pre-req: Have region set to Japan
Scenario 1 - Verify from brave://rewards - PASSED 1. Clean profile, staging env 2. Enable Rewards 3. Navigate to brave://rewards 4. Select "Unverified" 5. Follow prompts and verify with custodian PASS - Confirmed able to verify with bitFlyer from brave://rewards page: PASS - Repeat steps 1-5 but select "Verify Brave Rewards" from brave://rewards onboarding: 1 | 2 -|- ![screenshot-1658949396563](https://user-images.githubusercontent.com/17885425/181373921-8dc3505c-6e84-4851-8754-37b5c0589c34.png) | ![screenshot-1658949420492](https://user-images.githubusercontent.com/17885425/181373963-bb30cd26-097a-424e-8bbb-90a51b359992.png)
Scenario 2 - Verify from rewards panel - PASSED 1. Clean profile, staging env 2. Enable Rewards 3. Open panel from BAT logo 4. Select "Unverified" 5. Follow prompts and verify with custodian PASS - Confirmed able to verify with bitFlyer from panel: PASS - Repeat steps 1-5 but select "Verify Brave Rewards" from panel onboarding: 1 | 2 -|- ![screenshot-1658949384658](https://user-images.githubusercontent.com/17885425/181374150-9638c1b8-1364-489c-a248-b541324fd7d9.png) | ![screenshot-1658949420492](https://user-images.githubusercontent.com/17885425/181374175-53fe9d00-fc03-4294-b755-d2dd0d87f2de.png)
Scenario 3 - Verify from brave://rewards after getting naturally disconnected - PASSED 1. Follow steps from scenario 1 2. Wait at least 7 minutes, then attempt to tip a bitFlyer verified creator 3. Confirm you see "Logged out" status 4. Click on "Logged out" and select "Login to your bitFlyer account" 5. Confirm able to reauthorize PASSED - Repeat steps 1-5, but in step 4 click on "Log in to bitFlyer to see your balance" blue box 1 | 2 | 3 -|-|- ![screenshot-1658949867291](https://user-images.githubusercontent.com/17885425/181374441-e15c6d4c-7a5d-4b98-a152-3f648145c288.png) | ![screenshot-1658949971987](https://user-images.githubusercontent.com/17885425/181374480-b19665f0-3ca9-4aad-b5a2-9b0bb2c705f9.png) | ![screenshot-1658949396563](https://user-images.githubusercontent.com/17885425/181374577-3bb866bd-1350-4503-8630-1854fe3b87eb.png)
Scenario 4 - Verify from rewards panel after getting naturally disconnected - PASSED 1. Follow steps from scenario 2 2. Wait at least 7 minutes, then attempt to tip a bitFlyer verified creator 3. Confirm you see "Logged out" status 4. Click on "Logged out" and select "Login to your bitFlyer account" 5. Confirm able to reauthorize FAILED - Repeat steps 1-5, but in step 4 click on "Log in to bitFlyer to see your balance" blue box from panel FAILED - Repeat steps 1-5, but in step 4 click on "Reconnect" button from notification in panel 1 | 2 -|- ![screenshot-1658949853806](https://user-images.githubusercontent.com/17885425/181374777-c8348a31-a4f4-4379-b141-c7cfb33cb063.png) | ![screenshot-1658956970832](https://user-images.githubusercontent.com/17885425/181374882-be1e14a4-4ff0-4547-953f-218ecc0f882a.png)
Uni-verse commented 2 years ago

Verification PASSED on Samsung Tab S7 using

Brave   1.42.80 Chromium: 104.0.5112.57 (Official Build) (64-bit) 
Revision    212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS  Android 12; Build/SP1A.210812.016
GeetaSarvadnya commented 2 years ago

Verification PASSED on


Brave | 1.42.82 Chromium: 104.0.5112.69 (Official Build) (64-bit)
-- | --
Revision | 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS | Windows 10 Version 21H2 (Build 19044.1826)
Uphold - PASSED
Scenario 1 - Verify from brave://rewards - PASSED 1. Clean profile, staging env 2. Enable Rewards 3. Navigate to brave://rewards 4. Select "Unverified" 5. Follow prompts and verify with custodian Confirmed able to verify with Uphold from brave://rewards page: 1 | 2 | 3 -|-|- ![image](https://user-images.githubusercontent.com/38657976/181799274-f1a18c32-4a49-41d0-be5d-d2f80dc5444a.png) | ![image](https://user-images.githubusercontent.com/38657976/181799894-9354829a-4fcf-4788-a7b0-80b4e4912edf.png) | ![image](https://user-images.githubusercontent.com/38657976/181800335-57ca892f-a642-4a0a-b362-00fe0c39781c.png)
Scenario 2 - Verify from rewards panel - PASSED 1. Clean profile, staging env 2. Enable Rewards 3. Open panel from BAT logo 4. Select "Unverified" 5. Follow prompts and verify with custodian Confirmed able to verify with Uphold from panel: 1 | 2 | 3 -|-|- ![image](https://user-images.githubusercontent.com/38657976/181801522-d7bba0ab-4b8a-4054-9789-18d5315e641d.png) | ![image](https://user-images.githubusercontent.com/38657976/181801836-f090c6f9-3e18-42f1-8d97-d03f095c3d80.png) | ![image](https://user-images.githubusercontent.com/38657976/181801902-a9a9e697-5f35-43fe-a183-bbdb1418edde.png)
Scenario 3 - Verify from brave://rewards after getting naturally disconnected - PASSED 1. Follow steps from scenario 1 2. Navigate to Uphold site and revoke integration for Brave Browser 3. Navigate back to brave://rewards and refresh if necessary to see the "Logged out" status 4. Click on "Logged out" and select "Login to your Uphold account" 5. Confirm able to reauthorize Repeat steps 1-5, but in step 4 click on "Log in to Uphold to see your balance" blue box Example | Example | Example | Example ----------|-----------|----------|--------- ![image](https://user-images.githubusercontent.com/38657976/181809034-1dd89c82-bc6d-4a01-a573-150faab712bc.png) | ![image](https://user-images.githubusercontent.com/38657976/181809068-88f09f8c-f95a-4744-a30c-49a91330792e.png) | ![image](https://user-images.githubusercontent.com/38657976/181809336-25d884eb-5aaa-4848-b9dc-1e7156758977.png) | ![image](https://user-images.githubusercontent.com/38657976/181809476-2ba02fcf-dee1-4a1b-87f5-4e3129a3a6c0.png)
Scenario 4 - Verify from rewards panel after getting naturally disconnected - 1. Follow steps from scenario 2 2. Navigate to Uphold site and revoke integration for Brave Browser 3. Open the panel to see the "Logged out" status 4. Click on "Logged out" and select "Login to your Uphold account" 5. Confirm able to reauthorize Repeat steps 1-5, but in step 4 click on "Log in to Uphold to see your balance" blue box from panel - FAILED Repeat steps 1-5, but in step 4 click on "Reconnect" button from notification in panel - FAILED Example | Example | Example | Example ----------|-----------|----------|--------- ![image](https://user-images.githubusercontent.com/38657976/181809895-5ae143ab-3444-41d3-a096-1d3673fdbecc.png) | ![image](https://user-images.githubusercontent.com/38657976/181809960-db7b0816-48f0-4c11-b994-e2447f91832f.png) | ![image](https://user-images.githubusercontent.com/38657976/181810066-38aacaf9-6c63-4b0b-b834-a04756189a7a.png) | ![image](https://user-images.githubusercontent.com/38657976/181810126-9f17e89c-e2f8-41ba-9d0a-34dedfc30cbd.png)