brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.52k stars 2.27k forks source link

Upgrade from Chromium 104 to Chromium 105. #23800

Closed mkarolin closed 2 years ago

mkarolin commented 2 years ago

Upgrade from Chromium 104 to Chromium 105.

https://chromium.googlesource.com/chromium/src/+log/104.0.5112.81..105.0.5195.10/?pretty=fuller&n=10000

QA tests: This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

iOS

Android Affected areas:

stephendonner commented 2 years ago

Verification PASSED for my portion, below using

Brave 1.44.64 Chromium: 105.0.5195.37 (Official Build) nightly (64-bit)
Revision 5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS Windows 10 Version 21H2 (Build 19044.1889)
Settings UI: search engines show correctly - PASSED * Defaults {en-US} * Defaults {other locales} * Search engine list same as `release` * Change and verify reflects in normal/private windows ### en-US `Defaults` `1.44.64` | `release` (`Brave`) -----------|---------- ![search-engine-defaults](https://user-images.githubusercontent.com/387249/186342025-ab06c3e7-bd45-4f59-96e3-875b047553c7.png) | ![release](https://user-images.githubusercontent.com/387249/186343023-c3276e3e-f513-4405-9260-457119a12edf.png) `brave://settings/searchEngines` `1.44.64` | `release` (`Brave`) ----------|--------- ![image](https://user-images.githubusercontent.com/387249/186343229-d2e40071-c29e-4c76-98f9-617eb4f7cf4d.png) | ![searchEngines-1-42-97](https://user-images.githubusercontent.com/387249/186343781-32faef2b-7c19-42fc-88c5-afa6cb0b568b.png) ### Other locales (`Google`) India | Ireland | Poland ------|---------|--------- ![োো](https://user-images.githubusercontent.com/387249/186357586-a499a758-45e0-4165-8091-de9b30e991ff.png) | ![Ireland](https://user-images.githubusercontent.com/387249/186357031-64652e4f-a8ff-4398-bac2-d818af8a9ab8.png) | ![Polish](https://user-images.githubusercontent.com/387249/186357036-9f0a7bd0-4162-4e64-9cfe-d8002b335981.png)
Wallet importer * Seed `release` (using test faucet?) and verify import works (?)
Color scheme (omnibox, sidebar, private/Tor windows) - PASSED * Omnibox * Sidebar * Private window * Private window w/Tor * Guest window omnibox | sidebar ----------|--------- ![omnibox](https://user-images.githubusercontent.com/387249/186366618-70686423-b848-4aff-b27f-8f1f690b5ab0.png) | ![bookmarks-sidebar](https://user-images.githubusercontent.com/387249/186369778-72d0e181-aa57-4b82-810f-2fa70a49ae9e.png) `Private window` | `Private window w/Tor` | `Guest window` -------------------|--------------------------|------------------ ![private-window](https://user-images.githubusercontent.com/387249/186353735-8a7b3438-f963-458c-bb6b-e64723ffb6ec.png) | ![brave-tor-success](https://user-images.githubusercontent.com/387249/186353805-1f1db871-ac9c-43f7-9c56-66ef4606ce4b.png) | ![guest-window](https://user-images.githubusercontent.com/387249/186354751-e39fe1f3-f076-498f-92e4-17b4b67f113d.png)
Brave News (overall looks correctly - related to JSON-parsing changes) - PASSED example | example | example | example ----------|-----------|-----------|---------- ![brave-news-disclaimer](https://user-images.githubusercontent.com/387249/186362316-57a3a56e-b336-4e80-b00b-94ec9b51c1f2.png) | ![brave-news-ad](https://user-images.githubusercontent.com/387249/186362541-ffc4e2e1-3c15-4125-8d83-a405b3a1c2ee.png) | ![brave-news-custom-feed-add](https://user-images.githubusercontent.com/387249/186362546-91eb835a-82be-40b3-b5c1-f1b6c858c15c.png) | ![brave-news](https://user-images.githubusercontent.com/387249/186362918-5e6b9b34-03e0-4c25-93f0-3d62e5091854.png)
Brave Wallet (overall looks and operates correctly - related to JSON-parsing changes)
Brave VPN (overall looks correctly - related to JSON-parsing changes) - PASSED example | example | example | example | example ----------|-----------|----------|-----------|---------- ![VPN-1](https://user-images.githubusercontent.com/387249/186470682-55823b0c-56b8-4f40-aa46-7067d787cc82.png) | ![VPN-2](https://user-images.githubusercontent.com/387249/186470689-c018621b-992b-4268-ba85-dfbd7d866573.png) | ![VPN-3](https://user-images.githubusercontent.com/387249/186470708-8bb40f48-d8a3-4f6c-897f-36b20e83a81f.png) | ![VPN-4](https://user-images.githubusercontent.com/387249/186470731-1735463c-45d1-4219-b376-6d405d7caff1.png) | ![VPN-5png](https://user-images.githubusercontent.com/387249/186470743-49fff2c0-40ec-42f3-9b5a-f083e4d741df.png)
GeetaSarvadnya commented 2 years ago

Verification PASSED on

Brave | 1.44.64 Chromium: 105.0.5195.37 (Official Build) nightly (64-bit)
-- | --
Revision | 5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS | Windows 10 Version 21H2 (Build 19044.1889)
Settings UI: privacy page looks correctly_PASSED - Encountered the icons missing or expand arrow or other icons (e.g seach etc) are missing in almost all the pages in each settings, posted the screenshots in https://github.com/brave/brave-browser/issues/24872#issuecomment-1225166137 - Verified the each settings in privacy page and ensured each settings works as expected - Verified that the new section `Tor windows` is been added in brave://settings/privacy page - Verified that the settings `Private window with Tor` and `Automatically redirect .onion sites` works as expected
Bookmarks, History, Extensions pages style looks correctly_PASSED
Bookmarks_PASSED - Logged https://github.com/brave/brave-browser/issues/24944 - Verified bookmarks cab be imported via NTP, brave://settings/importData, import bookmarks option via Hamburger menu and boomarks manager page - Verified that bookmarks folder shape/style is as per the brave specifications - Verified bookmarks can be imported from various browser (chrome, FF, Edge and Opera) - Verified boomarks can be added/edited/deleted - Verified bookamrks can be opened by clicking on the bookmarked pages - Verified passwords, history, autofill settings and history details are imported successfully ![image](https://user-images.githubusercontent.com/38657976/186467131-df252fa6-6594-49df-8bc0-3b3ff85c53f7.png)
Extensions_PASSED - Verified that `Private window with Tor` and `Automatically redirect .onion sites` settings are moved from brave://settings/extensions page - Verified that brave://settings/extensions page style and content looks as expected - Verified that click on each settings in extension page redirected to intended pages - Verified that click on `Manage extensions` redirects to brave://extensions/ where installed extensions are listed - Click on `Details` on the installed extension and enabled `Allow in private` switch and ensured that the extesion is shown in PT and TOR windows Example | Example -- | -- ![image](https://user-images.githubusercontent.com/38657976/186469609-bd48fb06-3ade-4869-92fb-033fd86e6c6d.png) | ![image](https://user-images.githubusercontent.com/38657976/186469401-cc853494-096e-420b-bf7d-6ee66fe1b0a3.png)
History_PASSED - Verified that after viewing the couple of websites browser history is collected in brave://history - Verified that browser history can be imported from other browser - Verified browser history, cookies, passwords can be removed
Brave features' text labels look correctly when running the browser in a different language_PASSED - Ensured text and labels look correctly in other locales (verified in `Kannada` my mother tongue :) ) Example | Example | Example | Example | Example -- | -- | -- | -- | -- ![image](https://user-images.githubusercontent.com/38657976/186473140-19e30484-73b8-47c5-95ad-a0b377b5e4f8.png) | ![image](https://user-images.githubusercontent.com/38657976/186473197-05507359-6fd5-4d14-a504-561a28995025.png) | ![image](https://user-images.githubusercontent.com/38657976/186473293-0c88ffdc-bc0d-4b25-8482-03dcf50ed80c.png) | ![image](https://user-images.githubusercontent.com/38657976/186473388-be7a8748-0ab8-4eb9-8cc7-8dacb4dbc3e5.png) | ![image](https://user-images.githubusercontent.com/38657976/186473436-254b58e8-edd7-4a66-87a4-ad54cceefc6c.png)
Upgrade in different channels works correctly_PASSED - Ensured that upgrade from CR104 to CR105 looks good
App menu, page context menu, side bar context menu look correctly_PASSED
App menu_PASSED - Icons are missing the Guest window brave://settings/help page enountered the issue https://github.com/brave/brave-browser/issues/24872 - Verified that `App menu` settings are working as expected - Verified that click on `App menu` settings redirected to intended pages in normal window - Verified that click on `App menu` settings redirected to intended pages in private window - Verified that click on `App menu` settings redirected to intended pages in tor window - Verified that click on `App menu` settings redirected to intended pages in guest window Example | Example | Example | Example -- | -- | -- | -- ![image](https://user-images.githubusercontent.com/38657976/186482666-f4495e11-b183-4a2e-98b0-00f30b04c618.png) | ![image](https://user-images.githubusercontent.com/38657976/186483914-8cae0c5d-50f8-4f33-a1d6-a55ac4e124f4.png) | ![image](https://user-images.githubusercontent.com/38657976/186484203-b966aa52-fed2-4ea7-8677-d7c3c33663af.png) | ![image](https://user-images.githubusercontent.com/38657976/186484453-0aa6e90f-8fbb-4569-a5b2-60fdcc7a2cca.png)
Page context menu_PASSED - encountered and logged https://github.com/brave/brave-browser/issues/24953 - Verified context menu items are shown correctly when right click on any link in a webpage - Verified context menu items are shown correctly when right click on any image in a webpage - Verified that click on each context menu items redirected to the intended pages Example | Example -- | -- ![image](https://user-images.githubusercontent.com/38657976/186485592-7807e375-78cb-4330-8f80-48d429b78c0f.png) | ![image](https://user-images.githubusercontent.com/38657976/186485731-162713ae-cf7d-47bd-8449-10091e83677c.png)
Sidebar context menu_PASSED - Confirmed that sidebar is shown by default in the nightly channel - Confirmed that `Reading list` icon is added to the sidebar menu - Confirmed that reading list panel is shown when user click on the `Reading list` icon in the sidebar menu - Confirmed that user can add the `list of websites` to the reading list by clicking on the `+Add current tab` - Confirmed that `reading list panel can be hidden` by clicking on the `Reading list` icon in the sidebar menu - Confirmed that reading list icon is shown in the URL bar, next to wallet icon - Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar) - Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window) - Websites can't be added to reading list in Guest, logged https://github.com/brave/brave-browser/issues/24930 - Confirmed that sites can be segregated to `Read` and `Unread` list - Confirmed that sites can be deleted from the reading list Example | Example | Example | Example | Example -- | -- | -- | -- | -- ![image](https://user-images.githubusercontent.com/38657976/186580009-25c6a83a-cfa4-4cb7-81b4-c9252f52a314.png) | ![image](https://user-images.githubusercontent.com/38657976/186580072-865d8023-4dd8-4d2c-bca4-d99f88757227.png) | ![image](https://user-images.githubusercontent.com/38657976/186580113-d9c77f1f-b089-4984-9531-1c26718e1615.png) | ![image](https://user-images.githubusercontent.com/38657976/186580154-ba1ab6f3-977f-4494-aaa4-fcedb8bf6593.png) | ![image](https://user-images.githubusercontent.com/38657976/186580339-5ff34aaa-6257-4bfc-aaa5-f2b0beda1f13.png)

Settings comparison

- Verified that the `Language` settings are updated as part of CR 105 ![image](https://user-images.githubusercontent.com/38657976/186383778-e01f551e-d859-48c4-89ed-25f06bc9fdca.png) - Verified that the new settings `Tab hover mode` and `side panel` are added in `brave://settings/appearance` as part of brave ![image](https://user-images.githubusercontent.com/38657976/186358747-abc5d647-84af-4c12-8828-64d6a27ad919.png) - Verified that `Solid colors` settings is been added in `Dashboard Settings` in NTP ![image](https://user-images.githubusercontent.com/38657976/186363673-9e017067-fade-4454-95f3-da1ae6e24def.png) - Verified that the settings `Private window with Tor` and `Automatically redirect .onion sites` are moved to new section `Tor windows` and which is present inside the brave://settings/privacy settings section - Ensured that the settings `Private window with Tor` and `Automatically redirect .onion sites` works as expected ![image](https://user-images.githubusercontent.com/38657976/186381982-e51cdd6e-0e44-4c97-9680-f657d2d7fc63.png) - Verified `Use Bridges` new settings in been added in the new section `Tor windows`

Components updater

- No new components are added as part of CR 105 - Components are updates successfully without any error - New component `Brave Ads Resources (en)` is been added as part of brave ![image](https://user-images.githubusercontent.com/38657976/186344602-196688b5-78e2-4741-8d0f-d082a63e9b16.png) **`1.44.64 Chromium: 105.0.5195.37`** | **`1.42.97 Chromium: 104.0.5112.102`** -- | -- ![image](https://user-images.githubusercontent.com/38657976/186343973-3b449f4d-aeac-4c0d-bf4f-e93640bf249e.png) | ![image](https://user-images.githubusercontent.com/38657976/186344297-d10c7d24-4204-4591-9e3a-1640e4a30613.png)

Brave startup calls

srirambv commented 2 years ago

Verification passed on

Brave 1.45.2 Chromium: 105.0.5195.37 (Official Build) nightly (64-bit)
Revision 5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS Linux

Wallet importer

Brave wallet (overall looks and operates correctly - related to JSON parsing changes)

Uni-verse commented 2 years ago

Verified on Samsung Galaxy S21 & Samsung G-Tab S7 running Android 12 using build version:

Brave   1.45.1 Chromium: 105.0.5195.37 (Official Build) canary (64-bit) 
Revision    5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS  Android 12; Build/SP1A.210812.016

Spot checked the following areas:

Example Example
screenshot-1661445950499 screenshot-1661446264695
kjozwiak commented 2 years ago

Labelling as QA/No & release-notes/exclude in favour of https://github.com/brave/brave-browser/issues/24948. As per https://github.com/brave/brave-browser/issues/24948#issuecomment-1227907151, Linux still needs to run through the affected areas.