Speedreader toggle doesn't work for certain pages

urbenlegend commented 2 years ago

Description

Toggling speedreader has no effect on certain pages. Clicking on the speedreader icon just makes the normal page refresh. Here are a few examples where this is happening to me:

What's curious is that other articles on arstechnica work. It's just certain articles that do not.

Steps to Reproduce

Visit one of the pages linked above
Toggle speedreader
Notice that the page simply refreshes instead of going into speedreader mode

Actual result:

Page does not go into speedreader mode.

Expected result:

Page correctly goes into speedreader mode when enabled.

Reproduces how often:

Every time

Brave version (brave://version info)

Brave	1.40.107 Chromium: 103.0.5060.53 (Official Build) (64-bit)
Revision	a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS	Linux

Version/Channel Information:

Can you reproduce this issue with the current release? Yes
Can you reproduce this issue with the beta channel? Not tested
Can you reproduce this issue with the nightly channel? Not tested

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? No
Does the issue resolve itself when disabling Brave Rewards? No
Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

sangwoo108 commented 2 years ago

From my scan, our extractor fails to extract body of the first article. I think it'd be better to have it's parent or grand parent node as target node, but scores were not that.

// logs from extractor.rs - `pub fn extract_dom<S: ::std::hash::BuildHasher>`
length: 157
content:  Some Macs are getting fewer updates than they used to. Here’s why it’s a problemDropping old Macs can be justified, but some are dying before they should be.

GeetaSarvadnya commented 2 years ago

Reproduced on windows 10 x64 - 1.43.43


Brave | 1.43.43 Chromium: 104.0.5112.57 (Official Build) nightly (64-bit)
-- | --
Revision | 212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS | Windows 10 Version 21H2 (Build 19044.1826)

brave / brave-browser