brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.09k stars 2.23k forks source link

Add NTP search promo P3A question #24065

Closed DJAndries closed 2 years ago

DJAndries commented 2 years ago

Description

Adding P3A question for the new tab page search promo (promo added in #23724):

Did the participant in Group C click on the promo and did they switch their default engine to Brave Search? Brave.Search.Promo.NewTabPage

0) No, No 1) Yes, No 2) No, Yes 3) Yes, Yes

Will raise PR soon.

GeetaSarvadnya commented 1 year ago

Verification PASSED on

Brave | 1.44.73 Chromium: 105.0.5195.68 (Official Build) beta (64-bit)
-- | --
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Windows 10 Version 21H2 (Build 19044.1889)

India Region

Brave.Search.Promo.NewTabPage

Case 1: Brave.Search.Promo.NewTabPage = 0_PASSED **0 No, No** - "Did the participant in Group C click on the promo - No" and "did they switch their default engine to Brave Search? - No" 1. Clean profile 1.44.x 2. Launch the browser using the cmd line flag `brave.exe --enable-features="BraveSearchNTP"` 3. Open brave://local-state file and ensure the metrics `Brave.Search.Promo.NewTabPage` is not shown 4. Open a NTP and ensured NTP search promo appears 5. Open brave://local-state file and ensured that the metrics `Brave.Search.Promo.NewTabPage` response value is `0` as expected ![image](https://user-images.githubusercontent.com/38657976/188619436-7d61f390-ea9f-4a9f-a0ab-b5b4b32ea5f8.png)
Case 2: Brave.Search.Promo.NewTabPage = 1_PASSED **1 Yes, No** - "Did the participant in Group C click on the promo - Yes" and "did they switch their default engine to Brave Search? - No" 1. Clean profile 1.44.x 2. Launch the browser using the cmd line flag `brave.exe --enable-features="BraveSearchNTP"` 3. Open brave://local-state file and ensure the metrics `Brave.Search.Promo.NewTabPage` is not shown 4. Open a NTP and ensured NTP search promo appears 5. Make search query via NTP promo 6. Open brave://local-state file and ensured that the metrics `Brave.Search.Promo.NewTabPage` response value is `1` as expected ![image](https://user-images.githubusercontent.com/38657976/188688901-347b3a51-e685-474b-8cc9-189b1a4ab8cd.png)
Case 3: Brave.Search.Promo.NewTabPage = 2_PASSED **2 No, Yes** - "Did the participant in Group C click on the promo - No" and "did they switch their default engine to Brave Search? - Yes" 1. Clean profile 1.44.x 2. Launch the browser using the cmd line flag `brave.exe --enable-features="BraveSearchNTP"` 3. Open brave://local-state file and ensure the metrics `Brave.Search.Promo.NewTabPage` is not shown 4. Open a NTP and ensured NTP search promo appears 5. Change the default search engine to Brave via brave://settings/search 6. Open brave://local-state file and ensured that the metrics `Brave.Search.Promo.NewTabPage` response value is `2` as expected Example | Example -- | -- ![image](https://user-images.githubusercontent.com/38657976/188807060-154fd071-5d8a-4e97-b3c8-a595b78114bf.png) | ![image](https://user-images.githubusercontent.com/38657976/188807134-75e2e4b1-1cd9-4281-9c83-fae5d3a4290a.png)
Case 4: Brave.Search.Promo.NewTabPage = 3_PASSED **3 Yes, Yes** -"Did the participant in Group C click on the promo - Yes" and "did they switch their default engine to Brave Search? - Yes" 1. Clean profile 1.44.x 2. Launch the browser using the cmd line flag `brave.exe --enable-features="BraveSearchNTP"` 3. Open brave://local-state file and ensure the metrics `Brave.Search.Promo.NewTabPage` is not shown 4. Open a NTP and ensured NTP search promo appears 5. Make search query via NTP promo 6. Change the default search engine to Brave by either clicking on the prompt that appears on the search engine results page 7. Open brave://local-state file and ensured that the metrics `Brave.Search.Promo.NewTabPage` response value is `3` as expected Example | Example | Example -- | -- | -- ![image](https://user-images.githubusercontent.com/38657976/188808308-4c8e503e-4755-40fb-bd51-05bce7a2cb82.png) | ![image](https://user-images.githubusercontent.com/38657976/188808404-5f1225c2-7077-419b-949f-fbbca2cf253f.png) | ![image](https://user-images.githubusercontent.com/38657976/188808487-6b682014-e29c-4427-b7de-daa442fc2c84.png)

US Region

Brave.Search.Promo.NewTabPage

Case 1: Brave.Search.Promo.NewTabPage = 0_PASSED **0 No, No** - "Did the participant in Group C click on the promo - No" and "did they switch their default engine to Brave Search? - No" 1. Clean profile 1.44.x 2. Launch the browser using the cmd line flag `brave.exe --enable-features="BraveSearchNTP"` 3. Open brave://local-state file and ensure the metrics `Brave.Search.Promo.NewTabPage` is not shown 4. Open a NTP and ensured NTP search promo isn't appear as `Brave` is the default SE for US 5. Change the default SE to something other than Brave 6. Open a NTP and ensured NTP search promo appears 7. Open brave://local-state file and ensured that the metrics `Brave.Search.Promo.NewTabPage` response value is `0` as expected Example | Example | Example -- | -- | -- ![image](https://user-images.githubusercontent.com/38657976/188810864-62cd7f5a-2cca-449f-ad48-9515022bdf90.png) | ![image](https://user-images.githubusercontent.com/38657976/188810936-aa2752e9-520e-48ee-a742-e911eecf2563.png) | ![image](https://user-images.githubusercontent.com/38657976/188811142-f5fd89f9-4607-4a11-86df-8894909543a5.png)
Case 2: Brave.Search.Promo.NewTabPage = 1_PASSED **1 Yes, No** - "Did the participant in Group C click on the promo - Yes" and "did they switch their default engine to Brave Search? - No" 1. Clean profile 1.44.x 2. Launch the browser using the cmd line flag `brave.exe --enable-features="BraveSearchNTP"` 3. Open brave://local-state file and ensure the metrics `Brave.Search.Promo.NewTabPage` is not shown 4. Open a NTP and ensured NTP search promo isn't appear as `Brave` is the default SE for US 5. Change the default SE to something other than Brave 6. Open a NTP and ensured NTP search promo appears 7. Make search query via NTP promo 8. Open brave://local-state file and ensured that the metrics `Brave.Search.Promo.NewTabPage` response value is `1` as expected Example | Example | Example -- | -- | -- ![image](https://user-images.githubusercontent.com/38657976/188811477-17b895ae-89b0-4588-85a6-00c1df9cafb2.png) | ![image](https://user-images.githubusercontent.com/38657976/188811537-4e274f84-52a5-4ab8-a6bc-5725e808e922.png) | ![image](https://user-images.githubusercontent.com/38657976/188811605-5ff58957-6339-41b1-9b8b-1e8257c7bbd4.png)
Case 3: Brave.Search.Promo.NewTabPage = 2_PASSED **2 No, Yes** - "Did the participant in Group C click on the promo - No" and "did they switch their default engine to Brave Search? - Yes" 1. Clean profile 1.44.x 2. Launch the browser using the cmd line flag `brave.exe --enable-features="BraveSearchNTP"` 3. Open brave://local-state file and ensure the metrics `Brave.Search.Promo.NewTabPage` is not shown 4. Open a NTP and ensured NTP search promo isn't appear as `Brave` is the default SE for US 5. Change the default SE to something other than Brave 6. Open a NTP and ensured NTP search promo appears 7. Change the default search engine to Brave via brave://settings/search 8. Open brave://local-state file and ensured that the metrics `Brave.Search.Promo.NewTabPage` response value is `2` as expected Example | Example -- | -- ![image](https://user-images.githubusercontent.com/38657976/188812616-246bd92d-89fd-418d-91f3-9a33371f94e3.png) | ![image](https://user-images.githubusercontent.com/38657976/188812669-c2bce300-7aa4-4df6-8397-eb5e24d9f943.png)
Case 4: Brave.Search.Promo.NewTabPage = 3_PASSED **3 Yes, Yes** - "Did the participant in Group C click on the promo - Yes" and "did they switch their default engine to Brave Search? - Yes" 1. Clean profile 1.44.x 2. Launch the browser using the cmd line flag `brave.exe --enable-features="BraveSearchNTP"` 3. Open brave://local-state file and ensure the metrics `Brave.Search.Promo.NewTabPage` is not shown 4. Open a NTP and ensured NTP search promo isn't appear as `Brave` is the default SE for US 5. Change the default SE to something other than Brave 6. Open a NTP and ensured NTP search promo appears 7. Make search query via NTP promo 8. Change the default search engine to Brave by by clicking on the prompt that appears on the search engine results page 9. Open brave://local-state file and ensured that the metrics `Brave.Search.Promo.NewTabPage` response value is `3` as expected Example | Example | Example | Example -- | -- | -- | -- ![image](https://user-images.githubusercontent.com/38657976/188813272-4b45a496-600c-4f7f-a522-b972c6e872c1.png) | ![image](https://user-images.githubusercontent.com/38657976/188813327-9683dc86-7341-4632-9368-8452ebb5344e.png) | ![image](https://user-images.githubusercontent.com/38657976/188813397-61702f5b-1341-4163-9234-1654d420abb6.png) | ![image](https://user-images.githubusercontent.com/38657976/188813461-c0326b1a-49db-4de0-8fe5-fd9f89d33b71.png)

Regression on https://github.com/brave/brave-browser/issues/23191

US Region

1. Brave.Search.Promo.Button

Case 1: Brave.Search.Promo.Button=0_PASSED **0. No, No** - "No, I have not clicked on the promo" and "No, I have not changed my default engine to Brave" 1. Clean profile 1.42.x , launch brave using `brave.exe --enable-logging=stderr --enable-features="BraveSearchOmniboxButton` 2. Open brave://local-state file 3. Search for the metric `Brave.Search.Promo.Button` 4. Ensured metric is not shown in the brave://local-state file 5. Navigate to brave://settings/search 6. Change the search engine to something other than Brave 7. Enter some random text in the Omnibox and ensured the button promo appears in the suggestion 8. Reload the brave://local-state file 9. Ensured that the metrics `Brave.Search.Promo.Button` is shown in the local state file 10. Ensured that the metrics response value is `0` as expected
Case 2: Brave.Search.Promo.Button=1_PASSED **1. Yes, No** - "Yes, I have clicked on the promo" and "No, I have not changed my default engine to Brave" 1. Follow the steps 1 to 7 from case 1 2. Click on the promo 3. Reload the brave://local-state file 4. Confirmed that the metric `Brave.Search.Promo.Banner` response value is `1` as expected
Case 3: Brave.Search.Promo.Button=2_PASSED **2. No, Yes** - "No, I have not clicked on the promo" and "Yes, I have changed my default engine to Brave" **Case 1:** Change the default SE to `Brave` via brave://settings/search - PASSED 1. Follow the steps 1 to 7 from case 1 2. Do not click on the promo 3. Navigate to brave://settings/search 4. Change the search engine to `Brave` 5. Confirmed that the metric `Brave.Search.Promo.Button` response value is `2` as expected **Case 2:** Change the default SE to `Brave` by clicking on the prompt that appears on the search engine results page - PASSED 1. Follow the steps 1 to 7 from case 1 2. Open the link https://search.brave.com/search?q=test&action=makeDefault 3. Change the default SE to brave by clicking on the prompt that appears on the search engine results page 4. Reload the brave://local-state page 5. Confirmed that the metric `Brave.Search.Promo.Button` response value is `2` as expected
Case 4: Brave.Search.Promo.Button=3_PASSED **3. Yes, Yes** - "Yes, I have clicked on the promo" and "Yes, I have changed my default engine to Brave" **Case 1:** change the default SE via search engine results page - PASSED 1. Follow the steps 1 to 7 from case 1 2. Click on the promo 3. Change the default SE to brave by clicking on the prompt that appears on the search engine results page 4. Reload the brave://local-state page 5. Confirmed that the metric `Brave.Search.Promo.Button` response value is `3` as expected **Case 2:** change the default SE via search engine results page - PASSED 1. Follow the steps 1 to 7 from case 1 2. Click on the promo 3. Change the default SE to brave via brave://settings/search 4. Reload the brave://local-state page 5. Confirmed that the metric `Brave.Search.Promo.Button` response value is `3` as expected

2. Brave.Search.Promo.Banner

Case 1: Brave.Search.Promo.Banner=0_PASSED **0. No, No** - "No, I have not clicked on the promo" and "No, I have not changed my default engine to Brave" 1. Clean profile 1.42.x , launch brave using `brave.exe --enable-logging=stderr --enable-features="BraveSearchOmniboxBanner"` 2. Open brave://local-state file 3. Search for the metric `Brave.Search.Promo.Banner` 4. Ensured metric is not shown in the brave://local-state file 5. Navigate to brave://settings/search 6. Change the search engine to something other than Brave 7. Enter some random text in the Omnibox and ensured the button promo appears in the suggestions 8. Reload the brave://local-state file 9. Ensured that the metrics `Brave.Search.Promo.Button` is shown in the local state file 10. Ensured that the metrics response value is `0` as expected ![image](https://user-images.githubusercontent.com/38657976/176164076-fa60c6a7-92a6-438a-a057-68d450ac9a94.png)
Case 2: Brave.Search.Promo.Banner=1_PASSED **1. Yes, No** - "Yes, I have clicked on the promo" and "No, I have not changed my default engine to Brave" 1. Follow the steps 1 to 7 from case 1 2. Click on the promo 3. Reload the brave://local-state file 4. Confirmed that the metric `Brave.Search.Promo.Banner` response value is `1` as expected
Case 3: Brave.Search.Promo.Banner=2_PASSED **2. No, Yes** - "No, I have not clicked on the promo" and "Yes, I have changed my default engine to Brave" **Case 1:** Change the default SE to `Brave` via brave://settings/search - PASSED 1. Follow the steps 1 to 7 from case 1 2. Do not click on the promo 3. Navigate to brave://settings/search 4. Change the search engine to `Brave` 5. Confirmed that the metric `Brave.Search.Promo.Banner` response value is `2` as expected **Case 2:** Change the default SE to `Brave` by clicking on the prompt that appears on the search engine results page - PASSED 1. Follow the steps 1 to 7 from case 1 2. Open the link https://search.brave.com/search?q=test&action=makeDefault 3. Change the default SE to brave by clicking on the prompt that appears on the search engine results page 4. Reload the brave://local-state page 5. Confirmed that the metric `Brave.Search.Promo.Banner` response value is `2` as expected
Case 4: Brave.Search.Promo.Banner=3_PASSED **3. Yes, Yes** - "Yes, I have clicked on the promo" and "Yes, I have changed my default engine to Brave" **Case 1:** change the default SE via search engine results page - PASSED 1. Follow the steps 1 to 7 from case 1 2. Click on the promo 3. Change the default SE to brave by clicking on the prompt that appears on the search engine results page 4. Reload the brave://local-state page 5. Confirmed that the metric `Brave.Search.Promo.Banner` response value is `3` as expected **Case 2:** change the default SE via search engine results page - PASSED 1. Follow the steps 1 to 7 from case 1 2. Click on the promo 3. Change the default SE to brave via brave://settings/search 4. Reload the brave://local-state page 5. Confirmed that the metric `Brave.Search.Promo.Banner` response value is `3` as expected

kjozwiak commented 1 year ago

Going to remove the above as we've never implemented the Brave search promo via NTP on Android. Currently we only have search promo implemented in the omnibox as per https://github.com/brave/brave-browser/issues/24902. CCing @timchilds @anthonypkeane @bsclifton please correct me if I'm wrong.

Thanks for looking at this @GeetaSarvadnya, I should have read it closer before pinging you to take a look.