search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.92k stars 2.35k forks source link

Make the shields button on ntp open global shields settings instead of being disabled #24158

Open wknapik opened 2 years ago

wknapik commented 2 years ago

The shields button is disabled in a new tab, so having it there doesn't help the user with anything, just clutters up the UI. We could make it useful by having it open global shields settings. Seems pretty natural/intuitive, as ntp represents a "global scope", not the scope of the ntp, to which shields don't apply. This could be done across platforms.

cc @rebron, @bsclifton

jenn-rhim commented 2 years ago

@aguscruiz ^

aguscruiz commented 2 years ago

I'm thinking we could reuse the non-https Shields dialog for everything that's Brave-related. Either NTP, or Settings pages in the browser.

What do you think @jenn-rhim?

image

wknapik commented 1 year ago

@rebron @jenn-rhim this isn't a big deal, but would be simple to implement and useful

wknapik commented 1 week ago

I keep wanting to click the shields icon on ntp to configure shields - that's all that would be required here, no need for new dialogs, just take the user to brave://settings/shields