Enable debounce by default

pilgrim-brave commented 2 years ago

As per recent team discussion, debouncing should graduate to be enabled by default (but still technically "behind" a feature flag so we can shut it off via variations server if something goes horribly wrong).

pilgrim-brave commented 2 years ago

QA test plan: https://dev-pages.brave.software/navigation-tracking/debouncing.html

Please also see https://github.com/brave/brave-core/pull/14262#issuecomment-1197772537.

kjozwiak commented 2 years ago

The above requires 1.42.81 or higher for 1.42.x verification 👍

LaurenWags commented 2 years ago

Verified with

Brave | 1.42.81 Chromium: 104.0.5112.69 (Official Build) (x86_64)
-- | --
Revision | 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS | macOS Version 12.5 (Build 21G72)

Reproduced using 1.41.100 Chromium: 103.0.5060.134:

Launched Brave with a new profile using 1.41.100 without restarting the browser and ensured that debouncing wasn't working as 1.41.100 doesn't have the above fix and requires a restart to pull BraveDebounceStudy:Enabled via Griffin.

`brave://version`	`Example (Default)`	`Example (Base64)`	`Example (Regex)`

Using the steps/test plan as per https://github.com/brave/brave-core/pull/14262#issuecomment-1197772537:

Launched 1.42.81 and ran through https://github.com/brave/brave-browser/issues/24159#issuecomment-1192804991 without restarting the browser and ensured that debouncing worked as expected.

`brave://version`	`Example (Default)`	`Example (Base64)`	`Example (Regex)`

Also ensured that debouncing worked as expected once the browser restarted and pulled BraveDebounceStudy:Enabled via Griffin. Checked brave://version and then ran through the same STR/Cases and ensured that debouncing was working:

`brave://version`	`Example (Default)`	`Example (Base64)`	`Example (Regex)`

Uni-verse commented 2 years ago

Verification PASSED on Samsung GS 21 using


Brave   1.42.81 Chromium: 104.0.5112.69 (Official Build) (64-bit) 
Revision    7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS  Android 12; Build/SP1A.210812.016

Version 1.41.100

Confirmed debouncing is disabled by default on 1.41.x without re-launching browser using test page - https://dev-pages.brave.software/navigation-tracking/debouncing.html
Confirmed for debouncing to work requires re-starting brave app.

Default	Base64	Regex	version

Version 1.42.81

Confirmed debouncing is working on 1.42.81 without re-starting browser.
Confirmed debouncing tests are working after re-starting the browser.

Default	Base64	Regex

Uni-verse commented 2 years ago

Verification PASSED on Samsung Tab S7 using


Brave   1.42.81 Chromium: 104.0.5112.69 (Official Build) (64-bit) 
Revision    7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS  Android 12; Build/SP1A.210812.016

Version 1.41.100

Confirmed debouncing is disabled by default on 1.41.x without re-launching browser using test page - https://dev-pages.brave.software/navigation-tracking/debouncing.html
Confirmed for debouncing to work requires re-starting brave app. Note: Regex debouncing test still failed after pulling griffin on Tablet on 1.41 but is working on 1.42

Default	Base64	Regex	version

Version 1.42.81

Confirmed debouncing is working on 1.42.81 without re-starting browser.
Confirmed debouncing tests are working after re-starting the browser.

Default	Base64	Regex

brave / brave-browser

Enable debounce by default #24159