search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.52k stars 2.27k forks source link

IPFS interstitial is not shown when redirect from .eth domains #24188

Closed cypt4 closed 2 years ago

cypt4 commented 2 years ago

Steps to Reproduce

  1. Set IPFS resolve option to "Ask"
  2. Navigate to vitalik.eth
  3. Check omnibox url. Remote gateway is loaded
stephendonner commented 2 years ago

Verified PASSED using

Brave 1.44.29 Chromium: 104.0.5112.81 (Official Build) nightly (x86_64)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS macOS Version 11.6.8 (Build 20G730)

Steps:

  1. installed 1.44.29
  2. launched Brave
  3. loaded vitalik.eth
  4. clicked on Proceed using Infrura server
  5. confirmed I got the interstitial page
  6. set Method to resolve IPFS resources to Disabled on brave://settings/ipfs
step 3-4 step 5 step 6
Screen Shot 2022-08-08 at 4 01 52 PM Screen Shot 2022-08-08 at 3 56 58 PM Screen Shot 2022-08-08 at 3 57 22 PM
  1. loaded vitalik.eth

Confirmed I got the the following error message:

Screen Shot 2022-08-08 at 3 57 30 PM