search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.65k stars 2.3k forks source link

Chromium bookmarks icon is displayed in search suggestions #24247

Closed GeetaSarvadnya closed 2 years ago

GeetaSarvadnya commented 2 years ago

Description

Chromium icon is displayed in search suggestions

Steps to Reproduce

Case 1:

  1. Open 1.41/1.42/1.43
  2. Enter a string hello in address bar
  3. Hello search result page is displayed
  4. Bookmark the result page
  5. Open a new tab and enter a string hello suggested result has the chromium icon

Case 2:

  1. Import bookmarks from other browser
  2. Search a string test
  3. Suggested result has the chromium icon

Actual result:

image image (1)

Expected result:

Chromium icon should not be displayed in search suggestions

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.43.43 Chromium: 104.0.5112.57 (Official Build) nightly (64-bit)
Revision 212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS Windows 10 Version 21H2 (Build 19044.1826)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

cc: @brave/qa-team @mkarolin @rebron

LaurenWags commented 2 years ago

Reproduced on macOS 

Brave | 1.42.74 Chromium: 103.0.5060.134 (Official Build) beta (x86_64)
-- | --
Revision | 8ec6fce403b3feb0869b0732eda8bd95011d333c-refs/branch-heads/5060@{#1262}
OS | macOS Version 12.5 (Build 21G72)
Screen Shot 2022-07-25 at 8 13 25 AM
rebron commented 2 years ago

cc: @simonhong When you get a chance, can you take a look.

MadhaviSeelam commented 2 years ago

Verification PASSED using

Brave | 1.44.70 Chromium: 105.0.5195.68 (Official Build) beta (64-bit)
-- | --
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Windows 11 Version 21H2 (Build 22000.856)

Verified using original STR https://github.com/brave/brave-browser/issues/24247#issue-1316745380

Case 1:

  1. installed 1.44.70
  2. launched Brave
  3. entered a string hello in address bar
  4. search result page for hello is displayed
  5. bookmarked the result page
  6. opened a new tab and entered string hello

Confirmed bookmark icon displayed in the omnibox autocomplete entry

step 3 step 4-5
image image

Case 2:

  1. imported bookmarks from MS edge browser
  2. searched with a string 'news`

Confirmed no Chromium icons displayed in the omnibox autocomplete entry

image