brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
18k stars 2.36k forks source link

Add additional language pairs to Brave Translate #24303

Closed rebron closed 2 years ago

rebron commented 2 years ago

Description

Add remaining 93 language pairs to Brave Translate. Total of 108 language pairs.

Steps to Reproduce

Visit brave://translate-internals

Currently we have (15): de (German) en (English) es (Spanish) fr (French) hi (Hindi) it (Italian) ja (Japanese) nl (Dutch) pl (Polish) pt (Portuguese) ro (Romanian) ru (Russian) tr (Turkish) vi (Vietnamese) zh-Hans

Expected result:

1 Afrikaans 2 Albanian 3 Amharic 4 Arabic 5 Armenian 6 Azerbaijani 7 Basque 8 Belarusian 9 Bengali (or Bangladeshi) 10 Bosnian 11 Bulgarian 12 Catalan (Valencian) 13 Cebuano 14 Chichewa (or Nyanja) 15 Chinese (Simplied) 16 Chinese (Traditional) 17 Corsican 18 Croatian 19 Czech 20 Danish 21 Dutch 22 Esperanto 23 Estonian 24 Filipino (Tagalog) 25 Finnish 26 French 27 Frisian 28 Galician 29 Georgian 30 German 31 Greek 32 Gujarati 33 Haitian Creole 34 Hausa 35 Hawaiian 36 Hebrew 37 Hindi 38 Hmong 39 Hungarian 40 Icelandic 41 Igbo 42 Indonesian (or Bahasa Indonesia) 43 Irish 44 Italian 45 Japanese 46 Javanese 47 Kannada 48 Kazakh 49 Khmer (or Cambodian) 50 Kinyarwanda 51 Korean 52 Kurdish 53 Kyrgyz 54 Lao (Laos) 55 Latin 56 Latvian 57 Lithuanian 58 Luxembourgish 59 Macedonian 60 Malagasy 61 Malay (or Bahasa Melayu) 62 Malayalam 63 Maltese 64 Maori 65 Marathi 66 Mongolian 67 Myanmar (Burmese) 68 Nepali 69 Norwegian 70 Odia 71 Persian (or Iranian) 72 Polish 73 Portuguese 74 Punjabi (Panjabi) 75 Pushto (Pashto) 76 Romanian 77 Russian 78 Samoan 79 Scottish (Gaelic) 80 Serbian - Cyrillic 81 Sesotho 82 Shona 83 Sindhi 84 Sinhala (or Sinhalese) 85 Slovak 86 Slovenian 87 Somali 88 Spanish 89 Sundanese 90 Swahili 91 Swedish 92 Tajik 93 Tamil 94 Tatar 95 Telugu 96 Thai 97 Turkish 98 Turkmen 99 Ukrainian 100 Urdu 101 Uyghur 102 Uzbek 103 Vietnamese 104 Welsh 105 Xhosa 106 Yiddish 107 Yoruba 108 Zulu

Desktop Brave version:

Target 1.43.x

Android Device details:

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

rebron commented 2 years ago

cc: @linhkikuchi

mx202 commented 2 years ago

I hope they will support Arabic and other languages soon like Microsoft Edge does

linhkikuchi commented 2 years ago

I hope they will support Arabic and other languages soon like Microsoft Edge does

Yes, we do have Arabic, all languages (from the above list) are supported, we can see it here on staging https://translate.bravesoftware.com/translate_a/l

bsclifton commented 2 years ago

+2 for Chinese translations

cc19264997 commented 2 years ago

Hello, when can I support Chinese translation? I need him very much, thank you!~~

SWxEng commented 2 years ago

Hi . Pls fix a problem ​Arabic + Englisn in Translate Web..... . Desktop Brave version / 1.44.112 Chromium: 106.0.5249.119 (Official Build) (64-bit) 2022-10-12

rebron commented 2 years ago

Closed with https://github.com/brave/brave-core/pull/15433

kjozwiak commented 2 years ago

The above requires 1.45.102 or higher for 1.45.x verification 👍

MadhaviSeelam commented 2 years ago

Verification PASSED using

Brave | 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (64-bit)
-- | --
Revision | fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS | Windows 11 Version 21H2 (Build 22000.1098)

Case 1: Verify Brave translate functionality with additional supported languages

- Installed 1.45.104 - Launch Brave - Verified translation functionality worked as expected for newly supported languages - `Chinese (Traditional)`, `Telugu`, `Portuguese`, `Afrikaans` and `Irish` Chinese (Traditional) ----- Visted https://www.ltn.com.tw/ Chinese (traditional)|English ---|--- image|image Portuguese ---- visit https://www.publico.pt/ Portuguese|English ---|--- image|image Telugu ----- - visited https://www.ntnews.com/ Telugu|English ---|--- image|image Afrikaans ------ - visited https://www.netwerk24.com/ Afrikaans|English ---|--- image|image Irish ------ - visited https://cic.ie Irish|English ----|--- image|image

Case 2: Choose another language - Chinese --> Hindi

- selected `Another language` -`Hindi` - page translated to successfully Ex1|Ex2|Ex3 ---|---|--- image|image|image

Case 3: Never translate

- selected `Never translate` option in the `hamburger` menu - `Brave translate` icon disappeared when clicked on a link Ex1|Ex2 ---|--- image|<image

Case 4: Always translate

- selected `Always translate` option in the `hamburger` menu - switch between `Afrikaans` and `English` language and the translation worked as expected. Ex1|Ex2 ---|---- image|image

Case 5: brave://translate-internals page lists newly supported languages, a total of 108 language pairs

- `brave://translate-internals` page lists newly supported languages, a total of 108 language pairs. No errors logged on the page Ex1|Ex2 ---|---- image|image

Case 6: Change OS - Turkish

- Change OS to Turkish - clean profile - launch Brave - visit English language site bbc.com - confirmed Brave translate bubble is displayed in the URL bar - confirmed options displayed in hamburger menu as expected in selected OS language Turkish - translation worked as expected Ex1|Ex2|Ex1|Ex2 ---|---|----|---- image|image|image|image
GeetaSarvadnya commented 2 years ago

Verification PASSED on vivo x70 Pro version 12 running Bravemonoarm64.apk_1.45.108

Example Example Example Example Example Example Example Example
Screenshot_20221020_211412 Screenshot_20221020_211420 Screenshot_20221020_211428 Screenshot_20221020_211439 Screenshot_20221020_211448 Screenshot_20221020_211455 Screenshot_20221020_211507 Screenshot_20221020_211513
Verify translation for few locales **_cn.chinadaily.com.con_** Chinese (simplified) | Kannada -- | -- ![Screenshot_20221020_212708](https://user-images.githubusercontent.com/38657976/197000747-e6240ebc-a8be-46fa-aa0c-40183be4180c.jpg) | ![Screenshot_20221020_212721](https://user-images.githubusercontent.com/38657976/197000785-ac519206-02bc-4ebe-9a84-621e9fe1522d.jpg) **_kannada.news18.com_** Kannada | Arabic -- | -- ![Screenshot_20221020_213410](https://user-images.githubusercontent.com/38657976/197001305-a2c411b4-a881-4e20-915e-7eee600a1f20.jpg) | ![Screenshot_20221020_213432](https://user-images.githubusercontent.com/38657976/197001337-f476d32c-700c-402b-abd3-10f41d242d42.jpg) Additional testing is covered in https://github.com/brave/brave-browser/issues/25347#issuecomment-1285481668
Never translate this page - Open any non english page - Ensure that the translate bubble is shown - Click on the 3 dot menu - Clck on `Never translate this page` - Ensure that the translate bubble is removed from the page Example | Example -- | -- ![Screenshot_20221020_225706](https://user-images.githubusercontent.com/38657976/197130852-e55cf867-350f-4aa1-8e3e-96a548182a38.jpg) | ![Screenshot_20221021_120936](https://user-images.githubusercontent.com/38657976/197130890-6a6a096c-66e3-4ca8-947c-58d4532a0159.jpg)
Always translate the pages - Open any non english page - Ensure that the translate bubble is shown - Click on the 3 dot menu - Clck on `Always translate this page` - Ensure that the the info message is shown as "Pages in Hindi will be translated to English from now" - Ensured that the page translated to English Example | Example | Example -- | -- | -- ![Screenshot_20221020_225706](https://user-images.githubusercontent.com/38657976/197136907-40640f0c-3b79-4730-a3cf-6d01d3406536.jpg) | ![Screenshot_20221021_124641](https://user-images.githubusercontent.com/38657976/197136935-65ef0d45-4281-46b4-a87e-b0388cd2953e.jpg) | ![Screenshot_20221021_124647](https://user-images.githubusercontent.com/38657976/197136963-88de04b9-c1fe-4b59-83c3-98425452ece8.jpg)

Verification PASSED on Samsung Galaxy Tab A7 version 12 running Bravemonoarm64.apk_1.45.108

Example Example Example Example Example
Screenshot_20221021-132713_Brave Screenshot_20221021-132734_Brave Screenshot_20221021-132748_Brave Screenshot_20221021-132804_Brave Screenshot_20221021-132815_Brave
Verify translation for few locales **_cn.chinadaily.com.con_** Chinese (simplified) | Kannada -- | -- ![Screenshot_20221021-133105_Brave](https://user-images.githubusercontent.com/38657976/197147554-15956168-bf25-4d6b-907f-5f6e68e98292.jpg) | ![Screenshot_20221021-133158_Brave](https://user-images.githubusercontent.com/38657976/197147579-80349021-6ffe-4988-88df-b11c9d173d93.jpg) **_kannada.news18.com_** Kannada | Arabic -- | -- ![Screenshot_20221021-133158_Brave](https://user-images.githubusercontent.com/38657976/197147827-97e032a6-e8fa-4e4a-9106-d89668815ece.jpg) | ![Screenshot_20221021-133220_Brave](https://user-images.githubusercontent.com/38657976/197147861-f427deef-744b-41d5-ac5f-9a7e20d943bb.jpg) Additional testing is covered in https://github.com/brave/brave-browser/issues/25347#issuecomment-1285481668
Never translate this page - Open any non english page - Ensure that the translate bubble is shown - Click on the 3 dot menu - Clck on `Never translate this page` - Ensure that the translate bubble is removed from the page Example | Example | Example -- | -- | -- ![Screenshot_20221021-133413_Brave](https://user-images.githubusercontent.com/38657976/197148200-98271881-8c2d-4169-b32f-288a476f976f.jpg) | ![Screenshot_20221021-133428_Brave](https://user-images.githubusercontent.com/38657976/197148249-1f360d25-c283-4066-9bc8-7921e6855b4f.jpg) | ![Screenshot_20221021-133442_Brave](https://user-images.githubusercontent.com/38657976/197148298-027a5551-f0b2-48b5-8074-333f87eccb26.jpg)
Always translate the pages - Open any non english page - Ensure that the translate bubble is shown - Click on the 3 dot menu - Clck on `Always translate this page` - Ensure that the the info message is shown as "Pages in Hindi will be translated to English from now" - Ensured that the page translated to English Example | Example | Example -- | -- | -- ![Screenshot_20221021-133623_Brave](https://user-images.githubusercontent.com/38657976/197148607-11b6dd89-00c4-443e-8768-820bce3d2358.jpg) | ![Screenshot_20221021-133635_Brave](https://user-images.githubusercontent.com/38657976/197148634-220fb22c-72e8-4db9-81df-264bf30608d8.jpg) | ![Screenshot_20221021-133644_Brave](https://user-images.githubusercontent.com/38657976/197148668-f956ffe0-2c1b-4554-af73-bb46bbd4bd69.jpg)
biange200 commented 2 years ago

Not supported It should be brave browser using Google Translate function Google Translate is not available in China now

@.***

@.*** |

---- Replied Message ---- | From | @.> | | Date | 10/20/2022 22:19 | | To | @.> | | Cc | @.**@.> | | Subject | Re: [brave/brave-browser] Add additional language pairs to Brave Translate (Issue #24303) |

Verification is inprogress on vivo x70 Pro version 12 running Bravemonoarm64.apk_1.45.108

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

git10135405 commented 2 years ago

come on, hope translate others language to chinese simple!!

m77e4t commented 2 years ago

One user has requested Kurdish Sorani (Kurdish Central) along with Kurdish Kurmanji (Kurdish Northern). https://community.brave.com/t/enabling-central-kurdish-to-web-translation/434941/

Lingvanex only has Kurdish Kurmanji and not Kurdish Sorani. Kurmanji uses Latin alphabet while Sorani uses Kurdish Alphabet. Google Translate has both Sorani and Kurmanji in its catalogue.

According to the user, Kurdish Sorani is the official language in some parts of the area https://en.m.wikipedia.org/wiki/Sorani

git10135405 commented 11 months ago

安卓版 中国大陆翻译完全没法用!!!

biange200 commented 11 months ago

安卓版 中国大陆翻译完全没法用!!!

只能选择翻墙,翻墙后,翻译速度也慢