search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.61k stars 2.28k forks source link

Evaluate usage of base::StringPrintf in Brave Wallet #24401

Open nvonpentz opened 2 years ago

nvonpentz commented 2 years ago

Let's review how we're using base:StringPrintf in the codebase, and see if we can use net::AppendQueryParameter for query parameters and base::Value for JSON building instead.

Related to https://github.com/brave/brave-core/pull/14329#pullrequestreview-1059396584.

onyb commented 1 year ago

It would be nice to also have a helper like this for constructing URLs using individual paths, to complement net::AppendQueryParameter.

GURL AppendPath(const GURL& url, base::StringPiece path)