brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.84k stars 2.33k forks source link

additional profile name has Chrome style pill shaped highlight #24467

Open LaurenWags opened 2 years ago

LaurenWags commented 2 years ago

Description

After you add a second profile, the profile name displays in the upper right corner of the window in a box w/ rounded edges (Brave style), but the hover/highlighting on the profile name is pill shaped (Chrome style).

The highlight/hover should be box w/ rounded edges as well, the pill shaped highlight in the box looks odd and out of place.

Steps to Reproduce

  1. Create a second profile
  2. Look at the profile name in the upper right corner
  3. Profile name is highlighted in a pill shape which can go outside of the box and looks odd. It's more prominent on dark themed windows than light themed ones.

Actual result:

Darker theme Lighter theme
1-dk 1-lt

Expected result:

No pill shaped highlight

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.44.23 Chromium: 104.0.5112.81 (Official Build) nightly (x86_64)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS macOS Version 12.5 (Build 21G72)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

cc @rebron

aguscruiz commented 2 years ago

Added designs here from the account switcher tooltip, but overall it seems it just need to be rounded and that's pretty much it.

https://www.figma.com/file/sS3l8tqUFxt54MEiBTalUI/Desktop-toolbar-and-menu?node-id=1792%3A6053

image

image