search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.52k stars 2.27k forks source link

Register as an AutoFill Service on Android #24618

Open fallaciousreasoning opened 2 years ago

fallaciousreasoning commented 2 years ago

Description

On Android, Brave should be registered as an Autofill services. That way, users of Brave can use Brave to autofill passwords in other applications.

Steps to reproduce

  1. Save a password in Brave for a site which also has a mobile app.
  2. Open the mobile app.

Actual result

No password is suggested

Expected result

Brave suggests the saved password

Additional information

Firefox on Android offers this functionality, and it's pretty handy.

This issue is related (but orthogonal) to https://github.com/brave/brave-browser/issues/7355. That issue is about supporting AutoFill from other AutoFill services in Brave, this one is about Brave providing it's own AutoFill service.

The Android docs for AutoFill services are here: https://developer.android.com/reference/android/service/autofill/AutofillService

kbuilds commented 2 years ago

I was just looking into this feature to see if Brave could be used as Android's autofill service, and came across this issue. Just leaving a comment here to track and to +1.

Chiramisu commented 1 year ago

I have been anxiously waiting for this functionality to be implemented as well. It's very disappointing that our only options are spyware like Google. 😢

Brave is my favorite browser, but Edge has quickly become a close second. Too bad it's Microsoft.

kbuilds commented 1 year ago

@Chiramisu Honestly I would rather just remember all of my random passwords than use Edge.

deeppandya commented 1 year ago

@deeppandya create a sec review for the issue

bsclifton commented 1 year ago

+1 from https://github.com/brave/brave-browser/issues/16817

Also related:

Chiramisu commented 1 year ago

@kbuilds I like the functionality of Edge, and being a .NET guy it makes sense to use it for work. However, I also practice "Browser Isolation" as outlined by Rob Braxman. Brave is my favorite and most private browser, but I also use Edge for Microsoft sites, Chrome for Google sites, and experiment with others as well.

akakou commented 1 year ago

Has no one attempted to implement the features mentioned in this PR? If so, I will implement it.

fallaciousreasoning commented 1 year ago

@deeppandya is this fine for @akakou to pick up?

deeppandya commented 1 year ago

@deeppandya is this fine for @akakou to pick up?

@fallaciousreasoning we are planning to look at it relatively soon.

fallaciousreasoning commented 1 year ago

@akakou probably best to leave it then :smile:

akakou commented 1 year ago

OK! Thank you! I will wait, and I'm looking forward to using these new features :)