brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.7k stars 2.31k forks source link

Correct site favicons are not displayed in the Shields panel #24954

Closed MadhaviSeelam closed 2 years ago

MadhaviSeelam commented 2 years ago

Description

Steps to Reproduce

  1. Install 1.45.1
  2. Launch Brave
  3. visit https://cnn.com
  4. click Shields icon
  5. click learn more link in the Shields panel

Actual result:

Incorrect icons rendered

Ex1 Ex2
cnnsite privacy

Expected result:

CNN favicon should render for CNN.com When clicked on Learn more link Brave favicon should render in the Shields panel for https://brave.com/privacy-features/ page

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 1.45.1 Chromium: 105.0.5195.37 (Official Build) nightly (64-bit)
Revision 5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS Windows 11 Version 21H2 (Build 22000.856)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

GeetaSarvadnya commented 2 years ago

Issue is NOT reproducible in RC - 1.42.x hence adding the regression label

GeetaSarvadnya commented 2 years ago

Verification PASSE on

Brave | 1.43.82 Chromium: 105.0.5195.58 (Official Build) (64-bit)
-- | --
Revision | 1907e1693887af4463221a10247360b7a056db49-refs/branch-heads/5195_47@{#3}
OS | Windows 10 Version 21H2 (Build 19044.1889)

Ensured that correct site favicon is shown in the shield panel Staging:

Example Example Example Example Example Example
image image image image image image

Production

Example Example Example Example Example Example
image image image image image image