Closed LaurenWags closed 2 years ago
Added QA/Blocked
label until uplifted to 1.43.x
Can be tested with 1.43.84 and above.
Verified with
Brave | 1.43.84 Chromium: 105.0.5195.68 (Official Build) (x86_64)
-- | --
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | macOS Version 12.5.1 (Build 21G83)
Verification completed on Samsung GS 21
on Android 12
using the following build(s):
1.43.86 Chromium: 105.0.5195.68 (Official Build) (64-bit)
Revision ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS Android 12; Build/SP1A.210812.016
Testing based on https://github.com/brave/brave-browser/issues/24980#issuecomment-1231605389
Arrived Rewards (Gemini/Uphold/Anon) | Countdown message (Gemini/Uphold/Anon) | bitFlyer Arrival | bitFlyer Countdown message | |
---|---|---|---|---|
Description
Found while testing https://github.com/brave/brave-browser/issues/23429
When
parameters
endpoint returnscomplete
(and the date is on or after the payment date), there is no green "Arrived" banner for ad grant. Green "Arrived" banner does not display until you successfully complete the captcha. This seems to indicate that the API isn't being utilized.Steps to Reproduce
Pre-req: server should be set to return "complete" for payout status
Repeat above for unverified rewards as well as verified user w/ a custodial wallet provider (Uphold, Gemini, bF)
Actual result:
No green "Arrived" banner on ads panel of brave://rewards, rewards panel, NTP widget
Expected result:
Green "Arrived" banner to show since the API is returning "complete"
Note - possibly the green "Arrived" banner should be removed from view if you complete a captcha? Mentioned by @Miyayes. Need to confirm - makes sense for it to do so in unverified case, but what happens if you have a custodian? does the banner just always display until "off" is returned from API?
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @Miyayes @emerick @GeetaSarvadnya