brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.87k stars 2.34k forks source link

translate not detecting from Spanish to English in certain cases #24983

Open rebron opened 2 years ago

rebron commented 2 years ago

Description

https://twitter.com/nicolasvillar99/status/1562888154318659584 Using Spanish locale and going tohttps://www.reddit.com/r/brave_browser/ or https://winaero.com/task-manager-can-now-generate-live-kernel-dumps-heres-how-to-enable-it/ don't display the translation prompt.

Steps to Reproduce

  1. Use 1.43.x and higher and make sure Brave Translate is enabled "BraveTranslateStudy:Enabled" in brave://version or brave://flags/#brave-translate-go is "default" or "enabled".
  2. Use Spanish locale version of Brave.
  3. Visit links in the description and notice that Brave Translate isn't shown.

Actual result:

No Brave Translate bubble.

Expected result:

Brave Translate bubble is displayed in the url bar.

Reproduces how often:

Easily.

Desktop Brave version:

Android Device details:

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

atuchin-m commented 2 years ago

@rebron I couldn't reproduce it with the second site.

As for reddit.com: it fact is has a mixed en-es content in that case (because of the en content). It results that CLD3 language detection consider it as en => the final verdict is controversial (because es from HTML lang). The same for Chrome.

Brave: image

image

Chrome:

image