brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.52k stars 2.27k forks source link

Ethereum site settings permission replaces Ask with Block #25057

Closed kdenhartog closed 2 years ago

kdenhartog commented 2 years ago

When accessing the site settings of a particular site to take a look at the permissions (accessed via lock in omnibox -> site settings) the permissions has the incorrect permissions. Rather than setting default to Block the text default should be Ask.

This is what the ethereum permissions drop down looks like: Screen Shot 2022-08-30 at 11 10 13 AM


However this is what the Solana permissions dropdown looks like: Screen Shot 2022-08-30 at 11 11 38 AM

darkdh commented 2 years ago

Please check your global ethereum setting (brave://settings/content/ethereum) and if it is blocked, then per site setting would be blocked by default. This is how content setting works not a bug.

kdenhartog commented 2 years ago

Thanks that was the issue. I had defaulted that to off globally when I was playing around with what this is guarding and didn't realized it would change this text here. I assumed this was statically set text.