search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.52k stars 2.27k forks source link

Remove code to suggest installing Google Translate Extension #25347

Closed atuchin-m closed 1 year ago

atuchin-m commented 1 year ago

After enabling the new Translate feature by default we can remove the code to install Goggle Translate extension (including the bubble).

The behaviour for the existing Google Translate extension users is discussed in https://github.com/brave/brave-browser/issues/24715

atuchin-m commented 1 year ago

Test plan:

  1. Sanity check that build-in translation works (any desktop platform + android);
  2. Check that translation bubble and the icon in the omnibox is unchanged (any desktop platform);
  3. Check that Enable internal translate engine (brave-translate-go) flag is removed from brave://flags (desktop + android)
stephendonner commented 1 year ago

Verified PASSED using

Brave 1.45.75 Chromium: 106.0.5249.65 (Official Build) beta (x86_64)
Revision 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS macOS Version 11.7 (Build 20G817)

Case 1: in-build translation

example | example ---------|---------- Screen Shot 2022-09-27 at 11 02 35 AM | Screen Shot 2022-09-27 at 10 46 26 AM

Case 2: translation "bubble" and icon

Screen Shot 2022-09-27 at 10 54 13 AM

Case 3: confirmed that the brave-translate-go flag is removed from brave://flags

Screen Shot 2022-09-27 at 10 48 32 AM

Confirmed I was not prompted to install Google Translate, and Brave Translate worked without any additional setup

MadhaviSeelam commented 1 year ago

Verification PASSED using 

Brave | 1.45.77 Chromium: 106.0.5249.65 (Official Build) beta (64-bit)
-- | --
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS | Windows 11 Version 21H2 (Build 22000.978)

Case 1: Verified Built-in translation works as expected and additionally not prompted to install Google Translate extension

Ex1 Ex2
image image

Case 2: Verified translation bubble and the icon in the omnibox displayed as expected

image

Case 3: Verified #brave-translate-go flag is removed from brave://flags

image
btlechowski commented 1 year ago

Verification passed on

Brave 1.45.90 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Ubuntu 18.04 LTS

Case 1: in-build translation

![image](https://user-images.githubusercontent.com/34715963/196370743-2d78ff18-08f5-41ec-a580-28e3b2afc772.png) ![image](https://user-images.githubusercontent.com/34715963/196370961-bc1a7d5b-f23b-42b7-89c1-a4b36d5d6f75.png)

Case 2: translation "bubble" and icon

![image](https://user-images.githubusercontent.com/34715963/196371222-5590057c-4b9f-4c2b-a8ac-91367beb9e0f.png)

Case 3: confirmed that the brave-translate-go flag is removed from brave://flags

![image](https://user-images.githubusercontent.com/34715963/196371994-7cb78f7e-d46c-4951-9142-5334257a0380.png)

Confirmed I was not prompted to install Google Translate, and Brave Translate worked without any additional setup

GeetaSarvadnya commented 1 year ago

Verification PASSED on vivo x70 Pro version 12 running Bravemonoarm64.apk_1.45.108

Case 1: in-build translation

![Screenshot_20221020_192439](https://user-images.githubusercontent.com/38657976/196969424-37ff2beb-0f60-41fb-943a-47d81d64bd4f.jpg)

Case 2: translation "bubble" and icon

Example | Example -- | -- ![Screenshot_20221020_192514](https://user-images.githubusercontent.com/38657976/196970458-edc5ddc0-622c-412a-89e0-e6b63a2953d4.jpg) | ![Screenshot_20221020_192522](https://user-images.githubusercontent.com/38657976/196970495-41900fac-d395-4ba7-ab11-a0cd04464542.jpg)

Case 3: confirmed that the brave-translate-go flag is removed from brave://flags

Example | Example -- | -- ![Screenshot_20221020_192736](https://user-images.githubusercontent.com/38657976/196970572-c1b08378-eccd-473b-b3c0-42ded8c8e579.jpg) | ![Screenshot_20221020_192751](https://user-images.githubusercontent.com/38657976/196970611-8c700093-d175-4043-bda2-841df6405d62.jpg)

Confirmed I was not prompted to install Google Translate, and Brave Translate worked without any additional setup

Verification PASSED on Samsung Galaxy Tab A7 version 12 running Bravemonoarm64.apk_1.45.108

Case 1: in-build translation

![Screenshot_20221020-193909_Brave](https://user-images.githubusercontent.com/38657976/196972618-4714ea20-fdcd-4e07-963b-d569bb9a7004.jpg)

Case 2: translation "bubble" and icon

Example | Example -- | -- ![Screenshot_20221020-193924_Brave](https://user-images.githubusercontent.com/38657976/196972658-574021e8-4b4e-48f1-98ee-5faad617b595.jpg) | ![Screenshot_20221020-193932_Brave](https://user-images.githubusercontent.com/38657976/196972698-430e3991-2b5d-4849-92b0-023c491275a8.jpg)

Case 3: confirmed that the brave-translate-go flag is removed from brave://flags

![Screenshot_20221020-194020_Brave](https://user-images.githubusercontent.com/38657976/196972766-a4480b74-ce1d-4332-a393-e355a7a5ceff.jpg)

Confirmed I was not prompted to install Google Translate, and Brave Translate worked without any additional setup