impossible to translate part of page

lazymonkey2 commented 2 years ago

Description

This page: https://www.reddit.com/r/brave_browser/comments/xb20tt/a%C3%BAn_sin_poder_conectar_mi_cuenta_de_uphold/ is almost all in english, but the text of the post is written in another language. When I try to translate the page into english it fails, and if I select only the text of the post I cannot see the translate option in the popup menu.

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Can you reproduce this issue with the current release?
Can you reproduce this issue with the beta channel?
Can you reproduce this issue with the nightly channel?

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

atuchin-m commented 2 years ago

If you force translation es => en, it works. After https://github.com/brave/brave-browser/issues/24303 the autodetect option should also works. This should cover your scenario: auto => en translation make all the page English.

Currently, we don't have plans to support translation a part of the page.

holdit commented 2 years ago

@atuchin-m

If you force translation es => en, it works.

Perhaps it's a good idea to always have the translation icon in the URL bar while detection is still bad? If not permanently, at least something like the QR code generator.

On macOS, I need to right click » Translate to English » see the error message » (now I finally can use the translation menu) » Translate Options » Page is not in the detected language » Select language (and guess it) » Try again

lukemulks commented 1 year ago

+1 on this from the BAT Community Call today - would be ideal to allow for translation for highlighted text on desktop and mobile.

brave / brave-browser