Selecting No for creating Solana Account doesn't set the network back to Ethereum in Send screen - Githubissues

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.87k stars 2.34k forks source link

Selecting No for creating Solana Account doesn't set the network back to Ethereum in Send screen #25373

Closed srirambv closed 2 years ago

srirambv commented 2 years ago

Description

Selecting No for creating Solana Account doesn't set the network back to Ethereum in Send screen

Steps to reproduce

Clean profile & Create wallet
Select Send from BuySendSwap button
Select Solana from network dropdown
Select No to cancel account creation
Network remains as Solana but token/address is still set to Ethereum

Actual result

https://user-images.githubusercontent.com/17010094/189922097-6deaebd5-04f5-480d-bed9-532a930b8ab1.mp4

Expected result

Reset network back to Ethereum or selected EVM network if user cancels to create Solana Account

Issue reproduces how often

Easy

Version/Channel Information:

Can you reproduce this issue with the current Play Store version? NA
Can you reproduce this issue with the current Play Store Beta version? Yes
Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

Install type (ARM, x86): ARM
Device type (Phone, Tablet, Phablet): Phone
Android version: 12

Brave version

1.44.79

Website problems only

Does the issue resolve itself when disabling Brave Shields? NA
Does the issue resolve itself when disabling Brave Rewards? NA
Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @Pavneet-Sing

srirambv commented 2 years ago

Verification passed on the following devices running 1.45.88 x64 Beta build

Verified steps from issue description & brave/brave-core#15118
Verified selecting No doesn't set network to Solana
Verified able to create a Solana account successfully on upgrade

Oppo Reno 5 (Android 12)	Samsung Tab A (Android 10)