Closed jsecretan closed 1 year ago
Verification passed on
Brave | 1.46.83 Chromium: 107.0.5304.68 (Official Build) beta (64-bit) |
---|---|
Revision | a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991} |
OS | Ubuntu 18.04 LTS |
Verified test plan from https://github.com/brave/brave-core/pull/15147
Clean profile
Ads enabled
Ads disabled
Removing QA Pass-Linux
as this is being uplifted to 1.45.x where it will need to be retested. In the event that there is not another 1.45.x build, the label can be re-added.
Requires 1.45.129
or higher to test.
Verification passed on
Brave | 1.45.129 Chromium: 107.0.5304.110 (Official Build) (64-bit) |
---|---|
Revision | 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202} |
OS | Ubuntu 18.04 LTS |
Verified test plan from https://github.com/brave/brave-core/pull/15147
Clean profile
Ads enabled
Ads disabled
Ads enabled - Private window
Clean profile
Ads enabled
Ads disabled
Verification passed on
Brave | 1.45.129 Chromium: 107.0.5304.110 (Official Build) (64-bit) |
---|---|
Revision | 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202} |
OS | Windows 10 Version 21H2 (Build 19044.2251) |
Verified test plan from https://github.com/brave/brave-core/pull/15147
Clean profile
Ads enabled
Ads disabled
Verification passed on Brave v1.45.129 on Samsung Galaxy Tab S5e (Android 11.0)
Verified test plan from https://github.com/brave/brave-core/pull/15147
Clean profile
Ads enabled
Ads disabled
Verified on Samsung Galaxy S21
using the following build(s):
Brave 1.45.131 Chromium: 107.0.5304.110 (Official Build) (64-bit)
Revision 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS Android 12; Build/SP1A.210812.016
x-brave-ads-enabled: 1
is not appended to the header
x-brave-ads-enabled: 1
is appended to the header
x-brave-ads-enabled
header to the request when ads are enabled.
Description
In preparation for Brave Ads on Brave Search, it is helpful for the Brave Search backend to understand whether the requesting browser has Brave Ads enabled. As such we should add the header
X-Brave-Ads-Enabled: 1
to any call to Brave Search (and it's associated dev/staging environments) whether originating from the main search box or the Omnibox.This can hopefully use some of the same mechanisms that have been used in the past on this, e.g. https://github.com/brave/brave-browser/wiki/Custom-Headers. When the work is complete, please add an appropriate description to this page: https://github.com/brave/brave-browser/wiki/Custom-Headers.