brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.09k stars 2.23k forks source link

Upgrade from Chromium 106.0.5249.61 to Chromium 106.0.5249.65 #25629

Closed mkarolin closed 1 year ago

mkarolin commented 1 year ago

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/106.0.5249.61..106.0.5249.65?pretty=fuller&n=10000

QA tests:

Check branding items Check for version bump

Additional checks:

No specific code changes in Brave (only line number changes in patches).

kjozwiak commented 1 year ago

The above requires 1.44.101 or higher for 1.44.x verification 👍

kjozwiak commented 1 year ago

With the above, the only platform that still needs to check the affected area's mentioned via https://github.com/brave/brave-browser/issues/24517#issue-1331902953 in Linux. The other platforms have already completed the checks re: the affected area's and will just need to run through a quick spot check. Specifically doing an upgrade to make sure everything is working as expected.

kjozwiak commented 1 year ago

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.44.101 Chromium: 106.0.5249.65 (Official Build) (32-bit)
--- | ---
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS  Android 13; Build/T1B1.220819.006
Example Example
Screenshot_20220927-032907 Screenshot_20220927-032914
GeetaSarvadnya commented 1 year ago

Verification PASSED on

Brave | 1.44.101 Chromium: 106.0.5249.65 (Official Build) (64-bit)
-- | --
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS | Windows 10 Version 21H2 (Build 19044.2006)

image

btlechowski commented 1 year ago

Verification passed on

Brave 1.44.101 Chromium: 106.0.5249.65 (Official Build) (64-bit)
Revision 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS Ubuntu 18.04 LTS

image

Verified https://github.com/brave/brave-browser/issues/24517#issue-1331902953

Color scheme (omnibox)_PASSED - Verified that omnibox color scheme is shown as expected in focused/not focused in light theme - Verified that omnibox color scheme is shown as expected in focused/not focused in dark theme **_Light theme_** ![image](https://user-images.githubusercontent.com/34715963/192494545-84f5f5a4-816d-475f-88f1-abe9e572f417.png) ![image](https://user-images.githubusercontent.com/34715963/192494577-dbedb895-bdc7-4b31-8548-3abccd383a45.png) **_Dark theme_** ![image](https://user-images.githubusercontent.com/34715963/192495049-f36ba0d1-ce66-45d7-9d07-a62b4bdbc352.png) ![image](https://user-images.githubusercontent.com/34715963/192495112-f5f4c21b-2bdb-423a-85bd-55a77b57addd.png)
History page_PASSED - Confirmed that history of all the visited websites is listed in brave://history - Confirmed that brave://history UI looks expected - Confirmed that user can search the specific brave history via Search option - Confirmed that imported browser history is shown in brave is as expected ![image](https://user-images.githubusercontent.com/34715963/192495597-ccc0b38f-23b9-4911-804a-22578a909182.png)
Content settings_PASSED - Confirmed content settings are working as expected **_1. Block cookies content settings_** - Open a site cnn.com - Open content settings for cnn.com - Block content settings for `Location` and `Window management` - Reload cnn.com - Ensured that `Location` and `Window management` permission are blocked for cnn.com - Open brave://settings/cookies and `Block all cookies` - Reload cnn.com and ensured that all cookies are blocked on cnn.com ![image](https://user-images.githubusercontent.com/34715963/192496758-fdac4eb1-78d5-4a4a-afb3-ae0b3683f11f.png) ![image](https://user-images.githubusercontent.com/34715963/192496822-05903f45-673d-409a-94c6-d4c83d74720d.png) ![image](https://user-images.githubusercontent.com/34715963/192497185-1e0a190c-b305-4d3d-b4be-186ba8e2ca75.png) ![image](https://user-images.githubusercontent.com/34715963/192497331-4f17631b-c582-4ab7-802a-99559e13d8dd.png) **_2. Block scripts content settings_** - Block the java scripts for a site via brave://settings/content/javascript - Open the site ensured Javascripts blocked for the site - Open a bunch of websited and ensured javascript is not blocked ![image](https://user-images.githubusercontent.com/34715963/192497896-0a645a52-545e-41d3-9fa0-be77ecb70558.png) **_3. Block autoplay global settings_** - Block the autoplay content global settings via brave://settings/content/autoplay - Open youtube.com and ensured no videos are autoplayed - Click on a video and play the video manully, wait till the 1st video ends - Ensured 2nd video is not autoplayed ![image](https://user-images.githubusercontent.com/34715963/192498335-c96d2f4f-1ce6-4209-8511-e8c219e9a227.png) ![image](https://user-images.githubusercontent.com/34715963/192498967-a5aff80b-3374-4cb0-a98c-76994dfada0e.png) ![image](https://user-images.githubusercontent.com/34715963/192499126-488bc909-6fda-4fe1-a300-ab9e6c646bf2.png)
Bookmarks_PASSED - Confirmed user can add/edit/delete the bookmarks - Confirmed bookmarks can be imported via `NTP`, `brave://settings/importData`, `Hamburger menu - import bookmarks` option and `brave://bookmarks/ - Import bookmarks` - Confirmed imported bookmarks can be opened in PT, new window, new tab and in a regular window - Confirmed that imported bookmarks are shown in Private and Tor window new tabs ![image](https://user-images.githubusercontent.com/34715963/192501432-4722206e-91ef-451f-bdc3-312297e7f21e.png) ![image](https://user-images.githubusercontent.com/34715963/192501589-54adc738-b2d6-4829-becf-b9272268729d.png) ![image](https://user-images.githubusercontent.com/34715963/192501644-b3be3b78-8580-4d95-9f62-d062d9219d29.png) ![image](https://user-images.githubusercontent.com/34715963/192501899-c4b42be2-3bf4-4cce-9938-6cba1720bd83.png)
Settings UI_PASSED - Verified that click on each settings in brave://settings redirected to the intended page - Verified the brave://settings UI and ensured UI looks good - Verified the icons in the brave://settings page and ensured icons are shown as expected in each settings page - Additional testing on settings is covered in "Settings comparision" section
Cookies_PASSED - Ensured that cookies are retained in an upgraded profile - Ensured cookies settings are working as expected - Ensured local and global cookies shield settings are working as expected **Case 1:** - Open a site cnn.com - Open content settings for cnn.com - Open brave://settings/cookies and `Block all cookies` - Reload cnn.com and ensured that all cookies are blocked on cnn.com - Open brave://settings/cookies and `Allow all cookies` - Reload cnn.com and ensured that all cookies are allowed on cnn.com ![image](https://user-images.githubusercontent.com/34715963/192502927-8866da2b-ff6f-44ef-9ee8-cac2a16d9c72.png) ![image](https://user-images.githubusercontent.com/34715963/192503022-e8b97894-4783-4cc7-abaf-9469f6820d6d.png) ![image](https://user-images.githubusercontent.com/34715963/192503110-8f9107e2-4f77-402b-a4d9-ab8959a45cad.png)
Multiple profiles_PASSED - Confirmed that user can create the multiple profiles (e.g `Profile 1` and `Profile 2`) - Change the brave://settings and import bookmarks and add extensions in `Profile 1` - Ensured that changes made in settings in Profile 1 are NOT reflected in Profile 2 - Ensured that the bookmarks and extensions are NOT reflected in Profile 2 - Enable rewards and update the rewards settings in brave://rewards in Profile 1 - Ensured that updated rewards settings are specific to profile 1 and are not reflected in Profile 2 ![image](https://user-images.githubusercontent.com/34715963/192505816-c5006997-2917-4786-ba6c-ab4406dded81.png)
First run dialog_PASSED - Confirmed first run dialog is shown when brave is launched in a clean install - Confirmed that the dialog content is as expected - Confirmed click on `Set Brave as default` button in first-run dialog set the brave as the default browser and `Make Default` is removed from the brave://settings/getStarted - Confirmed click on the `Maybe later` button in the first-run dialog doesn't set the brave as the default browser and the `Make Default` option is shown in the brave://settings/getStarted - Confirmed click on `x` close button in first-run dialog and doesn't set the brave as the default browser and `Make Default` is shown in the brave://settings/getStarted - Confirmed that the user can set the brave as default browser by clicking on the `Make Default` option is shown in the brave://settings/getStarted ![image](https://user-images.githubusercontent.com/34715963/192506673-0fc3a56c-b708-41a1-8dea-edfa2915d27a.png) ![image](https://user-images.githubusercontent.com/34715963/192506734-b3526d79-452b-4820-b217-30ceec01a632.png) ![image](https://user-images.githubusercontent.com/34715963/192506913-55bd015b-f114-4116-8739-ddce4d3481ee.png)
Side panel_PASSED - Confirmed that sidebar is shown by default in the nightly channel - Confirmed that `Reading list` icon is added to the sidebar menu - Confirmed that reading list panel is shown when user click on the `Reading list` icon in the sidebar menu - Confirmed that user can add the `list of websites` to the reading list by clicking on the `+Add current tab` - Confirmed that user can add the `list of websites` to the reading list by right clicking on the tab and choose the option `Add tab to the reading list` - Confirmed that `reading list panel can be hidden` by clicking on the `Reading list` icon in the sidebar menu - Confirmed that reading list icon is shown in the URL bar, next to wallet icon - Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar) - Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window) - Websites can't be added to reading list in Guest, encountered https://github.com/brave/brave-browser/issues/24930 - Confirmed that sites can be segregated to `Read` and `Unread` list - Confirmed that sites can be deleted from the reading list ![image](https://user-images.githubusercontent.com/34715963/192508151-aaf68596-39f4-4afa-8d46-4d5a2b5e8ed8.png) ![image](https://user-images.githubusercontent.com/34715963/192508193-bc1d12f9-548b-4b4c-b4bb-065e0f23d982.png) ![image](https://user-images.githubusercontent.com/34715963/192508244-aaa95c32-12e6-4ab7-b20a-af7b100d9c7c.png) ![image](https://user-images.githubusercontent.com/34715963/192508314-6e0c31af-359c-4d09-a219-94e4aeaaf35a.png)
New tab page_PASSED - Ensured Tops sites can be edit/delete via NTP - Ensured that NTP stats can be hidden/shown - Ensured that a site can be added via NTP - Ensured NTP Widget cards can be added/removed - Ensured NTP SI works as expected - Ensured that click on settings (bookmarks, history, settings and brave talk) shortcuts works as expected - Ensured that the existing features `upload your own` and `Brave background` works as expected - Confirmed that `NTP SI` are shown in the order 2, 4, 8 tabs - Confirmed that user can select the solid background for NTP - Confirmed that user can choose the induvidual solid background via NTP - Confirmed that same solid background is shown on each the NTP when the induvidual solid background is selected - Confirmed that the differenet solid background is shown on each the NTP when `Refresh on every new tab` switch is ON - Confirmed that user can select the gradient background for NTP - Confirmed that user can choose the induvidual gradient background via NTP - Confirmed that same gradient background is shown on each the NTP when the induvidual gradient background is selected - Confirmed that the differenet gradient background is shown on each the NTP when `Refresh on every new tab` switch is ON ![image](https://user-images.githubusercontent.com/34715963/192508445-82fe4fa5-8263-4300-9e7b-4e5f877f5ae5.png) ![image](https://user-images.githubusercontent.com/34715963/192508489-ca2d9847-971e-4d1b-ba16-885e7c0505b0.png) ![image](https://user-images.githubusercontent.com/34715963/192508583-a5a3660b-ba6a-43a3-b71b-a6c26083fb06.png)

Settings comparison

Verified that the Language settings are updated as part of CR 106 ![image](https://user-images.githubusercontent.com/34715963/192510276-f0d1672e-529b-4bad-a453-cc28262d71a5.png) Verified that content additional setting is renamed as `Windows management` as part of CR 106 ![image](https://user-images.githubusercontent.com/34715963/192510655-693a3531-8a84-4f7a-b1ef-30f2398c2bc2.png) New settings `Tab hover mode` and `Side panel` settings are added as part of Brave in nightly (1.45.x) which are already merged in Beta (1.44.x) ![image](https://user-images.githubusercontent.com/34715963/192510938-4d493334-5221-4ad3-9234-cde0dbae3901.png) Verified that `Reading list` sync data is been added in brave://sync as part of brave ![image](https://user-images.githubusercontent.com/34715963/192511042-9acece40-ceb9-460a-b0f3-3b21f2854bcc.png) Verified the each settings in brave://settings page and ensured each settings works as expected

Components updater

- No new components are added as part of CR 106 - Components are updates successfully without any error - Speedreader component is removed from nightly which is expected as per https://github.com/brave/brave-browser/issues/25116 ![image](https://user-images.githubusercontent.com/34715963/192511178-6a4ff416-350b-4273-a97a-31adbf41d4f0.png)

Brave startup calls

stephendonner commented 1 year ago

Verified PASSED using

Brave 1.44.101 Chromium: 106.0.5249.65 (Official Build) (x86_64)
Revision 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS macOS Version 11.7 (Build 20G817)
Screen Shot 2022-09-27 at 9 31 55 AM
Uni-verse commented 1 year ago

Verified on Samsung Galaxy Tab S7 using the following build(s):

Brave   1.44.101 Chromium: 106.0.5249.65 (Official Build) (64-bit) 
Revision    3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS  Android 12; Build/SP1A.210812.016

Checked versioning and branding items on clean profile installs and upgraded profile. Also performed sanity checks on the affected Android items mentioned in https://github.com/brave/brave-browser/issues/24517#issue-1331902953

- Verified Autoplay is enabled by default - User is able to add exceptions to allow or block URLs
- Verified different selectors, focus highlighting and buttons appear in light/dark mode Example | Example | Example | Example -|-|-|- ![screenshot-1664291485867](https://user-images.githubusercontent.com/17885425/192569083-a7ddfaea-6d76-4b51-990c-c3d87931e2ef.png) | ![screenshot-1664291598889](https://user-images.githubusercontent.com/17885425/192569137-8fdd462a-d9de-4891-8937-412c94ec5fc5.png) | ![screenshot-1664291636389](https://user-images.githubusercontent.com/17885425/192569191-d0d2c7ec-eaff-499d-ba2e-99d3829be3e3.png) | ![screenshot-1664291825128](https://user-images.githubusercontent.com/17885425/192569290-20f34c72-36e9-432f-9eda-b3e7debc4576.png) ![screenshot-1664291499891](https://user-images.githubusercontent.com/17885425/192569404-13ef4641-32b2-4e37-9b0b-e90dd8b6cbcb.png) | ![screenshot-1664291589414](https://user-images.githubusercontent.com/17885425/192569407-7dacbe2f-2181-4bfa-b7df-9345e8140197.png) | ![screenshot-1664291691687](https://user-images.githubusercontent.com/17885425/192569472-3c9952f6-6ee6-4c8b-abf2-e6b3cfcff354.png) | ![screenshot-1664291835343](https://user-images.githubusercontent.com/17885425/192569657-52106033-b3ff-4c0a-8e1b-89d1b0e9c09d.png)
- Verified sharing hub is enabled by default - Verified sharing hub shows up via the share menu ![screenshot-1664293735480](https://user-images.githubusercontent.com/17885425/192574120-8f942dce-dcf2-4c48-98fa-18c26461742b.png)
- Verified sharing tab by using `send to your device` via share menu once connect to sync chain Example | Example | Example | Example -|-|-|- ![screenshot-1664291903840](https://user-images.githubusercontent.com/17885425/192569897-9da34793-501d-439a-98c4-c4ea7f223466.png) | ![screenshot-1664291910846](https://user-images.githubusercontent.com/17885425/192569900-e196c888-e900-4842-bcd5-e19b74de4170.png) | ![screenshot-1664291918298](https://user-images.githubusercontent.com/17885425/192569902-28e53794-5ae7-4808-815a-b217a00213e7.png) | ![Screen Shot 2022-09-27 at 11 19 33 AM](https://user-images.githubusercontent.com/17885425/192569940-26e31ac3-2d15-4a35-8de0-5f7ec2715edb.png)

General

Example Example Example
screenshot-1664291065910 screenshot-1664291077684 screenshot-1664291310393